From: Robert Pluim <rpluim@gmail.com>
To: Andreas Schwab <schwab@suse.de>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] Make update_autogen work in git worktrees
Date: Thu, 22 Mar 2018 11:53:42 +0100 [thread overview]
Message-ID: <87sh8smle1.fsf@gmail.com> (raw)
In-Reply-To: <mvm4ll8fln0.fsf@suse.de> (Andreas Schwab's message of "Thu, 22 Mar 2018 11:30:11 +0100")
Andreas Schwab <schwab@suse.de> writes:
> On Mär 22 2018, Robert Pluim <rpluim@gmail.com> wrote:
>
>> diff --git a/admin/update_autogen b/admin/update_autogen
>> index d211867479..f4c2c39825 100755
>> --- a/admin/update_autogen
>> +++ b/admin/update_autogen
>> @@ -47,7 +47,7 @@ PD=
>> cd ../
>> [ -d admin ] || die "Could not locate admin directory"
>>
>> -[ -d .git ] || die "No .git directory"
>> +[ -d .git ] || git rev-parse --git-dir > /dev/null 2>&1 || die "Not in a git repository"
>
> Alternatively, you could test for .git being a plain file.
Yes, but I think git itself is better at working out whether weʼre in
a repository than just a script testing files.
Robert
next prev parent reply other threads:[~2018-03-22 10:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-22 9:40 [PATCH] Make update_autogen work in git worktrees Robert Pluim
2018-03-22 10:30 ` Andreas Schwab
2018-03-22 10:53 ` Robert Pluim [this message]
2018-03-23 5:55 ` Paul Eggert
2018-03-23 8:21 ` Robert Pluim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sh8smle1.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.