From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#31662: [PATCH] fix double counting bug in term.el Date: Thu, 31 May 2018 18:51:06 -0400 Message-ID: <87sh67bfs5.fsf@gmail.com> References: <87muwgpgy6.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1527807168 4946 195.159.176.226 (31 May 2018 22:52:48 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 31 May 2018 22:52:48 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: 31662@debbugs.gnu.org To: John Shahid Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 01 00:52:44 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fOWR1-0001DB-HE for geb-bug-gnu-emacs@m.gmane.org; Fri, 01 Jun 2018 00:52:43 +0200 Original-Received: from localhost ([::1]:46528 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fOWT8-0001QL-LG for geb-bug-gnu-emacs@m.gmane.org; Thu, 31 May 2018 18:54:54 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39205) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fOWQP-0007bI-CG for bug-gnu-emacs@gnu.org; Thu, 31 May 2018 18:52:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fOWQM-0003bt-7v for bug-gnu-emacs@gnu.org; Thu, 31 May 2018 18:52:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48468) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fOWQM-0003bg-4D for bug-gnu-emacs@gnu.org; Thu, 31 May 2018 18:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fOWQL-0000lW-Sv for bug-gnu-emacs@gnu.org; Thu, 31 May 2018 18:52:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 31 May 2018 22:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31662 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 31662-submit@debbugs.gnu.org id=B31662.15278070742841 (code B ref 31662); Thu, 31 May 2018 22:52:01 +0000 Original-Received: (at 31662) by debbugs.gnu.org; 31 May 2018 22:51:14 +0000 Original-Received: from localhost ([127.0.0.1]:56358 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fOWPa-0000jk-K8 for submit@debbugs.gnu.org; Thu, 31 May 2018 18:51:14 -0400 Original-Received: from mail-it0-f46.google.com ([209.85.214.46]:37016) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fOWPa-0000jX-1Z for 31662@debbugs.gnu.org; Thu, 31 May 2018 18:51:14 -0400 Original-Received: by mail-it0-f46.google.com with SMTP id l6-v6so16732154iti.2 for <31662@debbugs.gnu.org>; Thu, 31 May 2018 15:51:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=muvkubTVBPMBtrW2hg5/J88ffyXLP27Y2rFCtb1tytE=; b=MV6zz69pS95Cx6oQ6AEUUrXREbO0Tc+dpvPBO/WNEyM+XVrAqBlo/7Y8OOHxUEm5Cz rL9RtI1rD2wLGRqub1ucskSVrjE2wn4wGp4ulWL90hEru5Y7NTDcDoONUgbbnwz2qXqZ 6k1e4d4OL5PL4qi0ed4SQpctr6q2Np8IZ4aKgf9E6Twth17o+Er/sy3ndbHNr6KedMW4 zkC2v8C7e954e8PjkrcWVwNZxdfRM4QWhptKR7l/bb6TYmULEkucAGUhhSwv9/aSuXmV EcpmgyiVptKgLZ5yUT/1ZsT/MRQKdnwM7ysNakSKXsEPP1AvdNNw0pcs1TjQAHjwKdiR qEKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=muvkubTVBPMBtrW2hg5/J88ffyXLP27Y2rFCtb1tytE=; b=LV7977ktJ0T6tcIMEKJ1gwWFuFhsEso1sEnf7bGCcEEl1uKsDPT1aarkArB9GVzJXj 0d4YcvgZcTrjTG1MpuH1k4bgqBTO8+almxqblLtDX7nW3K5zzZ3gJWU1SP3B1AeJqKRi 6IY2MyopCZZgwyPYU7FiPf8rgwett4qwNtr3HdgrCQHPxTh/Z7aCPFOxwfBQHGjcNofc 8AoSB9xRcjpGRiKzfeSHK5hLFyw4Lguetapi+6+u5L9ERAiu/f/6LbVS48bzTqGaaZzk 3TG4EZyc54KoBAxFadzGjCRW7N06LkdpnefoL4drpsrhOBJ9TlLUM8lSJQ2P0js834XN 32rA== X-Gm-Message-State: APt69E1hiJBtJ3bKD4FGVsdSyIWBaV2q+iGsHOvLvGr/bShPrYdrX3RE klVes/Q/7wASkfVAExcp99BwAw== X-Google-Smtp-Source: ADUXVKJtPItsG2rkUq4Zu9f5KFhlH1+Gs3SKkYPcNmqnaVK35qXv24us0/rt4ICLfi7QkaCtEpTUVw== X-Received: by 2002:a24:74ce:: with SMTP id o197-v6mr1879450itc.107.1527807068403; Thu, 31 May 2018 15:51:08 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id o1-v6sm272484ite.37.2018.05.31.15.51.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 31 May 2018 15:51:07 -0700 (PDT) In-Reply-To: <87muwgpgy6.fsf@gmail.com> (John Shahid's message of "Thu, 31 May 2018 04:49:53 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:146784 Archived-At: John Shahid writes: > (when (not (or (eobp) term-insert-mode)) > (let ((pos (point))) > (term-move-columns columns) > - (delete-region pos (point)))) > + (delete-region pos (point)) > + (term-move-columns (- columns)))) I think it's a better idea to just reset term-current-column to nil, like what happens in Emacs 26. > + (should (equal "abcde j" > + (term-test-screen-from-input > + 10 12 (concat "\e[mabcdefghij" > + "\e[H" ;move back to point-min > + "\e[mabcde" > + "\e[m j")))) > + The "\e[m" is just to make the strings get processed separately, right? You can pass a list of strings instead: (term-test-screen-from-input 10 12 (list "abcdefghij" "\e[H" ;move back to point-min "abcde" " j"))