From: John Shahid <jvshahid@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 31325@debbugs.gnu.org, monnier@iro.umontreal.ca
Subject: bug#31325: 27.0.50; PROPOSAL: introduce a new function to recenter without redisplaying the frame
Date: Sun, 01 Jul 2018 17:18:08 +0000 [thread overview]
Message-ID: <87sh52yiwf.fsf@gmail.com> (raw)
In-Reply-To: <83fu12lwh2.fsf@gnu.org>
Eli Zaretskii <eliz@gnu.org> writes:
>> From: John Shahid <jvshahid@gmail.com>
>> Cc: rudalics@gmx.at, 31325-done@debbugs.gnu.org, monnier@iro.umontreal.ca
>> Date: Sun, 01 Jul 2018 16:54:53 +0000
>>
>> It just occurred to me that this change will break backward
>> comparability for those who bind some key to the `recenter' command,
>> since now the second argument will always be nil and thus won't
>> redisplay. Should we also change the interactive form of recenter to
>> use "p" for the second argument? That way the second arg is never nil
>> when used interactively.
>
> I think you are right.
>
> Alternatively, we could simply make 'recenter' behave specially in
> interactive invocations. But in any case, incompatible changes in
> behavior are bad, and should be avoided.
I am happy to make the change. Should we just revert this patch and
instead of adding a new argument change the behavior of`recenter' to
redraw if called interactively ?
How can we determine from C whether the function is called interactively
? Is it ok to use `called-interactively-p' ?
next prev parent reply other threads:[~2018-07-01 17:18 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-01 0:48 bug#31325: 27.0.50; PROPOSAL: introduce a new function to recenter without redisplaying the frame John Shahid
2018-05-08 1:37 ` Stefan Monnier
2018-06-28 13:27 ` John Shahid
2018-06-30 9:45 ` Eli Zaretskii
2018-06-30 20:20 ` John Shahid
2018-07-01 9:05 ` martin rudalics
2018-07-01 13:17 ` John Shahid
2018-07-01 16:22 ` Eli Zaretskii
2018-07-01 16:54 ` John Shahid
2018-07-01 17:03 ` Eli Zaretskii
2018-07-01 17:14 ` Eli Zaretskii
2018-07-01 17:25 ` John Shahid
2018-07-01 20:17 ` Drew Adams
2018-07-01 20:56 ` John Shahid
2018-07-01 23:04 ` Drew Adams
2018-07-02 2:27 ` John Shahid
2018-07-02 15:18 ` Eli Zaretskii
2018-07-01 17:18 ` John Shahid [this message]
2018-07-01 18:05 ` Eli Zaretskii
2018-07-01 18:58 ` John Shahid
2018-07-02 15:22 ` Eli Zaretskii
2018-07-02 20:38 ` John Shahid
2018-07-03 8:49 ` Robert Pluim
2018-07-03 16:38 ` John Shahid
2018-07-07 9:09 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sh52yiwf.fsf@gmail.com \
--to=jvshahid@gmail.com \
--cc=31325@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.