From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#32318: wdired-test-bug32173-02 fails Date: Tue, 31 Jul 2018 00:57:59 +0200 Message-ID: <87sh40uya0.fsf@gmx.net> References: <7263d625-faff-9dc1-b0dd-325514abe4cd@cornell.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1532991427 14445 195.159.176.226 (30 Jul 2018 22:57:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 30 Jul 2018 22:57:07 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 32318@debbugs.gnu.org To: Ken Brown Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 31 00:57:03 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fkH66-0003Xd-87 for geb-bug-gnu-emacs@m.gmane.org; Tue, 31 Jul 2018 00:57:02 +0200 Original-Received: from localhost ([::1]:56222 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fkH8B-0005YQ-MJ for geb-bug-gnu-emacs@m.gmane.org; Mon, 30 Jul 2018 18:59:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58192) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fkH85-0005Y6-Dz for bug-gnu-emacs@gnu.org; Mon, 30 Jul 2018 18:59:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fkH82-0000vo-8i for bug-gnu-emacs@gnu.org; Mon, 30 Jul 2018 18:59:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58763) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fkH82-0000vi-3L for bug-gnu-emacs@gnu.org; Mon, 30 Jul 2018 18:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fkH81-00026x-QX for bug-gnu-emacs@gnu.org; Mon, 30 Jul 2018 18:59:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Jul 2018 22:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32318 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32318-submit@debbugs.gnu.org id=B32318.15329914958058 (code B ref 32318); Mon, 30 Jul 2018 22:59:01 +0000 Original-Received: (at 32318) by debbugs.gnu.org; 30 Jul 2018 22:58:15 +0000 Original-Received: from localhost ([127.0.0.1]:35548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fkH7H-00025u-I2 for submit@debbugs.gnu.org; Mon, 30 Jul 2018 18:58:15 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:55803) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fkH7E-00025g-VI for 32318@debbugs.gnu.org; Mon, 30 Jul 2018 18:58:13 -0400 Original-Received: from rosalinde ([188.101.20.252]) by mail.gmx.com (mrgmx003 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MYx2x-1fWKiZ36EF-00Vj6d; Tue, 31 Jul 2018 00:58:00 +0200 In-Reply-To: <7263d625-faff-9dc1-b0dd-325514abe4cd@cornell.edu> (Ken Brown's message of "Mon, 30 Jul 2018 14:46:51 -0400") X-Provags-ID: V03:K1:z9GgolKdH7Y2ap3IXgiDZIzcjiUooJ5iQi0ynFYxaPi0xvjG5ls J4ILiXr5bB4NGEojrnjUHe8J9W5qP25ZFs0rTM3frE3taj6f8xdtVGb8bwIuPfWUL2MTxRS xUK41E/LNJMdmbenJ1gzCB6QfBKgkUyLnWW21cclsu1hZX/+kUGAxrBz1LEA2MQavBrPLE1 9buZqLAEA9IItNxYPGT+w== X-UI-Out-Filterresults: notjunk:1;V01:K0:1E1/LzBw2ls=:Od/6HTYI69sCKcj0BxxsNs n4taAJ9nzgFpxFifB/WcCy4kqnOJdDx+BtqUILNVqk3WHizYNAqG+ZizWRmudGRwSab9VRZ2P bkKNwe5tZVSAqKpMAJBm4+nnIRFdzn39E4Tz1r1zZME8kZz8EQmSI2qF5tI0qphYxbspo+MAd fgY1d7qXlQO1eeqi/w1KKByrP4S2ULijVn/7qL6pR/WQPaLDgKEMRP5+Upnq6iC/Pgknxd0v1 zdvQ9bb272OBgKZnFc6cAVHgGhgU+0GRIBtQHB4G//q5X3cbihRqInTuXh9vwfuZQR5MjLdJO x2Jor4ryLPJ4breoxnXZrtsbVhHqnRrfWzkJmgvSdQcvWuEZZ4xMDKuyoL2ElMkE28vmnQWMp VwZ3KrIApaJSgvG9zNlPEF8DUNmcpa2ve1bW3JzqNfR6tbdyxwdCSci72uz2Z/t0N7YDwNk08 vkVOKJkYk5FSlno7ozF+x/fLK2mghxk7ttEbKCjcJNjHmHxMnHypAochzUgilkY5iBwvUhJQL 6GIfyj+zrMBZLk+Wdnh9jprVIKItTzOwmsrhj2l4UoHHForbOPG2lGToEFUhs0mKqSmD9ihLX LseqoUGCegUB62VJXgq58lHF64HnW9xDy1kvN3TVvjrD3nwrwrQL1B8mqAaje7d3XzhUKHoEv swg1HCsaoyv4Rn+7Bdwd+4uEeowY2kZq76Mq0eiZDKYPgBaukVE0CnJD7ouuyQ/xTM7vEt97A 2qeAA4MxhrXjdoY9e+7XHSP5DMyJ+skOxPefhDYi2qCpAduqK+MvjzEc8uF+MvSnflU2WTDc X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149088 Archived-At: On Mon, 30 Jul 2018 14:46:51 -0400 Ken Brown wrote: > On 7/30/2018 2:02 PM, Glenn Morris wrote: >> Package: emacs >> Severity: minor >> Version: 26.1.50 >> >> emacs-26 branch at 0252f73, RHEL 7.5, wdired-test-bug32173-02 fails, see >> log below. Identical failure on hydra.nixos.org, see eg >> https://hydra.nixos.org/build/78668940 . > > I'm seeing the same thing on Cygwin, but only if the test is run from > wdired-tests.elc (which happens by default when you run 'make check'). But the > test passes if it is run from wdired-tests.el: > > $ make -C test wdired-tests TEST_LOAD_EL=yes > make: Entering directory '/home/kbrown/src/emacs/i686/test' > make[1]: Entering directory '/home/kbrown/src/emacs/i686/test' > GEN lisp/wdired-tests.log > Running 3 tests (2018-07-30 14:41:43-0400, selector `(not (tag :unstable))') > Press C-c C-c when finished or C-c ESC to abort changes > passed 1/3 wdired-test-bug32173-01 (0.426361 sec) > Press C-c C-c when finished or C-c ESC to abort changes > passed 2/3 wdired-test-bug32173-02 (0.240313 sec) > Press C-c C-c when finished or C-c ESC to abort changes > passed 3/3 wdired-test-unfinished-edit-01 (0.130247 sec) > > Ran 3 tests, 3 results as expected (2018-07-30 14:41:44-0400, 0.797493 sec) I think I've fixed this now, simply by requiring wdired (in emacs-26 951c5a1). I had run make check several times before pushing the test file and all tests were as expected, though there were a few byte-compiler warnings. But after reading your reports, I also tried a batch run on the compiled file and got the same failure. Then I stepped through the ert test run in edebug and found that on the first run from emacs -Q, wdired-use-interactive-rename was nil at the point of failure, though it was let-bound to t; on rerunning the test the let-binding held. I don't know why that happened, but I guess the autoloads in wdired.el aren't enough to make sure all variables and functions are defined when used, though again, I hadn't seen unexpected failures with make check. Anyway, requiring the library being tested should have been obvious, and I hope the problem is solved now. Steve Berman