From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#32372: [PATCH] Add "uuid" to thing-at-point.el Date: Fri, 10 Aug 2018 01:20:13 +0300 Message-ID: <87sh3nxjvm.fsf@tcd.ie> References: <87h8k88l47.fsf@konghq.com> <87effc8kj1.fsf@konghq.com> <8736vsz0mo.fsf@gmail.com> <878t5j9674.fsf@konghq.com> <87mutzxq3k.fsf@gmail.com> <87600m8vn9.fsf@konghq.com> <87600m48pq.fsf@violet.siamics.net> <8736vny1c8.fsf@konghq.com> <87bmab2yu1.fsf@violet.siamics.net> <87zhxvwf1c.fsf@konghq.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1533854012 11890 195.159.176.226 (9 Aug 2018 22:33:32 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 9 Aug 2018 22:33:32 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Ivan Shmakov , 32372@debbugs.gnu.org, Noam Postavsky To: Raimon Grau Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 10 00:33:28 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fntUl-00030e-U8 for geb-bug-gnu-emacs@m.gmane.org; Fri, 10 Aug 2018 00:33:28 +0200 Original-Received: from localhost ([::1]:53390 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fntWs-00034D-Hq for geb-bug-gnu-emacs@m.gmane.org; Thu, 09 Aug 2018 18:35:38 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56465) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fntIn-0005PE-AY for bug-gnu-emacs@gnu.org; Thu, 09 Aug 2018 18:21:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fntIk-0002tF-Me for bug-gnu-emacs@gnu.org; Thu, 09 Aug 2018 18:21:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41195) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fntIk-0002sy-Gi for bug-gnu-emacs@gnu.org; Thu, 09 Aug 2018 18:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fntIk-0002Py-8o for bug-gnu-emacs@gnu.org; Thu, 09 Aug 2018 18:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Aug 2018 22:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32372 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 32372-submit@debbugs.gnu.org id=B32372.15338532309231 (code B ref 32372); Thu, 09 Aug 2018 22:21:02 +0000 Original-Received: (at 32372) by debbugs.gnu.org; 9 Aug 2018 22:20:30 +0000 Original-Received: from localhost ([127.0.0.1]:46213 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fntIE-0002Op-8O for submit@debbugs.gnu.org; Thu, 09 Aug 2018 18:20:30 -0400 Original-Received: from mail-lf1-f51.google.com ([209.85.167.51]:44091) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fntIB-0002OX-Fm for 32372@debbugs.gnu.org; Thu, 09 Aug 2018 18:20:28 -0400 Original-Received: by mail-lf1-f51.google.com with SMTP id g6-v6so5203083lfb.11 for <32372@debbugs.gnu.org>; Thu, 09 Aug 2018 15:20:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=yvO5U7ovjMo/qT9ktZbVtAySZvrO7xOmjxY8y4REo2c=; b=2Ni+gatYuRnBIV/0BsQkjeunphEAtHIEgHUAPP0pVxXhjN79YOQKyQH98W8ZlFpL+u fdwwuCLiMoN0B9MCkkgoAnquLL+m+0EkSAa6akP/fJGPRVqwqifDNNYmKoirOVTmZw8S gIqmmusQIAlodnz47yeZNazBpZXWsJl0mEgZp9BvpXd1FvfGAGT8BD61kuQM6TgrIdl/ RPyDawISi+2aS9CtWmOB+sj6Eg3fVx0nA8xY103ZpjRBVSVgQlqpKVhfd/Fom4m0jKhY mXQ9hVAQo0Z9sRCB66wp/mAF6JQpoUFOe2HsBG73ODiuQ2RhTWS9cJoyKQwUXQNInup1 KTzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=yvO5U7ovjMo/qT9ktZbVtAySZvrO7xOmjxY8y4REo2c=; b=WZrHlW70d+wnQWuVaUNqwZxZFtwdO6HDqE00kagO5PrDXzYow1XfdbNQ9HR+NdO4bb 9lpwRm0FsTmt0WkqHnTz24vqUH2vGhypn2lSZ8PtAjRMyfo2YDm//eQqgXCIikC3DboG mELbmHQpF0KfIMhAb5oT4xFa/J9JgMsSKE8BMzuvRB37bdntuWtw53kAGwQ3UbX6NeL7 ljqpm8z8FVvwVjy1muPeT9Qe0aCvqVUAjkl2mlhT3pfRgJZQTtinSLdebn5iFXFTKI+4 KKMyKVmLASMjnrbQ4NLOqHVYaW/oKygVEiDyZ7xwWu8yFA2Hie18+XXFKQT/V85yHap8 1Zuw== X-Gm-Message-State: AOUpUlEkZIFJa6Ds6xXVS+zI1LbQAO5utyP7uD+IAlI0lqhD2mWIzjV5 AFy2CTcMKE4Pe5oONrC9Qx2LWw== X-Google-Smtp-Source: AA+uWPxahwuYjIxtigLotqZ9jzODcyrmazqC+XFvL9IghsMKe4DvXh/+ICxcVzeqVfvSYi3RyqLTVg== X-Received: by 2002:a19:17c2:: with SMTP id 63-v6mr2594364lfx.112.1533853221378; Thu, 09 Aug 2018 15:20:21 -0700 (PDT) Original-Received: from localhost (adsl-91.91.140.88.tellas.gr. [91.140.88.91]) by smtp.gmail.com with ESMTPSA id h90-v6sm1352748lji.66.2018.08.09.15.20.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 09 Aug 2018 15:20:20 -0700 (PDT) In-Reply-To: <87zhxvwf1c.fsf@konghq.com> (Raimon Grau's message of "Thu, 09 Aug 2018 19:50:07 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149396 Archived-At: Raimon Grau writes: > Ivan Shmakov writes: > >> While either =E2=80=98and=E2=80=99 or =E2=80=98if=E2=80=99 can be used = here, to exactly the same >> effect, the indentation above is one for =E2=80=98if=E2=80=99; =E2=80= =98and=E2=80=99 should instead >> look like: >> >> (and (thing-at-point-looking-at thing-at-point-uuid-regexp 36) >> (cons (match-beginning 0) (match-end 0))) >> >> I think in this case it=E2=80=99s marginally better to keep indentation >> and replace =E2=80=98and=E2=80=99 with =E2=80=98if=E2=80=99 than the ot= her way around. > > What about `when'? Is it ok to use it? > > One branch 'if' look funny to me but I don't see many (any?) `when' in th= e emacs > codebase. If you grep the codebase you will see countless occurences of and, or, if-then, if-then-else, when, unless, etc. What to use here is a mostly a matter of personal style, and a bit of a bikeshed at that, so you are likely to get varied opinions. At the end of the day it doesn't really matter what you go with. If you're interested in reading some opinions and common conventions on this, see https://emacs.stackexchange.com/q/14195/15748. FWIW, Ivan's argument to use 'if' instead of 'and' just to preserve indentation doesn't apply here, as your patch is adding new code, not modifying existing code in-place, where preserving surrounding indentation would create a cleaner diff. --=20 Basil