From: Juri Linkov <juri@linkov.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 33476@debbugs.gnu.org
Subject: bug#33476: [PATCH] Fix occur revert with list-matching-lines-jump-to-current-line
Date: Sun, 09 Dec 2018 01:16:44 +0200 [thread overview]
Message-ID: <87sgz74nj7.fsf@mail.linkov.net> (raw)
In-Reply-To: <831s6s5q11.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 08 Dec 2018 11:25:14 +0200")
>> > I reproduced this bug with Emacs 26.1 and 26.1.90 using -Q option.
>> >
>> > When pressing 'g' (revert-buffer) in an *Occur* buffer, in the case of
>> > having `list-matching-lines-jump-to-current-line' set to non-nil, the
>> > function errors as it can't find orig-line.
>> >
>> > I'm attaching a patch that adds a guard to the list of guards before
>> > inserting the current line.
>>
>> Eli, is it ok to install this submitted patch to the release branch emacs-26?
>> At least, it prevents the error signal.
>>
>> I see that for Emacs 27 in master this feature is completely rewritten.
>
> It was rewritten to fix the same bug, AFAIU, see bug#32543. Why do we
> need to solve it again in emacs-26?
I guess porting the fix from master to emacs-26 is not safe.
> And which patch do you propose for the emacs-26 branch?
I propose to install the patch from OP. This patch avoids the error.
It still might behave incorrectly in some cases, but at least it
doesn't raise the error.
>> But still I found a bug in master that can be fixed with another patch.
>> The following patch is for Emacs 27:
>
> What is the bug you found in the master branch?
In the master branch when `list-matching-lines-jump-to-current-line'
is non-nil, it doesn't show the current line highlighted.
next prev parent reply other threads:[~2018-12-08 23:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-23 21:10 bug#33476: [PATCH] Fix occur revert with list-matching-lines-jump-to-current-line Raimon Grau
2018-11-24 21:54 ` Juri Linkov
2018-11-26 17:54 ` Eli Zaretskii
2018-12-08 9:25 ` Eli Zaretskii
2018-12-08 23:16 ` Juri Linkov [this message]
2018-12-09 7:55 ` Eli Zaretskii
2018-12-09 23:54 ` Juri Linkov
2018-12-10 6:27 ` Eli Zaretskii
2018-12-11 4:40 ` Richard Stallman
2018-12-11 23:07 ` Glenn Morris
2018-12-12 17:07 ` Eli Zaretskii
2018-12-13 0:12 ` Richard Stallman
2018-12-13 8:57 ` Robert Pluim
2018-12-13 21:14 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sgz74nj7.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=33476@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.