From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] scratch/fix-33794-extend-electric-layout-mode 41a9132: Extend electric-layout-mode to handle more complex layouts Date: Sat, 22 Dec 2018 21:23:25 +0000 Message-ID: <87sgyp6ysy.fsf@gmail.com> References: <20181221180327.7142.84494@vcs0.savannah.gnu.org> <20181221180328.D755D20538@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1545513703 10143 195.159.176.226 (22 Dec 2018 21:21:43 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 22 Dec 2018 21:21:43 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Dec 22 22:21:39 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gaoiI-0002XJ-RK for ged-emacs-devel@m.gmane.org; Sat, 22 Dec 2018 22:21:38 +0100 Original-Received: from localhost ([::1]:33038 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gaokP-0008Sk-En for ged-emacs-devel@m.gmane.org; Sat, 22 Dec 2018 16:23:49 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34607) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gaokJ-0008SR-FY for emacs-devel@gnu.org; Sat, 22 Dec 2018 16:23:44 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gaokE-0003On-Dd for emacs-devel@gnu.org; Sat, 22 Dec 2018 16:23:43 -0500 Original-Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]:40348) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gaokA-000398-GB for emacs-devel@gnu.org; Sat, 22 Dec 2018 16:23:36 -0500 Original-Received: by mail-wm1-x32d.google.com with SMTP id f188so8828791wmf.5 for ; Sat, 22 Dec 2018 13:23:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=iRA1rauEYVpU1N3MJQcWU1+Dvq4PAvPq+YZkmZcBr6s=; b=Ex2RD4dEwQAXPstIBWGrqIUdB3XqYhpH30rVssVaCKQ41sitfq3hmosiFtI462cJTy mZloJ7YnuQVf3ysX5D9rLm7v/0Yp+2K0dqAyMJ5rHspQvp63xx3EE2lJ1uOuWIRkM3VP mwgjoii9kt+DK+wHNYP3xU4cwHu3m8UxuEO8lKooM3gwthaXLGaS7pGxpGv4+1tzj+un dQuShnCXBT7MKQhjNlmqVfZ2VXrU04T5cLpklrDlzH4xCifov0ItoeSuRD3lJ9vUMHjn CAXzTuUVvUASlR5SofAzuJEdZ1GEaw9vWAi/XFZc7HuTlvKXq/SD0FVD8CFn6pGFht4A 5vrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=iRA1rauEYVpU1N3MJQcWU1+Dvq4PAvPq+YZkmZcBr6s=; b=Ih5clIk11qVh8xIsT/v30TmBdydHMb+G/4MpiGHAZuz6XO06yLkDEBaN8B7beYXheZ G62G7VlXDNNk5NSTk2wnlGDBnJ9rRZhLI8AQNFaoHcU411Otk9+zvdHXoLT28b6aEoBG Q662wbiTDdR01mp1il29wVXHCKeL6jAQkQEjfKx1dif3kV92Iofg+P1FATn6c4guo/R/ PILIMFPvuf+jQ6ELOS6b46U5Je0AW/pdaSFYm5gVN70AjNMX5DrZhlfke4/T/5hWb43x fSKzIAmDdJ8K45LwXmnSHu1IwIAR5BEuokLT5IoHo2hcReVuyK4vW0/J6HtsiaOhGxyu rDwQ== X-Gm-Message-State: AJcUuke1kmbMNtUp5XVS7mzwwUD6Ovb2xZW3zHI+Q7B7kQWNaobOy51V 3WMdsZkJvEJlIB8UXOpzH1cl0/qG X-Google-Smtp-Source: AFSGD/Vb8e7MYevG+AHPqqeC5ZNQOPpJAgWDR+BKzrUIQhmKBJbjgMyHyCdx6euN6cxm6EwKAKvWLA== X-Received: by 2002:a1c:68d7:: with SMTP id d206mr7085116wmc.43.1545513807454; Sat, 22 Dec 2018 13:23:27 -0800 (PST) Original-Received: from lolita.yourcompany.com (188.139.62.94.rev.vodafone.pt. [94.62.139.188]) by smtp.gmail.com with ESMTPSA id k15sm17225632wru.8.2018.12.22.13.23.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 22 Dec 2018 13:23:26 -0800 (PST) In-Reply-To: (Stefan Monnier's message of "Sat, 22 Dec 2018 11:26:14 -0500") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::32d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:231961 Archived-At: Stefan Monnier writes: >> + ('after-stay (save-excursion >> + (let ((electric-layout-rules nil) >> + (electric-pair-open-newline-between-pa= irs nil)) >> + (newline 1 t)))) > > I think the above let-binding of > electric-pair-open-newline-between-pairs deserves a FIXME as well, > because electric-layout-mode should ideally not need to know such > details of about electric-pair-mode. Done. Indeed, as I described in the fixme electric-pair-open-newline-between-pairs is really a question of layout (not pairing) and thus a responsibility of e-l-m, but its API is not powerful enough yet to detect the exact situation yet. So it seems reasonable for now to do this, especially since electric-pair-open-newline-between-pairs is a part of e-p-m's external interface. Jo=C3=A3o