From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#34671: 27.0.50; Outdated code listings in (elisp) Example Major Modes Date: Sat, 02 Mar 2019 11:36:51 +0000 Message-ID: <87sgw54jzx.fsf@tcd.ie> References: <87bm2yqyhj.fsf@tcd.ie> <877edmqy19.fsf@tcd.ie> <83imx2j3xn.fsf@gnu.org> <87d0naml7s.fsf@tcd.ie> <83mumdhgi8.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="245862"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 34671-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Mar 02 12:38:21 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h02yA-0011nS-Sm for geb-bug-gnu-emacs@m.gmane.org; Sat, 02 Mar 2019 12:38:19 +0100 Original-Received: from localhost ([127.0.0.1]:52978 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h02y9-0008K7-S8 for geb-bug-gnu-emacs@m.gmane.org; Sat, 02 Mar 2019 06:38:17 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:43447) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h02y2-0008Ia-EH for bug-gnu-emacs@gnu.org; Sat, 02 Mar 2019 06:38:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h02y1-0001Jo-4V for bug-gnu-emacs@gnu.org; Sat, 02 Mar 2019 06:38:10 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43479) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h02xv-0001Bn-3Y for bug-gnu-emacs@gnu.org; Sat, 02 Mar 2019 06:38:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h02xv-0007Sk-0H for bug-gnu-emacs@gnu.org; Sat, 02 Mar 2019 06:38:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Mar 2019 11:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34671 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 34671-done@debbugs.gnu.org id=D34671.155152662328595 (code D ref 34671); Sat, 02 Mar 2019 11:38:02 +0000 Original-Received: (at 34671-done) by debbugs.gnu.org; 2 Mar 2019 11:37:03 +0000 Original-Received: from localhost ([127.0.0.1]:57018 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h02wx-0007R8-Bf for submit@debbugs.gnu.org; Sat, 02 Mar 2019 06:37:03 -0500 Original-Received: from mail-ed1-f46.google.com ([209.85.208.46]:40986) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h02wt-0007QY-B2 for 34671-done@debbugs.gnu.org; Sat, 02 Mar 2019 06:37:01 -0500 Original-Received: by mail-ed1-f46.google.com with SMTP id x7so496230eds.8 for <34671-done@debbugs.gnu.org>; Sat, 02 Mar 2019 03:36:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:message-id:references:date:in-reply-to :user-agent:mime-version; bh=ubwck8R8+YwtSa1S2ppRcEETAwtcrURBQdmiHcSuEoY=; b=qOoXrAHvICjGjP5J6u/QiX79PTJVcay1B1dmdlpfsivOHwNX/FoW1bEB+pWbUg4k/h Mw9tNJiAjSXNMHDF9wRrsesnSyR8Y71Ak8jhzEpOeMrKpyhx4hOQuxd3r9kEXMp8YEqd RUwNUD8qhj7m7aVL7rsJYYgsJBHaOLk8oAkNtmJijwe64oBjjaOPhBv93v/WiJzUnE1l DRqVkGeFb45yesnHyteT5M+SgAy07wo3oVsHMHpYlWSVBH0nkHpkzW38LtacA0Vaxreu DFEZRQMNuU/RmqDfUNJQOa6ziwpAHeP7piuy8WxuMlxLLgXTPoLirFQQnUK0fcTrRWy7 FL+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:message-id:references:date :in-reply-to:user-agent:mime-version; bh=ubwck8R8+YwtSa1S2ppRcEETAwtcrURBQdmiHcSuEoY=; b=LmzsIMM7V0oFvfgi6SI6/XteBGGdpZvQcWZU7lkN86pnmD7SK5I22/fzMOMXJGW9fV znZvRbI1Voy9kv2ZH77gGwBc8BhQ4nr6I+Oe0upT8Tw35eagtqB2KUv/nHw9cfjt/ZZJ ESaqo4T5/xJeMn5/GIWuXGuFrUCVgrP220ZyrwXJvfe4mlIuKe/YXxa01yzKFTwq2s6d F6+XpUkDosYIAiW6vc+rlsNEtQaoYgOHsJqL40+ISNxnjvZwV6HkGW8GQFtCn0fLBo0D qjXI/EBhE5XbjO5YXDGs/rdd0/lb3m/6++iTbL9jeVcpJazQur8CRIZbN8Xb+H5fXiS5 bWXw== X-Gm-Message-State: APjAAAV/x67XXwRBHANrVVnwJ/bxVxitGOKCi9/xOqmASHv2bkxCqye4 9KFNL73kcLNhw81xLKlK2p9ZUA== X-Google-Smtp-Source: APXvYqylnzsA4v1ZXG7NHhNZ7DnxpCTdLT4/jDQdZjkX1AMFzTm9S8IsGCNFhL5HR3Su/AFcwAkhqQ== X-Received: by 2002:a17:906:190f:: with SMTP id a15mr6218822eje.231.1551526613379; Sat, 02 Mar 2019 03:36:53 -0800 (PST) Original-Received: from localhost ([136.206.5.71]) by smtp.gmail.com with ESMTPSA id h44sm275644edh.34.2019.03.02.03.36.52 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sat, 02 Mar 2019 03:36:52 -0800 (PST) In-Reply-To: <83mumdhgi8.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 2 Mar 2019 09:39:27 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:155949 Archived-At: tags 34671 fixed close 34671 26.2 quit Eli Zaretskii writes: >> From: "Basil L. Contovounesios" >> Cc: <34671@debbugs.gnu.org> >> Date: Fri, 01 Mar 2019 19:46:31 +0000 >> >> Sorry, I don't have write access, so someone else will have to do that. > > Done. Thanks. >> BTW, is one expected to be a package author before it is acceptable to >> request write access, or is it a matter of amassing enough flight hours? > > The latter. I think you are there already, so feel free to create a > user on Savannah and then request write access. > >> >> The second patch enables lexical-binding in text-mode.el along with some >> >> minor aesthetic changes. >> > >> > I don't see the need for parts of this patch. Enabling >> > lexical-binding is OK, but it should be a separate change unrelated to >> > this bug report. >> >> Should I submit a new bug report for that, or message emacs-devel? > > The latter, I think, since the main issue here is how well was the > package tested after turning on lexical-binding. Thanks, will do (on both counts). >> > And I'm not sure I see the reason for the other changes, nor even >> > agree with them. In particular, please modify whitespace only where >> > you actually make other non-trivial changes. >> >> (Oops, looking back I accidentally mangled some Texinfo escape >> characters by copy-pasting.) >> >> I agree with this principle, but simply thought that a file-wide change >> like enabling lexical-binding was sufficient excuse for minor "cleanups" >> along the way. > > Not in such a sweeping manner. In general, only in the same > function/code fragment where you are making changes. > >> I assume the parts of the patch you're least keen on are: >> >> * lisp/textmodes/text-mode.el (text-mode-syntax-table): Align comments >> to comment-column. >> (toggle-text-mode-auto-fill): Hoist save-current-buffer out of loop. >> (center-region): Tiny simplification. >> >> but that you're okay with the following: >> >> * lisp/textmodes/text-mode.el: Use lexical-binding. >> (text-mode-map, text-mode): Refill docstring. >> (text-mode, paragraph-indent-minor-mode, text-mode-hook-identify): >> Use setq-local. >> (center-line): Tiny simplification. > > Refilling doc strings also caused me to raise a brow. IMO, that is > only justified if the original doc string is badly formatted, like has > overly-long lines, close to or longer than 80 columns. Otherwise, we > don't generally refill doc strings we don't change, we only make sure > they look well and read clearly on the screen. Fair enough, will be more careful in future. In my defence, I only refilled these two docstrings after adding an Oxford comma to text-mode-map and in order to avoid a leading space in text-mode. >> >> The last patch fulfils an old promise in the manual to eventually forgo >> >> setting indent-line-function in text-mode, which is considered >> >> redundant. >> > >> > What if the user customizes the default values, shouldn't text-mode >> > reset that in the buffer where it is turned on? >> >> I can think of two reasons for keeping the reset in text-mode: >> >> 0. If text-mode breaks when indent-line-function is set to anything >> other than indent-relative. >> >> I'm not sure, but I don't think this is the case, as I set the >> variable in text-mode-hook for a while without any noticeable >> fallout. >> >> 1. To avoid a user-visible change of behaviour with user configurations >> (like mine) which change the default global value of >> indent-line-function. >> >> The only reason (I can think of) to remove the reset is in order to >> fulfil the relevant promise in the manual. >> >> Keeping the reset is clearly less risky. I don't mind either way, so >> long as the side-note in the manual accurately reflects future >> intentions. > > Maybe we should make the change you propose, but it isn't clear-cut > and requires discussion in a separate bug report, or perhaps even on > emacs-devel. It certainly isn't cleanup. Agreed, will ask elsewhere, so I'm closing this ticket. Sorry for the hassle. Thanks, -- Basil