From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: phillip.lord@russet.org.uk (Phillip Lord) Newsgroups: gmane.emacs.devel Subject: Re: Core ELPA was: Testing fontification, indentation, and buffer manipulation Date: Sun, 03 Mar 2019 18:06:26 +0000 Message-ID: <87sgw3bzod.fsf@russet.org.uk> References: <7803c5de-e139-01ed-e9e3-98abb875782b@grinta.net> <2d777e7b-28d9-36a5-073d-b439fca9706a@grinta.net> <1548067539.3478998.1639830432.03003247@webmail.messagingengine.com> <87bm47558t.fsf@russet.org.uk> <87pnsm2vsm.fsf@russet.org.uk> <878sz7u2f5.fsf@russet.org.uk> <87o976p6xt.fsf_-_@russet.org.uk> <87tvgm7fnu.fsf@russet.org.uk> <87sgw6i89k.fsf@russet.org.uk> <875zt15y0x.fsf@russet.org.uk> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="244156"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 03 19:06:40 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h0VVY-0011PK-8c for ged-emacs-devel@m.gmane.org; Sun, 03 Mar 2019 19:06:40 +0100 Original-Received: from localhost ([127.0.0.1]:42604 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h0VVX-0002n8-9F for ged-emacs-devel@m.gmane.org; Sun, 03 Mar 2019 13:06:39 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:52945) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h0VVQ-0002n0-K7 for emacs-devel@gnu.org; Sun, 03 Mar 2019 13:06:33 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h0VVO-0003L9-NB for emacs-devel@gnu.org; Sun, 03 Mar 2019 13:06:32 -0500 Original-Received: from cloud103.planethippo.com ([78.129.138.110]:48426) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h0VVO-0003Dv-7P for emacs-devel@gnu.org; Sun, 03 Mar 2019 13:06:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=russet.org.uk; s=default; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=D1gc6q0CevlL6ym0mr948Qz7iR/p3yflkabPcgWRQ1Y=; b=VAWb0DPQUtp+D5TWHQg9XdvZB uKcOom/9Za9DvmbsdhMz/TdulEWDSKLx1zOTlvn1R6zjPGcehmFHTglxcfC3gDrl8e7dHt9aGjyRA hY5/yI+2YkWQe54X6aN3lUXFIUJa6b3zdXM4rpP47ePaFNiJ87BPBuqj0dl3Mfss4wwU513n/5VsW stJY8wzjkaJv9nKqUKpsC/LFzLccrCJnguwJzDilsZCEsxuCsmBhX2572sZCJeZRPna0nsbuYa1k8 096X9kc3NMqbO1SpfCxot7QbjKeyZnAMaDcG4iXNjCy9rMJOdiyR7QXvNqI4R5k5qdiSH933sh8r/ D4YtflapA==; Original-Received: from cpc142652-benw12-2-0-cust953.16-2.cable.virginm.net ([82.21.43.186]:51574 helo=russet.org.uk) by cloud103.planethippo.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1h0VVL-0001ec-N9; Sun, 03 Mar 2019 18:06:27 +0000 In-Reply-To: (Stefan Monnier's message of "Sat, 02 Mar 2019 22:23:17 -0500") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cloud103.planethippo.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - russet.org.uk X-Get-Message-Sender-Via: cloud103.planethippo.com: authenticated_id: phillip.lord@russet.org.uk X-Authenticated-Sender: cloud103.planethippo.com: phillip.lord@russet.org.uk X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 78.129.138.110 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:233803 Archived-At: Stefan Monnier writes: >> The problem with branches is that what is on the branch changes. My >> feeling is that the build process should be repeatable; so building >> emacs-27.1-with-elpa.tgz should not result in different tar balls as >> ELPA changes. > > By principle, GNU ELPA packages don't have to be "in-sync" with Emacs, > so this is not terribly important. I'm unconvinced. I think a build should be repeatable. Imagine bisecting a bug that has come up in an ELPA package when you are not sure whether it's the package or Emacs core that has broken things. Of course, this makes continuous integration harder. The solution there is, I think, to run "make test" on the ELPA repository against the current Emacs build. This already runs on head of all branches I think. > I think on Emacs `master` we won't want to use fixed SHAs but will just > use whatever's on `master` of elpa.git. On the release branch, we'll > probably want to be more specific, using corresponding branches. That might mean multiple branches of master which would produce a very cluttered namespace. The problem is that ELPA currently uses a different (non git) mechanism to identify the current version of every package; so you can't identify this from git metadata (except for SHA!). >> Finally, neither solve the problem -- if a branch or tag is add >> EMACS/elpa/Makefile.in which exists in the ELPA repo, but not in the >> clone on the local machine the build will fail. > > I think the use of branches/tags will make it sufficiently infrequent > that it's not a big deal. Also the build shouldn't completely fail. Beyond removing the configure option, it will fail at the moment. I could do something else beyond that. But surely, by default, the build should fail, if something fails? Phil