all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: pinkanon pinkanon <pinkanon.pinkanon@yandex.ru>
Cc: 34939@debbugs.gnu.org
Subject: bug#34939: Some minibuffer behaviour is annoying
Date: Sun, 31 Mar 2019 23:29:11 +0300	[thread overview]
Message-ID: <87sgv2pz3c.fsf@mail.linkov.net> (raw)
In-Reply-To: <87a7hasuz4.fsf@mail.linkov.net> (Juri Linkov's message of "Sun,  31 Mar 2019 22:49:51 +0300")

>> (1) when I press backspace and the prompt is empty, minibuffer tells me
>> "Text is read-only". You. Don't. Say.
>
> Messages in the echo area should not conceal the minibuffer.  Period.
>
> There is a special function minibuffer-message for this purpose:

There is another place where messages conceal the minibuffer:
running a version-control command that asks for a branch name
and typing TAB for completion runs a command to fetch branch names.
Its output conceals the minibuffer when vc-command-messages is non-nil.
Here is a fix:

diff --git a/lisp/vc/vc-dispatcher.el b/lisp/vc/vc-dispatcher.el
index edbb83f3df..c4b327a3f0 100644
--- a/lisp/vc/vc-dispatcher.el
+++ b/lisp/vc/vc-dispatcher.el
@@ -324,7 +324,8 @@ vc-do-command
 		       (apply 'start-file-process command (current-buffer)
                               command squeezed))))
 		(when vc-command-messages
-		  (message "Running in background: %s" full-command))
+		  (let ((inhibit-message (eq (selected-window) (active-minibuffer-window))))
+		    (message "Running in background: %s" full-command)))
                 ;; Get rid of the default message insertion, in case we don't
                 ;; set a sentinel explicitly.
 		(set-process-sentinel proc #'ignore)
@@ -332,11 +333,13 @@ vc-do-command
 		(setq status proc)
 		(when vc-command-messages
 		  (vc-run-delayed
-		    (let ((message-truncate-lines t))
+		    (let ((message-truncate-lines t)
+			  (inhibit-message (eq (selected-window) (active-minibuffer-window))))
 		      (message "Done in background: %s" full-command)))))
 	    ;; Run synchronously
 	    (when vc-command-messages
-	      (message "Running in foreground: %s" full-command))
+	      (let ((inhibit-message (eq (selected-window) (active-minibuffer-window))))
+		(message "Running in foreground: %s" full-command)))
 	    (let ((buffer-undo-list t))
 	      (setq status (apply 'process-file command nil t nil squeezed)))
 	    (when (and (not (eq t okstatus))
@@ -350,7 +353,8 @@ vc-do-command
 		     (if (integerp status) (format "status %d" status) status)
 		     full-command))
 	    (when vc-command-messages
-	      (message "Done (status=%d): %s" status full-command))))
+	      (let ((inhibit-message (eq (selected-window) (active-minibuffer-window))))
+		(message "Done (status=%d): %s" status full-command)))))
 	(vc-run-delayed
 	  (run-hook-with-args 'vc-post-command-functions
 			      command file-or-list flags))





  reply	other threads:[~2019-03-31 20:29 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-21 19:13 bug#34939: Some minibuffer behaviour is annoying pinkanon pinkanon
2019-03-22 16:57 ` Dmitry Gutov
2019-03-23  2:32   ` Richard Stallman
2019-03-23  9:46     ` Dmitry Gutov
2019-03-23  9:50       ` Eli Zaretskii
2019-03-23 11:24         ` Dmitry Gutov
2019-03-23 12:18           ` pinkanon pinkanon
     [not found]       ` <<83o961q5rr.fsf@gnu.org>
2019-03-23 15:51         ` Drew Adams
2019-03-31 19:50           ` Juri Linkov
2019-03-31 19:49 ` Juri Linkov
2019-03-31 20:29   ` Juri Linkov [this message]
2019-04-01 13:08     ` Dmitry Gutov
2019-04-01 20:31       ` Juri Linkov
2019-04-01 21:53         ` Dmitry Gutov
2019-04-03 20:50           ` Juri Linkov
2019-05-19 20:16       ` Juri Linkov
2019-04-01 10:10   ` pinkanon pinkanon
2019-04-01 20:25     ` Juri Linkov
2019-04-02 18:25       ` pinkanon pinkanon
2019-04-01 13:03   ` Dmitry Gutov
2019-04-01 20:29     ` Juri Linkov
2019-04-07 20:43       ` Juri Linkov
2019-04-07 23:09         ` Dmitry Gutov
2019-04-08 19:47           ` Juri Linkov
2019-04-08 22:00             ` Drew Adams
2019-04-08 23:06               ` Dmitry Gutov
2019-04-08 23:32                 ` Drew Adams
2019-04-08 23:37                   ` Dmitry Gutov
2019-04-08 23:59                     ` Drew Adams
2019-04-09  0:11                       ` Dmitry Gutov
2019-04-09 18:26                         ` Drew Adams
2019-05-24 22:49   ` Dmitry Gutov
2019-05-27 20:15     ` Juri Linkov
2019-05-27 20:58       ` Dmitry Gutov
2019-05-29 21:53         ` Juri Linkov
2019-05-29 22:26           ` Drew Adams
2019-05-30 19:50             ` Juri Linkov
2019-05-30 21:00               ` Drew Adams
2019-05-30 21:35                 ` Juri Linkov
2019-06-03 20:27           ` Juri Linkov
2019-06-04 15:15             ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sgv2pz3c.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=34939@debbugs.gnu.org \
    --cc=pinkanon.pinkanon@yandex.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.