From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs,gmane.mail.notmuch.general Subject: bug#35370: notmuch-emacs: avoiding deprecated message-default-charset Date: Sun, 21 Apr 2019 18:05:19 -0400 Message-ID: <87sgubrp40.fsf@gmail.com> References: <87tveswipo.fsf@fifthhorseman.net> <874l6re7zh.fsf@tethera.net> <87a7gjw479.fsf@fifthhorseman.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="78249"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: david@tethera.net, notmuch@notmuchmail.org, 35370@debbugs.gnu.org To: Daniel Kahn Gillmor Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 22 00:06:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hIKbD-000KCp-Sx for geb-bug-gnu-emacs@m.gmane.org; Mon, 22 Apr 2019 00:06:12 +0200 Original-Received: from localhost ([127.0.0.1]:57638 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIKbC-0003nG-U0 for geb-bug-gnu-emacs@m.gmane.org; Sun, 21 Apr 2019 18:06:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49091) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIKb6-0003m4-4U for bug-gnu-emacs@gnu.org; Sun, 21 Apr 2019 18:06:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hIKb4-0005eV-Ru for bug-gnu-emacs@gnu.org; Sun, 21 Apr 2019 18:06:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35696) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hIKb4-0005eI-Mt for bug-gnu-emacs@gnu.org; Sun, 21 Apr 2019 18:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hIKb4-0000OG-DV for bug-gnu-emacs@gnu.org; Sun, 21 Apr 2019 18:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Apr 2019 22:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35370 X-GNU-PR-Package: emacs Original-Received: via spool by 35370-submit@debbugs.gnu.org id=B35370.15558843291457 (code B ref 35370); Sun, 21 Apr 2019 22:06:02 +0000 Original-Received: (at 35370) by debbugs.gnu.org; 21 Apr 2019 22:05:29 +0000 Original-Received: from localhost ([127.0.0.1]:49240 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hIKaX-0000NR-6x for submit@debbugs.gnu.org; Sun, 21 Apr 2019 18:05:29 -0400 Original-Received: from mail-qk1-f179.google.com ([209.85.222.179]:46539) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hIKaU-0000ND-W2 for 35370@debbugs.gnu.org; Sun, 21 Apr 2019 18:05:27 -0400 Original-Received: by mail-qk1-f179.google.com with SMTP id w73so3333114qkb.13 for <35370@debbugs.gnu.org>; Sun, 21 Apr 2019 15:05:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=cMyIHanZwB6gSqnJw9bmNvRVD/syxw06OMgmbnM+01k=; b=d36q+JEtWxK7pf517F6qDdMW0JWG3qmNDYf61rhNWzZSt0n2m/ZWYpZThIrWXWBmYf U1ec1iZBbVx3f8rXFnhhSqtejiFbjr6jeWmxoRp6P/yXxrx7rujhXG+nfPnsrEN9nUxl dwuITFklqWXi1jVDVjpVq9YRMa1AcpNkCGWGrBJtiX6P80nLJ69j4X03S7c1kQxCOr7E cUr292Q0fLTp0fdPBKb+f0FnQ4D8TMjJcL7ErSP4qSpGqbHU7uAkBRn9ABJMN6vhMDPT vOgiQnuXR1twhc3p3CCdgz+C9dW7MV6bKkl1XBeTfrbUPQ4lJ+nLHls7RsavPshkJRYo 2H9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=cMyIHanZwB6gSqnJw9bmNvRVD/syxw06OMgmbnM+01k=; b=ZxnzexThmTWo4lJzjgNNv7hDjz7MTC8pFrs7J16Tj6o9Y04ZeRPBmnPGzh2Ch5ByhJ Tde9PMkjN3LYZFX2g7m7iTqOiUIIE0t+KEaY17UbSiZGSQVCdpVCW1Ngcjk0WLpqZ2L2 HZqBZty8Jm07tpOkuLnRCTZAGrOMMTa8Ezp2xdGaqK6iAxpDM908znt7jZ/WF5ePU/BY Xu8InGCNsPW6SGRf+KRnAxzDeplQqe5POy7WX3jvhKJjzXrwuVqwXL5iyBLhN1GvGHDV 0AKbXuZ2GdGb3BGBigBi97PDaLrjSRCJ/IE+XvY2vdymyPiWQYlLXz/1pYQIc1Z0yU7p ATug== X-Gm-Message-State: APjAAAWw2ks6QGgXB9B+Vpo/KAF15Rga5rznSihtD39aYXicD7xZOtPV O0CnG+himtc7w61DAsiWAw8HW88o X-Google-Smtp-Source: APXvYqzoZ6QssbIIaiPOSIm5G1ZlvqqbxOQjVrrSCW5XVR4/9kC4JITvfJ6cUuF1GS6mZbg3L8spwQ== X-Received: by 2002:ae9:e107:: with SMTP id g7mr12546255qkm.272.1555884321253; Sun, 21 Apr 2019 15:05:21 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id p46sm7095997qtc.41.2019.04.21.15.05.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 21 Apr 2019 15:05:20 -0700 (PDT) In-Reply-To: <87a7gjw479.fsf@fifthhorseman.net> (Daniel Kahn Gillmor's message of "Sun, 21 Apr 2019 15:25:46 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157969 gmane.mail.notmuch.general:27801 Archived-At: Daniel Kahn Gillmor writes: >>> In notmuch-maildir-setup-message-for-saving: >>> emacs/notmuch-maildir-fcc.el:172:31:Warning: =E2=80=98message-default-c= harset=E2=80=99 is an >>> obsolete variable (as of 26.1); The default charset comes from the >>> language environment >>> >>> I'm not enough of an emacs guru to know the right way to avoid this >>> warning, but i'm hoping that someonen else can take a stab at it, since >>> extraneous warnings make it easier to ignore real problems. >> >> Good question. I looked at message.el in emacs master and it >> >> 1) Obsoletes message-default-charset as in 26.1 >> 2) Still uses it in exactly the construction we do. > > interesting, thanks for digging that up. > >> I'm not sure if it's exactly a reportable bug in emacs, but it is a bit >> annoying. > > seems reportable, if not exactly high-severity. what does upstream > expect downstream users of message-default-charset to do? I'm > (trying to) forward this to the emacs upstream bugtracker; maybe we can > get guidance from them on what to do. The commit which marks this variable as obsolete, has a couple hunks that just remove uses of it. Not clear why other uses were left in. Oversight? [1: 66d9ef95c0]: 2016-02-14 17:07:48 +1100 Remove compat code for older Emacsen https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3D66d9ef95c0f9407d= 2a6d26bcd7ed84a303294b53 --- a/lisp/gnus/gnus-int.el +++ b/lisp/gnus/gnus-int.el @@ -777,8 +777,7 @@ (defun gnus-request-accept-article (group &optional gnu= s-command-method last (message-options-set-recipient) (save-restriction (message-narrow-to-head) - (let ((mail-parse-charset message-default-charset)) - (mail-encode-encoded-word-buffer))) + (mail-encode-encoded-word-buffer)) (message-encode-message-body))) (let ((gnus-command-method (or gnus-command-method (gnus-find-method-for-group group))) @@ -800,8 +799,7 @@ (defun gnus-request-replace-article (article group buff= er &optional no-encode) (message-options-set-recipient) (save-restriction (message-narrow-to-head) - (let ((mail-parse-charset message-default-charset)) - (mail-encode-encoded-word-buffer))) + (mail-encode-encoded-word-buffer)) (message-encode-message-body))) (let* ((func (car (gnus-group-name-to-method group))) (result (funcall (intern (format "%s-request-replace-article" fun= c))