From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Date: Thu, 02 May 2019 14:24:55 +0200 Message-ID: <87sgtxniw8.fsf@gmx.de> References: <87tvegt1ip.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="225122"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: "35418@debbugs.gnu.org" <35418@debbugs.gnu.org> To: Zhang Haijun Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 02 14:26:20 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hMAn4-000wCG-Oz for geb-bug-gnu-emacs@m.gmane.org; Thu, 02 May 2019 14:26:18 +0200 Original-Received: from localhost ([127.0.0.1]:50496 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMAn3-0002mL-NK for geb-bug-gnu-emacs@m.gmane.org; Thu, 02 May 2019 08:26:17 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43076) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMAmu-0002m2-DX for bug-gnu-emacs@gnu.org; Thu, 02 May 2019 08:26:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMAmq-0004el-3h for bug-gnu-emacs@gnu.org; Thu, 02 May 2019 08:26:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60452) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hMAmo-0004dl-AE for bug-gnu-emacs@gnu.org; Thu, 02 May 2019 08:26:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hMAmo-0008If-2k for bug-gnu-emacs@gnu.org; Thu, 02 May 2019 08:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 May 2019 12:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155679990631835 (code B ref 35418); Thu, 02 May 2019 12:26:02 +0000 Original-Received: (at 35418) by debbugs.gnu.org; 2 May 2019 12:25:06 +0000 Original-Received: from localhost ([127.0.0.1]:45762 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMAlu-0008HP-9Y for submit@debbugs.gnu.org; Thu, 02 May 2019 08:25:06 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:45471) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMAls-0008Gl-6Q for 35418@debbugs.gnu.org; Thu, 02 May 2019 08:25:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1556799896; bh=zXc+MLxpdfMXt3BBtu+ypudwyvxvz7GNh+YWMhJlJPE=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=fpvVWZYGEMMJQ4eaiJsQcvINo+EEBYO/z+h1JY2PuMg+kjWvcR8H3KsEDZzolYojY b/3Qx5v3dqguBfF1aYihhG6rNh8PF7nxc96Hn+sRp7sP9t+4prcPFbl9Oz+ibvOXIB GGo97P3fys48Faxe6/0e9uhFgWyamBqaXoM/Yz74= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from detlef.gmx.de ([212.86.60.150]) by mail.gmx.com (mrgmx101 [212.227.17.168]) with ESMTPSA (Nemesis) id 0LhSfM-1h01Em2oWu-00mard; Thu, 02 May 2019 14:24:56 +0200 In-Reply-To: (Zhang Haijun's message of "Wed, 1 May 2019 02:17:32 +0000") X-Provags-ID: V03:K1:C/d/3J/NglRNQui0+JYodO5fuwbDjBditKroFgjXPRubzwJNdfz x86tC+1FD0UXi9ZP7+FLgOyIIo6/Ln9XaB46R4nLRPIBy0yq6sYXNOgI/v/RKW8xXq9vFPz GS1O5lBvRgfo3bIcp277TZMf0qfPFiJUfB/uN7s8qax5xx3lF/Wi8Hn/vJ2ZCpt/CDmTAoC xxzsH2q1DFo9sKmSzFwNg== X-UI-Out-Filterresults: notjunk:1;V03:K0:9mMeVprCd8M=:55tfQ9zvuwV9TbhkIpZOV+ mgClcla7U3zxy1+M9YmnLY3UVO5inZ2fH90BG4y6Cxr4BYF9Ic81Geo0RJcOoJejrnoCVJtJ/ rOBaCXncXRsnE5tZCWg0jXNxPTUP5gOMFY0TIoj0rHZSnkMEwlgBqEend2wzJC6TFV3mFZzE0 OV5M9A0C88x2zzAteSF8nRDrM20os2hVNDxdIdUzjkVxFfFaNZRdD1k+rk972Y24MF64JSZVe BDfsSj0ISPCmYIlefE8PGum5C4h9FKFcnDvQCziG+eBG2rnF5ZDfnNyi9iUc4xMgFhiMFvMrf IRQnTp1qmkmrSWJSNPG3c+m9OrTzdFPltbU6ZZspQBAGvJdtEwYxZ7zgM/fxCIvkwxSe8NUh4 iY491NUl4sHYvahUmucyDo8jURgusmKbZDs8d9ixRbLBib5YHquWsQP9je4fA36TBBby69Hen YKpvrDMvl68ww8aN4vs+rQF7AbOJ+Svd401Ir8LdnqJlD9+GGNmIBZVHlVFTRGkliZ2Kse/5U yeyx4KMkYx7VoKIv16cCjNR0UY+U6U45tFdJruTPnLz7AHxhTf0uQ5QCnS9rn2OqiySlXvTv5 9mO3o7ETLGF6iGi2R5Go+/Uo/mOl6VoQMw5MXrp7W2Y1HDeGJFcPVvmWOzjSOZD4jip5o64ZP rL+8lZ2kwlYkUW07YX98hWhPoVRzdxe7b/LwTOH7LuEyZaA341NHeucb8bbXLImWwBv21pr/+ +PhAF35V/nsfgyXfaH240YQIqJGUDrhQP4RL0rIfuI58dA1BU8JyvYPJmrTREE5jn2ehArM2 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158630 Archived-At: Zhang Haijun writes: >> I don't understand the patch. Symbol kqueue11 does not exist, so do you= mean >> >> + func dir > Yes. > >> >> And have you applied the tests in filenotify-tests.el? Do all of them p= ass? >> >> Best regards, Michael. > > $ make -C test autorevert-tests > ELC lisp/autorevert-tests.elc > GEN lisp/autorevert-tests.log > Running 5 tests (2019-05-01 10:06:38+0800) > Reverting buffer `auto-revert-testqe4qed'. > passed 1/5 auto-revert-test00-auto-revert-mode > (Shell command succeeded with no output) > Test auto-revert-test01-auto-revert-several-files backtrace: > signal(ert-test-failed (((should (string-match "another text" (buffe So this shows you cannot change filenotify.el as proposed. Best regards, Michael.