From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#29854: 25.3; Eshell buffer editing gets slower as colored output grows Date: Sat, 04 May 2019 15:49:19 -0400 Message-ID: <87sgtum24g.fsf@gmail.com> References: <87vagt6a7d.fsf@gmail.com> <87mv1ytjpg.fsf@users.sourceforge.net> <87r2r8s72c.fsf@users.sourceforge.net> <87tvw3cgh9.fsf@gmail.com> <87incjrrr2.fsf@users.sourceforge.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="254342"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: 29854@debbugs.gnu.org, Pierre Neidhardt To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat May 04 21:50:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hN0fi-0013zj-Qb for geb-bug-gnu-emacs@m.gmane.org; Sat, 04 May 2019 21:50:10 +0200 Original-Received: from localhost ([127.0.0.1]:60425 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hN0fh-0002tf-Nk for geb-bug-gnu-emacs@m.gmane.org; Sat, 04 May 2019 15:50:09 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57872) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hN0fb-0002tI-Gm for bug-gnu-emacs@gnu.org; Sat, 04 May 2019 15:50:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hN0fa-0007PE-BJ for bug-gnu-emacs@gnu.org; Sat, 04 May 2019 15:50:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38817) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hN0fa-0007P8-7U for bug-gnu-emacs@gnu.org; Sat, 04 May 2019 15:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hN0fa-0000wh-0n for bug-gnu-emacs@gnu.org; Sat, 04 May 2019 15:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 May 2019 19:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29854 X-GNU-PR-Package: emacs Original-Received: via spool by 29854-submit@debbugs.gnu.org id=B29854.15569993693574 (code B ref 29854); Sat, 04 May 2019 19:50:01 +0000 Original-Received: (at 29854) by debbugs.gnu.org; 4 May 2019 19:49:29 +0000 Original-Received: from localhost ([127.0.0.1]:52360 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hN0f3-0000vV-Bz for submit@debbugs.gnu.org; Sat, 04 May 2019 15:49:29 -0400 Original-Received: from mail-qt1-f195.google.com ([209.85.160.195]:43891) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hN0f1-0000vA-HO; Sat, 04 May 2019 15:49:28 -0400 Original-Received: by mail-qt1-f195.google.com with SMTP id r3so672911qtp.10; Sat, 04 May 2019 12:49:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=TUhgPmV6FsWRylyh0H5eJ1yfg5eARM480EGwQYLSzHM=; b=NQSY8IBPhWHpIV4rajxmgA4VnGQGnIQB/LFo8sTo2RSvXSPSP7OyDRlOKclmqi45IW mOsd8uXLkDq+v/fpD4ONTMHThZqhE534mA7vr9IxQ6gdlZJBLa+Ajl/QeJVEGeDGtoxQ YBwSQBd45bIQAmpGxUZLVWB5RDShk4ZQNNxjTQf/IisCwRWIT7sqpktowAbyn2hw3xzX +cyuLQWOi5dEaxUW4MadtSi3NGWMG/ivHqCBYf1U1elLK0HHudCVF+PTts0U5mTQqaJ6 045BYZmbyjUiMkUu8WlxYXbO60VesOlUBzc8pZzy+HcmZ/gk4ZnVwfUqBVSfQPXc/3YB WnXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=TUhgPmV6FsWRylyh0H5eJ1yfg5eARM480EGwQYLSzHM=; b=oD0sHdpfsIMBDOnFSNB1KA2GKjNgPFpAq4bfko9Vjcb0DZthVajBXhvObdgJnUlHYL eHI8erzoFJ18OJfIS6yhR+JP4TwMqYUPgoFfJ6HyiZwyX6N9fJQ39e1NAl1qech2KFYz fy6kfyyyLKxCxZYelg+oVg8bsLsOtwocvM3zUJmLIKaAvqPHpAb8rkZ6DUxkisC/eMse rvzrygJyOpDx+U+71jSW8eligz4G6D89MPmNJ36RtYrU9QdMWalDu8Rdg3xdWO0i+/DC I7wMV4rKo6QiKfks46KWma7Mna1qb79myTB6Z2HRIWHergIKN2DiVE9ZbeDSef3s/Ar1 y38w== X-Gm-Message-State: APjAAAXF7MZNFZM3CkoaeBQ0oVcqhXC9JRg1UT25RPxvaRxEwGSforGg PlKcZ6L/3+KbAG+IZADunJXmj5pn X-Google-Smtp-Source: APXvYqzJjuH7Es6ZM7X7b7WyPkyKH1NTnaXLdqrLk8yWnE/77tmnJur7ArWT9ubNog0JceNz9SkywQ== X-Received: by 2002:a0c:9922:: with SMTP id h31mr14036919qvd.137.1556999361688; Sat, 04 May 2019 12:49:21 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id n66sm3429413qkc.36.2019.05.04.12.49.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 04 May 2019 12:49:20 -0700 (PDT) In-Reply-To: <87incjrrr2.fsf@users.sourceforge.net> (Noam Postavsky's message of "Wed, 03 Jan 2018 08:33:53 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158760 Archived-At: tags 29854 fixed close 29854 27.1 quit Noam Postavsky writes: > Pierre Neidhardt writes: > >>> The question is then whether there is some case where using overlays is >>> necessary, or is it just a pessimization? For reference, I took the >>> text property using definition from man.el (so it at least works for >>> that case): >> >> Any idea what the original intent was? >> I can't seem to see why an overlay would be needed for Eshell's output. > > Hard to say. It might just be a case of going with ansi-color.el's > default. ansi-color-apply-on-region was changed to use overlays in [1: > 0e3c1e3ea6], but it's unclear why. The commit message just says > > (ansi-color-apply-on-region): Use extents or overlays instead of > text-properties. I've changed to use text properties (but font-lock-face rather than face) in master. We'll see if it causes trouble. 4fd9048e94 2019-05-04T15:33:20-04:00 "Avoid slow overlay ansi coloring in eshell (Bug#29854)" https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=4fd9048e940d38364caf4abe9b209f9288c78544