From: Noam Postavsky <npostavs@gmail.com>
To: Noam Postavsky <npostavs@users.sourceforge.net>
Cc: 29854@debbugs.gnu.org, Pierre Neidhardt <ambrevar@gmail.com>
Subject: bug#29854: 25.3; Eshell buffer editing gets slower as colored output grows
Date: Sat, 04 May 2019 15:49:19 -0400 [thread overview]
Message-ID: <87sgtum24g.fsf@gmail.com> (raw)
In-Reply-To: <87incjrrr2.fsf@users.sourceforge.net> (Noam Postavsky's message of "Wed, 03 Jan 2018 08:33:53 -0500")
tags 29854 fixed
close 29854 27.1
quit
Noam Postavsky <npostavs@users.sourceforge.net> writes:
> Pierre Neidhardt <ambrevar@gmail.com> writes:
>
>>> The question is then whether there is some case where using overlays is
>>> necessary, or is it just a pessimization? For reference, I took the
>>> text property using definition from man.el (so it at least works for
>>> that case):
>>
>> Any idea what the original intent was?
>> I can't seem to see why an overlay would be needed for Eshell's output.
>
> Hard to say. It might just be a case of going with ansi-color.el's
> default. ansi-color-apply-on-region was changed to use overlays in [1:
> 0e3c1e3ea6], but it's unclear why. The commit message just says
>
> (ansi-color-apply-on-region): Use extents or overlays instead of
> text-properties.
I've changed to use text properties (but font-lock-face rather than
face) in master. We'll see if it causes trouble.
4fd9048e94 2019-05-04T15:33:20-04:00 "Avoid slow overlay ansi coloring in eshell (Bug#29854)"
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=4fd9048e940d38364caf4abe9b209f9288c78544
prev parent reply other threads:[~2019-05-04 19:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-26 10:43 bug#29854: 25.3; Eshell buffer editing gets slower as colored output grows Pierre Neidhardt
2018-01-01 2:07 ` Noam Postavsky
2018-01-02 12:40 ` Pierre Neidhardt
2018-01-02 13:50 ` Noam Postavsky
2018-01-03 11:46 ` Pierre Neidhardt
2018-01-03 13:33 ` Noam Postavsky
2019-05-04 19:49 ` Noam Postavsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sgtum24g.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=29854@debbugs.gnu.org \
--cc=ambrevar@gmail.com \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.