From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#35624: log-view-diff regression Date: Sun, 12 May 2019 22:15:20 +0300 Organization: LINKOV.NET Message-ID: <87sgtjzmz5.fsf@mail.linkov.net> References: <87pnou2ak2.fsf@mail.linkov.net> <83imuliiwd.fsf@gnu.org> <875zqkraf1.fsf@mail.linkov.net> <83pnoqg31v.fsf@gnu.org> <87zhnsaf1j.fsf@mail.linkov.net> <837eawcsb7.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="212317"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 35624@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 12 21:29:21 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hPu9w-000t01-OI for geb-bug-gnu-emacs@m.gmane.org; Sun, 12 May 2019 21:29:21 +0200 Original-Received: from localhost ([127.0.0.1]:46528 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hPu9q-000357-BX for geb-bug-gnu-emacs@m.gmane.org; Sun, 12 May 2019 15:29:14 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39950) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hPu9g-00033d-3G for bug-gnu-emacs@gnu.org; Sun, 12 May 2019 15:29:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hPu9f-0004fI-7O for bug-gnu-emacs@gnu.org; Sun, 12 May 2019 15:29:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58048) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hPu9f-0004ew-48 for bug-gnu-emacs@gnu.org; Sun, 12 May 2019 15:29:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hPu9e-0001jJ-Vj for bug-gnu-emacs@gnu.org; Sun, 12 May 2019 15:29:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 May 2019 19:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35624 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35624-submit@debbugs.gnu.org id=B35624.15576892906558 (code B ref 35624); Sun, 12 May 2019 19:29:02 +0000 Original-Received: (at 35624) by debbugs.gnu.org; 12 May 2019 19:28:10 +0000 Original-Received: from localhost ([127.0.0.1]:43352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPu8o-0001hh-Gn for submit@debbugs.gnu.org; Sun, 12 May 2019 15:28:10 -0400 Original-Received: from goldenrod.birch.relay.mailchannels.net ([23.83.209.74]:43246) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPu8m-0001hZ-Cs for 35624@debbugs.gnu.org; Sun, 12 May 2019 15:28:08 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 688FC5C5B67; Sun, 12 May 2019 19:28:07 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a64.g.dreamhost.com (unknown [100.96.11.48]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 2CCFB5C5B5F; Sun, 12 May 2019 19:28:07 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a64.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Sun, 12 May 2019 19:28:07 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Bored-Supply: 43de624775a9a48f_1557689287262_4165475279 X-MC-Loop-Signature: 1557689287262:2005476987 X-MC-Ingress-Time: 1557689287262 Original-Received: from pdx1-sub0-mail-a64.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a64.g.dreamhost.com (Postfix) with ESMTP id E90188050F; Sun, 12 May 2019 12:28:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=4HlJcipEvTxAJ8Pm6lnPXglL7CM=; b= vfP4hLA8V34I3IYSwaNn0piGfn0RqItsC1D1bYssLgz+4ZRQs+Mki+ADiQi1WUqj 0iGTcqSInzzsnwq4vFeTLEHKQfk47G9ehOg1DdG6lfYpSEjS8KNu6Ttwlqjf2720 0T3uh8ADe+nGLN+lmcjjaIV5IIkbbdx18/4f/F6uhDA= Original-Received: from mail.jurta.org (m91-129-96-230.cust.tele2.ee [91.129.96.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a64.g.dreamhost.com (Postfix) with ESMTPSA id 4382E80502; Sun, 12 May 2019 12:28:04 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a64 In-Reply-To: <837eawcsb7.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 12 May 2019 05:36:28 +0300") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduuddrledvgddugedtucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrdeliedrvdeftdenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrdeliedrvdeftddprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegvlhhiiiesghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpedu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159151 Archived-At: >> >> 1. the case when region's beginning (b) and region's end (e) >> > >> > What does "e" signify in these examples? >> >> "e" signifies the end of the region. > > I asked a detailed question, but your answer doesn't make me wiser > about what "e" means. Could you please humor me with a more detailed > answer? Let me describe how log-view-diff was supposed to work since its introduction ~20 years ago until its behavior was changed accidentally one and half year ago: when the user puts the beginning of the region on the line with one revision, and the end of the region on the line with another revision, the function 'log-view-diff-common' extracts the 'from' revision from the line with the first revision, and the 'to' revision from the line with the second revision. bug#28466 tried to improve the logic when the end of the region is at the end of the buffer, but mistakenly broke long-established behavior, so currently 'from' falls thru to its previous revision.