From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?=C3=93scar_Fuentes?= Newsgroups: gmane.emacs.devel Subject: Re: send new reply from gnus hangs Date: Fri, 14 Jun 2019 15:42:44 +0200 Message-ID: <87sgscqo4r.fsf@telefonica.net> References: <87r285nhxb.fsf@telefonica.net> <87k1duml43.fsf@telefonica.net> <87sgsiwehh.fsf@telefonica.net> <87k1du744k.fsf@telefonica.net> <87h88y8ibl.fsf@telefonica.net> <878suas5wv.fsf@telefonica.net> <87d0jmuyrj.fsf@telefonica.net> <87imtetju1.fsf@telefonica.net> <87sgscgab4.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="251638"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jun 14 15:58:10 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hbmiY-0013Kq-3R for ged-emacs-devel@m.gmane.org; Fri, 14 Jun 2019 15:58:10 +0200 Original-Received: from localhost ([::1]:51774 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbmiX-0006RZ-09 for ged-emacs-devel@m.gmane.org; Fri, 14 Jun 2019 09:58:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47285) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbmTy-0002YT-88 for emacs-devel@gnu.org; Fri, 14 Jun 2019 09:43:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hbmTw-0007bA-CI for emacs-devel@gnu.org; Fri, 14 Jun 2019 09:43:05 -0400 Original-Received: from [195.159.176.226] (port=46454 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hbmTu-0007RF-DP for emacs-devel@gnu.org; Fri, 14 Jun 2019 09:43:04 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1hbmTo-000igv-OW for emacs-devel@gnu.org; Fri, 14 Jun 2019 15:42:56 +0200 X-Injected-Via-Gmane: http://gmane.org/ Cancel-Lock: sha1:NR0LbeMVb9+vZPs708QViJifu0M= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237610 Archived-At: Eric Abrahamsen writes: > Okay, that worked! > > What does everyone think of the attached diff? It moves the > `message-check' call out of the internal function (that seems like work > that should be done by the caller, not the internal function, and helps > the call fit in visually), and either returns nil or errors depending on > an optional arg. I have no time now to review the code (and I'm not familiar with Gnus' code base) but I was going to propose reverting the problematic commit. If your patch solves the problem, great. If there are doubts, the right thing is reverting. There is no justification for having master in an unusable state (if you are a Gnus user) for more than a week due to a cosmetic change like this.