From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alex Branham Newsgroups: gmane.emacs.bugs Subject: bug#36212: [PATCH] make undo less enthusiastic Date: Fri, 14 Jun 2019 13:21:11 -0500 Message-ID: <87sgscqb8o.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="173458"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: mu4e 1.2.0; emacs 27.0.50 To: 36212@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 14 21:08:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hbrYW-000iti-H6 for geb-bug-gnu-emacs@m.gmane.org; Fri, 14 Jun 2019 21:08:08 +0200 Original-Received: from localhost ([::1]:54458 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbrYV-0004dL-GS for geb-bug-gnu-emacs@m.gmane.org; Fri, 14 Jun 2019 15:08:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51415) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbqpv-0003v0-4V for bug-gnu-emacs@gnu.org; Fri, 14 Jun 2019 14:22:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hbqpu-0003hu-2Z for bug-gnu-emacs@gnu.org; Fri, 14 Jun 2019 14:22:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52458) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hbqpt-0003hf-Tu for bug-gnu-emacs@gnu.org; Fri, 14 Jun 2019 14:22:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hbqpt-0005Ue-Ns for bug-gnu-emacs@gnu.org; Fri, 14 Jun 2019 14:22:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alex Branham Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Jun 2019 18:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 36212 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.156053648021054 (code B ref -1); Fri, 14 Jun 2019 18:22:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 14 Jun 2019 18:21:20 +0000 Original-Received: from localhost ([127.0.0.1]:37769 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hbqpE-0005TW-Kx for submit@debbugs.gnu.org; Fri, 14 Jun 2019 14:21:20 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:39509) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hbqpC-0005TL-IO for submit@debbugs.gnu.org; Fri, 14 Jun 2019 14:21:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51135) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbqpB-0003SQ-BF for bug-gnu-emacs@gnu.org; Fri, 14 Jun 2019 14:21:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hbqp9-0002rc-7g for bug-gnu-emacs@gnu.org; Fri, 14 Jun 2019 14:21:16 -0400 Original-Received: from mail-ot1-x332.google.com ([2607:f8b0:4864:20::332]:35244) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hbqp9-0002ql-0o for bug-gnu-emacs@gnu.org; Fri, 14 Jun 2019 14:21:15 -0400 Original-Received: by mail-ot1-x332.google.com with SMTP id j19so3545240otq.2 for ; Fri, 14 Jun 2019 11:21:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=user-agent:from:to:subject:date:message-id:mime-version; bh=xeZQLkQcaYXcexH6f9GsrAxISmE5EzDzemwMcorwAz4=; b=giKJb/feLTOxLhMhHDMhKPsc/s0nePc5o/fTl2HxlIco8b48LPdHN9mk6SVq4Y8EF+ 6k64e6sSKMQx3CQxh7gZ+eXo5iLHUB4kKYvI6MStA8fHqKBZ0+h0QfBfGjuziM9IYYvW amLheB7x9NOkY8Iw2vOhbdVnANItJm4hKaxtrv6e9AYvpynxA13Vtb43l8aW2zMlS3cW jiNHsjPYehho59Avb27t1eFJGfYzB6FzDwILRNJUxaTgtgbp8J9NbycKTadIdbEJq9h/ FTSu0RhMOXfflrWDizeGo14zv3Qoof3FQcij1i/OwBx/swFy24/1U7chdG2G802extF5 iuHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:user-agent:from:to:subject:date:message-id :mime-version; bh=xeZQLkQcaYXcexH6f9GsrAxISmE5EzDzemwMcorwAz4=; b=f3WsrS33EHzDXS8KWxYxB+Jl7LHFALT27YQ7i43A6FPWmfAd5FfkbiuA2AyDCjbodZ Yb5sSHndIzsKSe+B7B2b0wbwV4WObHk9eu5RaQmtCaNj41u8+1hqx1GXlNZHvEJfQTXq pIbdK0ux6M4haAqV73OXMRVEaOsbESttNTr/7B5idtHzRgjkt10cemY0u/8PBVPzgZCh f6v12S4dMu6eneUFpVjZUQ+cI0V7HDZsRLEzJtdtT0LXHrPBPFtVXqVo1kRrCULZZRbj kuqbrSgj2XN24fCbu1LwTKHnieyhCv9gxVr0g3idlaaS5gRPgGewIKedL+oqnGmF4gRv w3JA== X-Gm-Message-State: APjAAAUqjd3I7CFM1IfV6cgWsh6W5FCPLQZydk+6Ga0uX71miOgaMBot 9mYBc6JfA8mTA4pH24z7u9kMC8MQ X-Google-Smtp-Source: APXvYqwmW++B9tEdv4WMiU6teP79DweA91c8afEJmTLcgJkw/J9V8lxlmv0Ps9u9D2M9VRNgAJSarg== X-Received: by 2002:a9d:1426:: with SMTP id h35mr42345974oth.55.1560536473778; Fri, 14 Jun 2019 11:21:13 -0700 (PDT) Original-Received: from mars (cpe-70-114-192-208.austin.res.rr.com. [70.114.192.208]) by smtp.gmail.com with ESMTPSA id f5sm1408609otl.51.2019.06.14.11.21.12 for (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 14 Jun 2019 11:21:13 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160569 Archived-At: --=-=-= Content-Type: text/plain This is really minor, but I find it annoying that undo is so enthusiastic in its messaging. This patch removes the exclamation mark, which makes undo's messaging more similar to other functions messaging (e.g. C-g, C-SPC, etc). Alex --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-lisp-simple.el-undo-Make-message-less-enthusiastic.patch >From 5165b92810a29ea409b0dd92179b3599112e1f4e Mon Sep 17 00:00:00 2001 From: Alex Branham Date: Fri, 14 Jun 2019 10:00:29 -0500 Subject: [PATCH] * lisp/simple.el (undo): Make message less enthusiastic --- lisp/simple.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/simple.el b/lisp/simple.el index 5e9d13f9f8..d9f310b203 100644 --- a/lisp/simple.el +++ b/lisp/simple.el @@ -2530,7 +2530,7 @@ undo ;; so, ask the user whether she wants to skip the redo/undo pair. (let ((equiv (gethash pending-undo-list undo-equiv-table))) (or (eq (selected-window) (minibuffer-window)) - (setq message (format "%s%s!" + (setq message (format "%s%s" (if (or undo-no-redo (not equiv)) "Undo" "Redo") (if undo-in-region " in region" "")))) -- 2.21.0 --=-=-=--