Andy Moreton <andrewjmoreton@gmail.com> writes:

> On Mon 10 Jun 2019, Óscar Fuentes wrote:
>
>> Confirmed, reverting that commit fixes the problem.
>>
>>> Óscar Fuentes <ofv@wanadoo.es> writes:
>>>
>>> The problematic commit is
>>>
>>> master e51adfbdb7587c2b0b5ba154be210b30db82b4ea
>>> Author:     Oleh Krehel <ohwoeowho@gmail.com>
>>> AuthorDate: Thu Jun 6 16:01:10 2019 +0200
>>> Commit:     Oleh Krehel <ohwoeowho@gmail.com>
>>> CommitDate: Thu Jun 6 16:01:10 2019 +0200
>
> Thanks Óscar, that appears to be the problem.
>
> Looking at that commit, one call site calls `error' to abort sending the
> message, so the return value does not matter, but the other uses
> do-posting to set the return value from the `check-message' form, which
> is used by its caller.
>
>     AndyM

Okay, that worked!

What does everyone think of the attached diff? It moves the
`message-check' call out of the internal function (that seems like work
that should be done by the caller, not the internal function, and helps
the call fit in visually), and either returns nil or errors depending on
an optional arg.

E