From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: Proposed changes to gnus-notifications.el Date: Sun, 21 Jul 2019 19:16:25 +0200 Message-ID: <87sgqzi9zq.fsf@gmx.de> References: <87y30s5hv4.fsf@tcd.ie> <87blxnke8f.fsf@gmx.de> <87wogbraj0.fsf@tcd.ie> <87wogbisby.fsf@gmx.de> <87imrvjsct.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="261161"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Julien Danjou , Lars Ingebrigtsen , emacs-devel@gnu.org To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jul 21 19:16:48 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hpFS3-0015nj-7e for ged-emacs-devel@m.gmane.org; Sun, 21 Jul 2019 19:16:47 +0200 Original-Received: from localhost ([::1]:56980 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpFS2-0006Jf-1K for ged-emacs-devel@m.gmane.org; Sun, 21 Jul 2019 13:16:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46697) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpFRu-0006JM-G1 for emacs-devel@gnu.org; Sun, 21 Jul 2019 13:16:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hpFRt-00031V-K8 for emacs-devel@gnu.org; Sun, 21 Jul 2019 13:16:38 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:45887) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hpFRt-00030w-5X for emacs-devel@gnu.org; Sun, 21 Jul 2019 13:16:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1563729388; bh=Er+9ZWL+CsQ4MCnKM6ESFbFRvHe4o14cuMyg0MQMxpM=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=fMeQlIiTbDkYEVoq0FJgvZwPBvD9MENihGYI9OYgPu4yofllxP/t8se/e73zk3/ik mMPJSiqopO9QBxwrXrN/ABapB/42gdCX1wVBSSFRKcPgHV3lJKIiRj10RCKmac+IbI M8x1ac/eUsyEiJiiummYQJUyZ0FUx/rBl4bBh3d8= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from detlef.gmx.de ([212.91.238.185]) by mail.gmx.com (mrgmx001 [212.227.17.190]) with ESMTPSA (Nemesis) id 0Le64S-1iCDFw25FM-00punU; Sun, 21 Jul 2019 19:16:28 +0200 In-Reply-To: <87imrvjsct.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sun, 21 Jul 2019 16:54:26 +0100") X-Provags-ID: V03:K1:Eapxp5SGKXrO5TSmga+kSayNYZwTWVdCysBT9/Ntn7Oc0siGvHk ckiBxKuud1XxnzImqlt0u1JJO56RoxPAGfifHnsOZgah5ACTHEhZfzBm3iXtfUnM948Ex87 r9QoVb3Rwm2XDK6i7AFrJwjLulaz3s2DwPQtm+9r65oyAwUFpsnDWIGY7udzSpfw9CjDp+a Z2tBpiYyl1OvMtgK6/hNg== X-UI-Out-Filterresults: notjunk:1;V03:K0:tOHYEEcBA9I=:eBn7xb2kg42QG2Bdm0zV63 Y4O4oCznJLDc1T/uIGl2smJKT1SBvH1NAowC18K9T2l6GbZV136Uc+MMRBvCKqKF++uwJa589 mXVluxCZuMSHvYSzxqPlzrZql3teF/M9GwFMQS6pt0xilbq+MJXg/kwQiZyoyYd/xGNKQSWBy zz5emVVckWs6CIJ4yELtqtNBWly05N0kWqdA8oXjiePx1hGuRYb4PxjGdT94AYUcd2GDcCVS6 Ijz/v1gikoQ0eFHFHn1ev0nxz5CggdXDLaZM/1RpQW6mTm8Q4IzMwlvQeQSPMt4eDe23amgzD m3wDFs+Irq8XT4hD1tGcYrCdTEQj7388nvpih6YfJSUSarHiQ3OjddcK+KYxMe3pAU02t8nWb 6guS4FGfo/pwy5QTUamfNnI5hvKQGoHD6ASJNNKatW8aWO0j9UJ1Id8ATUymlGZfH8Jr53eO9 TQXj4XKcf+ahSSw/VB+7JBkm2Bje5ESM81/BPGI1Zqmsqox7sogMs7UGdKI+QLDkegtlZ0Qf8 fR0Z++5a6thJzdj+vBnY+N8q6zXU8Jfozo83gVIXYARCwDyiW9TxEfuSBpquCAQNUxISOD5YN VChvMKKSDNxum2QYZy0a0JsdPuQp6JO2jExdJnNMoWnG+U7u4fDLotBYD5BCdYEV5siOON1C7 ooLkFkDNLqEzrRTwDHugJNTEwk6EAjB3HZ57ELnjulwBLK+477mCe4pRAVjv3IeWqz1pDLgh/ AQK34qNzIRmYJeXEoNicSQteNrF8904mc1unBIPDRRaLkGzGpuIZNqmBnYquyu71TDMA++lx X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.15.15 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238772 Archived-At: "Basil L. Contovounesios" writes: > In that case I think the proposed patch already behaves as it should, > without changing existing behaviour. See the last few lines of the > function gnus-notifications: > > (let* ((photo-file (gnus-notifications-get-photo-file address)) > (notification-id (gnus-notifications-notify > (or (car address-components) address) > (mail-fetch-field "Subject") > photo-file))) > (when notification-id > ;; Register that we did notify this message. > (push article (cdr group-notifications)) > ;; Register the notification ID for later actions. > (setf (alist-get notification-id > gnus-notifications-id-to-msg) > (list group article))) > ...) > > gnus-notifications-notify just calls notifications-notify, and the > resulting ID is not assumed to be non-nil. Is this acceptable? Or did > you mean something else when you said the patch assumes too much about > notifications-notify? Likely, it's ok (I didn't test on non GNU/Linux). Maybe we shall say, that this works only for GNU/Linux systems with compiled D-Bus support. > Thanks, Best regards, Michael.