From: Michael Albinus <michael.albinus@gmx.de>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: Julien Danjou <julien@danjou.info>,
Lars Ingebrigtsen <larsi@gnus.org>,
emacs-devel@gnu.org
Subject: Re: Proposed changes to gnus-notifications.el
Date: Sun, 21 Jul 2019 19:16:25 +0200 [thread overview]
Message-ID: <87sgqzi9zq.fsf@gmx.de> (raw)
In-Reply-To: <87imrvjsct.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sun, 21 Jul 2019 16:54:26 +0100")
"Basil L. Contovounesios" <contovob@tcd.ie> writes:
> In that case I think the proposed patch already behaves as it should,
> without changing existing behaviour. See the last few lines of the
> function gnus-notifications:
>
> (let* ((photo-file (gnus-notifications-get-photo-file address))
> (notification-id (gnus-notifications-notify
> (or (car address-components) address)
> (mail-fetch-field "Subject")
> photo-file)))
> (when notification-id
> ;; Register that we did notify this message.
> (push article (cdr group-notifications))
> ;; Register the notification ID for later actions.
> (setf (alist-get notification-id
> gnus-notifications-id-to-msg)
> (list group article)))
> ...)
>
> gnus-notifications-notify just calls notifications-notify, and the
> resulting ID is not assumed to be non-nil. Is this acceptable? Or did
> you mean something else when you said the patch assumes too much about
> notifications-notify?
Likely, it's ok (I didn't test on non GNU/Linux). Maybe we shall say,
that this works only for GNU/Linux systems with compiled D-Bus support.
> Thanks,
Best regards, Michael.
next prev parent reply other threads:[~2019-07-21 17:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-21 0:52 Proposed changes to gnus-notifications.el Basil L. Contovounesios
2019-07-21 8:01 ` Michael Albinus
2019-07-21 9:40 ` Basil L. Contovounesios
2019-07-21 10:40 ` Michael Albinus
2019-07-21 15:54 ` Basil L. Contovounesios
2019-07-21 17:16 ` Michael Albinus [this message]
2019-07-21 15:55 ` Error handling in notifications-notify (was: Proposed changes to gnus-notifications.el) Basil L. Contovounesios
2019-07-21 17:21 ` Error handling in notifications-notify Michael Albinus
2019-07-21 14:34 ` Proposed changes to gnus-notifications.el Eli Zaretskii
2019-07-21 13:44 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sgqzi9zq.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=contovob@tcd.ie \
--cc=emacs-devel@gnu.org \
--cc=julien@danjou.info \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.