From: Lars Ingebrigtsen <larsi@gnus.org>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: Julien Danjou <julien@danjou.info>, emacs-devel@gnu.org
Subject: Re: [PATCH] Improve Gravatar support
Date: Tue, 23 Jul 2019 13:29:08 +0200 [thread overview]
Message-ID: <87sgqx0z23.fsf@mouse.gnus.org> (raw)
In-Reply-To: <87zhl54ucq.fsf@tcd.ie> (Basil L. Contovounesios's message of "Mon, 22 Jul 2019 22:44:53 +0100")
"Basil L. Contovounesios" <contovob@tcd.ie> writes:
>>> - (interactive (list t)) ;; When type `W D g'
>>> + (interactive "p") ;; When type `W D g'
>>
>> Perhaps grammer fix?
>
> I'd rather remove these comments altogether, if that's okay with you.
> The default key bindings are not important here, and it's tautological
> to say that the interactive spec takes effect when the function is
> called as the result of a key binding.
Yes, I agree.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2019-07-23 11:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 13:23 [PATCH] Improve Gravatar support Basil L. Contovounesios
2019-07-22 13:31 ` Lars Ingebrigtsen
2019-07-22 21:44 ` Basil L. Contovounesios
2019-07-23 11:29 ` Lars Ingebrigtsen [this message]
2019-07-22 13:39 ` Andy Moreton
2019-07-22 21:42 ` Basil L. Contovounesios
2019-07-23 2:31 ` Eli Zaretskii
2019-07-23 8:36 ` Basil L. Contovounesios
2019-07-23 8:36 ` Andy Moreton
2019-07-23 9:18 ` Basil L. Contovounesios
2019-08-02 13:45 ` Basil L. Contovounesios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sgqx0z23.fsf@mouse.gnus.org \
--to=larsi@gnus.org \
--cc=contovob@tcd.ie \
--cc=emacs-devel@gnu.org \
--cc=julien@danjou.info \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.