From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master 13fe8a2: Fix rare undefined behaviors in replace-match Date: Sat, 03 Aug 2019 22:07:56 +0200 Message-ID: <87sgqic8rn.fsf@mouse.gnus.org> References: <20190803200033.5628.11021@vcs0.savannah.gnu.org> <20190803200034.9E5F1209B1@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="267525"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Paul Eggert To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Aug 03 22:08:10 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hu0K1-0017S1-MD for ged-emacs-devel@m.gmane.org; Sat, 03 Aug 2019 22:08:09 +0200 Original-Received: from localhost ([::1]:41832 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hu0K0-0003Zf-7T for ged-emacs-devel@m.gmane.org; Sat, 03 Aug 2019 16:08:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43789) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hu0Jw-0003ZK-5t for emacs-devel@gnu.org; Sat, 03 Aug 2019 16:08:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hu0Jv-0005pK-51 for emacs-devel@gnu.org; Sat, 03 Aug 2019 16:08:04 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:47508) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hu0Ju-0005oW-UE for emacs-devel@gnu.org; Sat, 03 Aug 2019 16:08:03 -0400 Original-Received: from 77.18.62.220.tmi.telenormobil.no ([77.18.62.220] helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hu0Jp-0007dN-D1; Sat, 03 Aug 2019 22:07:59 +0200 In-Reply-To: <20190803200034.9E5F1209B1@vcs0.savannah.gnu.org> (Paul Eggert's message of "Sat, 3 Aug 2019 16:00:34 -0400 (EDT)") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.91.231.51 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239157 Archived-At: eggert@cs.ucla.edu (Paul Eggert) writes: > + xsignal2 (Qerror, > + build_string ("replace-match subexpression does not exist"), > + subexp); This is probably a better error to signal here for this error, but it possibly changes the behaviour. If somebody previously had condition-case'd this for args-out-of-range, then they'll get a new error signalled now (which is why I kept that signal)... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no