From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#36861: 27.0.50; display-fill-column-indicator-mode in log-edit-mode Date: Sun, 04 Aug 2019 01:31:59 +0300 Organization: LINKOV.NET Message-ID: <87sgqhricg.fsf@mail.linkov.net> References: <875znjntfe.fsf@mail.linkov.net> <83mugvhr66.fsf@gnu.org> <871ry6rksu.fsf@mail.linkov.net> <83zhksexvx.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="49587"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: spacibba@aol.com, 36861@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 04 00:34:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hu2bJ-000Ciy-WD for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Aug 2019 00:34:10 +0200 Original-Received: from localhost ([::1]:42258 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hu2bI-00069f-DG for geb-bug-gnu-emacs@m.gmane.org; Sat, 03 Aug 2019 18:34:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36631) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hu2bD-00069H-Jj for bug-gnu-emacs@gnu.org; Sat, 03 Aug 2019 18:34:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hu2bC-0000Is-Ix for bug-gnu-emacs@gnu.org; Sat, 03 Aug 2019 18:34:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51354) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hu2bC-0000In-Fo for bug-gnu-emacs@gnu.org; Sat, 03 Aug 2019 18:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hu2bC-0003cJ-9K for bug-gnu-emacs@gnu.org; Sat, 03 Aug 2019 18:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 03 Aug 2019 22:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36861 X-GNU-PR-Package: emacs Original-Received: via spool by 36861-submit@debbugs.gnu.org id=B36861.156487163913894 (code B ref 36861); Sat, 03 Aug 2019 22:34:02 +0000 Original-Received: (at 36861) by debbugs.gnu.org; 3 Aug 2019 22:33:59 +0000 Original-Received: from localhost ([127.0.0.1]:60175 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hu2b9-0003c1-3x for submit@debbugs.gnu.org; Sat, 03 Aug 2019 18:33:59 -0400 Original-Received: from aye.elm.relay.mailchannels.net ([23.83.212.6]:3016) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hu2b7-0003bt-Cg for 36861@debbugs.gnu.org; Sat, 03 Aug 2019 18:33:57 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 5CEB71A1F87; Sat, 3 Aug 2019 22:33:56 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a75.g.dreamhost.com (100-96-29-186.trex.outbound.svc.cluster.local [100.96.29.186]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id CBA971A1ACF; Sat, 3 Aug 2019 22:33:55 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a75.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.5); Sat, 03 Aug 2019 22:33:56 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Obese-Attack: 5f0f2301107c0cb2_1564871636120_3230769541 X-MC-Loop-Signature: 1564871636120:1528766554 X-MC-Ingress-Time: 1564871636119 Original-Received: from pdx1-sub0-mail-a75.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a75.g.dreamhost.com (Postfix) with ESMTP id E57487FED2; Sat, 3 Aug 2019 15:33:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=SvB+l5/LYmHt+CxqlIAVWiM+Y2M=; b= WE/MtEqD5YXTPVfL/MpRIhiRfccbRDICZIAggD+owQ+C2k6YKjCqCtFpE/dXtu3L Q8q6uzUWAYQ9XDClnsAjiH3xqX0iSmZEWDIu8/hnizMlq98dl+neRB32GE2yMDBS imX4InShWcoK/kybmPp5j6BVM2G8PNmKZTJGOmLKR2Q= Original-Received: from mail.jurta.org (m91-129-103-76.cust.tele2.ee [91.129.103.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a75.g.dreamhost.com (Postfix) with ESMTPSA id 7F3B57F0F9; Sat, 3 Aug 2019 15:33:48 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a75 In-Reply-To: <83zhksexvx.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 02 Aug 2019 12:10:10 +0300") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduvddruddtfedgtdekucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdefrdejieenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrddutdefrdejiedprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegvlhhiiiesghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpedt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:164506 Archived-At: >> >> (log-edit-mode . ((log-edit-font-lock-gnu-style . t) >> >> - (log-edit-setup-add-author . t))) >> >> + (log-edit-setup-add-author . t) >> >> + (display-fill-column-indicator-column . 78) >> >> + (eval . (display-fill-column-indicator-mode)))) >> > >> > This will cause an annoying message and prompt when editing Emacs >> > sources with an Emacs which doesn't yet have >> > display-fill-column-indicator-mode, right? Can we avoid that? I >> > routinely need to work on the latest sources with an older Emacs. >> >> Shouldn't local-variables functions ignore undefined variables and commands? >> Probably not, since such change won't help for older versions. > > Right, and we cannot summarily allow any variables a given Emacs > doesn't know about, that'd we unsafe. Actually by using the word "ignore" I meant to not set an unbound variable (currently `hack-local-variables' defines and sets unbound variables). But this is not backward-compatible change. >> Then one way is to put such lines to the init file >> to avoid typing `y' to confirm local variables >> while using emacs-26 to commit emacs-27 changes: > > Rather than requiring users of older Emacsen to change their init > files in such strange ways, which will/might be a problem when they > upgrade to Emacs 27, why not expect users who want the early detection > of long lines to turn on display-fill-column-indicator-mode in their > init files? IOW, the solution that requires changes to one's init > files goes both ways. I don't understand why display-fill-column-indicator customization should be more complicated than necessary? Why it requires adding these lines: (display-fill-column-indicator-column . 78) (eval . (display-fill-column-indicator-mode)) when it should be enough to avoid eval by: (display-fill-column-indicator-column . 78) (display-fill-column-indicator . t) Is it because the only purpose of display-fill-column-indicator-mode is to set display-fill-column-indicator-character? But then why display-fill-column-indicator-character is not nil by default? This contradicts the docstring of display-fill-column-indicator-character that says that the default is U+2502, but actually the default is nil. I'm CC-ing the author of display-fill-column-indicator: Could you please consider setting the default value of display-fill-column-indicator-character? This could simplify customization.