From: Alex Branham <alex.branham@gmail.com>
To: Tadeus Prastowo <tadeus.prastowo@unitn.it>
Cc: 34330@debbugs.gnu.org
Subject: bug#34330: 27.0.50; shell auto-complete cannot handle special characters
Date: Thu, 15 Aug 2019 11:10:54 -0500 [thread overview]
Message-ID: <87sgq2v27l.fsf@gmail.com> (raw)
In-Reply-To: <87zhkav2e4.fsf@gmail.com> (Alex Branham's message of "Thu, 15 Aug 2019 11:06:59 -0500")
[-- Attachment #1: Type: text/plain, Size: 1464 bytes --]
On Thu 15 Aug 2019 at 11:06, Alex Branham <alex.branham@gmail.com> wrote:
> Patch attached.
... and here's the actual patch
From 1af4915f3dc774b4fb53e2b52b1318f4b52b7ba3 Mon Sep 17 00:00:00 2001
From: Alex Branham <alex.branham@gmail.com>
Date: Thu, 15 Aug 2019 11:02:38 -0500
Subject: [PATCH] Fix filename completion in shell mode buffers
* lisp/shell.el (shell-dynamic-complete-functions): Move
pcomplete-completions-at-point down the list so that filename
completion has a chance to complete before pcompletion.
Fixes bug#34330
---
lisp/shell.el | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/lisp/shell.el b/lisp/shell.el
index 2914d1d2c8..889602d26e 100644
--- a/lisp/shell.el
+++ b/lisp/shell.el
@@ -184,14 +184,15 @@ shell buffer. The value may depend on the operating system or shell."
shell-environment-variable-completion
shell-command-completion
shell-c-a-p-replace-by-expanded-directory
- pcomplete-completions-at-point
shell-filename-completion
- comint-filename-completion)
+ comint-filename-completion
+ pcomplete-completions-at-point)
"List of functions called to perform completion.
This variable is used to initialize `comint-dynamic-complete-functions' in the
shell buffer."
:type '(repeat function)
- :group 'shell)
+ :group 'shell
+ :version "27.1")
(defcustom shell-command-regexp "[^;&|\n]+"
"Regexp to match a single command within a pipeline.
--
2.22.0
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-filename-completion-in-shell-mode-buffers.patch --]
[-- Type: text/x-patch, Size: 1337 bytes --]
From 1af4915f3dc774b4fb53e2b52b1318f4b52b7ba3 Mon Sep 17 00:00:00 2001
From: Alex Branham <alex.branham@gmail.com>
Date: Thu, 15 Aug 2019 11:02:38 -0500
Subject: [PATCH] Fix filename completion in shell mode buffers
* lisp/shell.el (shell-dynamic-complete-functions): Move
pcomplete-completions-at-point down the list so that filename
completion has a chance to complete before pcompletion.
Fixes bug#34330
---
lisp/shell.el | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/lisp/shell.el b/lisp/shell.el
index 2914d1d2c8..889602d26e 100644
--- a/lisp/shell.el
+++ b/lisp/shell.el
@@ -184,14 +184,15 @@ shell buffer. The value may depend on the operating system or shell."
shell-environment-variable-completion
shell-command-completion
shell-c-a-p-replace-by-expanded-directory
- pcomplete-completions-at-point
shell-filename-completion
- comint-filename-completion)
+ comint-filename-completion
+ pcomplete-completions-at-point)
"List of functions called to perform completion.
This variable is used to initialize `comint-dynamic-complete-functions' in the
shell buffer."
:type '(repeat function)
- :group 'shell)
+ :group 'shell
+ :version "27.1")
(defcustom shell-command-regexp "[^;&|\n]+"
"Regexp to match a single command within a pipeline.
--
2.22.0
next prev parent reply other threads:[~2019-08-15 16:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-05 12:48 bug#34330: 27.0.50; shell auto-complete cannot handle special characters Tadeus Prastowo
2019-08-15 16:06 ` Alex Branham
2019-08-15 16:10 ` Alex Branham [this message]
2019-08-23 16:02 ` Alex Branham
2019-08-23 16:59 ` Noam Postavsky
2019-08-27 14:52 ` Alex Branham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sgq2v27l.fsf@gmail.com \
--to=alex.branham@gmail.com \
--cc=34330@debbugs.gnu.org \
--cc=tadeus.prastowo@unitn.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.