From: Karl Fogel <kfogel@red-bean.com>
To: Juri Linkov <juri@linkov.net>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: PATCH: isearch-yank-until-char
Date: Thu, 15 Aug 2019 23:53:44 -0500 [thread overview]
Message-ID: <87sgq1r9rb.fsf@red-bean.com> (raw)
In-Reply-To: <87lfvvjxjs.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 14 Aug 2019 23:34:47 +0300")
On 14 Aug 2019, Juri Linkov wrote:
>Globally 'C-M-c' is bound to 'exit-recursive-edit', so the question is
>does anyone want 'C-M-c' to quit isearch and execute 'exit-recursive-edit'?
>I never used 'C-M-c' to quit isearch.
Neither have I.
>One problem is that typing 'C-s C-M-c <SPC>' at the end of the buffer
>raises the error:
>
> Debugger entered--Lisp error: (search-failed " ")
> search-forward(" ")
> isearch-yank-until-char(32)
> funcall-interactively(isearch-yank-until-char 32)
> call-interactively(isearch-yank-until-char nil nil)
> command-execute(isearch-yank-until-char)
>
>and leaves isearch in a broken state. Should your new command
>catch this error?
It could. I'm not sure exacly what to do with the error, though. The new version below displays a brief message and then returns to the isearch prompt:
(defun isearch-yank-until-char (char)
"Pull everything until next instance of CHAR from buffer into search string.
Interactively, prompt for CHAR."
(interactive "cYank until character: ")
(isearch-yank-internal
(lambda () (let ((inhibit-field-text-motion t))
(condition-case nil
(progn
(search-forward (char-to-string char))
(forward-char -1))
(search-failed
(message "`%c' not found" char)
(sit-for 2)))
(point)))))
This feels klugey, but I'm not sure what a better way is. Do you have any ideas?
I also tried raising an error -- i.e., substitute `message' above with `error' and get rid of the `(sit-for 2)' -- but the problem with that is that it *never* returns to the isearch prompt, even though in either case isearch is still active and one could continue adding to the search string.
Best regards,
-Karl
next prev parent reply other threads:[~2019-08-16 4:53 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 3:05 PATCH: isearch-yank-until-char Karl Fogel
2019-08-14 14:20 ` Eli Zaretskii
2019-08-14 16:41 ` Karl Fogel
2019-08-14 16:48 ` Drew Adams
2019-08-14 17:20 ` Eli Zaretskii
2019-08-14 17:22 ` Karl Fogel
2019-08-14 17:51 ` Eli Zaretskii
2019-08-14 17:59 ` Noam Postavsky
2019-08-14 20:39 ` Juri Linkov
2019-08-14 20:34 ` Juri Linkov
2019-08-16 4:53 ` Karl Fogel [this message]
2019-08-16 17:52 ` Juri Linkov
2019-08-25 2:14 ` Karl Fogel
2019-08-25 3:22 ` Drew Adams
2019-08-25 20:03 ` Juri Linkov
2019-08-26 1:14 ` Drew Adams
2019-08-26 5:20 ` Karl Fogel
2019-08-26 14:50 ` Drew Adams
2019-08-26 17:51 ` Karl Fogel
2019-08-26 19:36 ` Drew Adams
2019-08-26 21:29 ` Karl Fogel
2019-08-26 21:57 ` Drew Adams
2019-08-26 22:21 ` Karl Fogel
2019-08-26 22:43 ` Drew Adams
2019-09-04 16:47 ` Karl Fogel
2019-09-04 17:00 ` Eli Zaretskii
2019-09-12 17:44 ` Karl Fogel
2019-09-16 21:24 ` Drew Adams
2019-09-17 16:02 ` Karl Fogel
2019-08-26 21:46 ` Juri Linkov
2019-08-26 21:52 ` Karl Fogel
2019-08-26 22:03 ` Drew Adams
2019-08-26 22:19 ` Juri Linkov
2019-08-26 22:33 ` Karl Fogel
2019-08-26 22:40 ` Drew Adams
2019-08-27 21:31 ` Juri Linkov
2019-08-27 22:52 ` Drew Adams
2019-08-27 23:15 ` Drew Adams
2019-08-25 19:58 ` Juri Linkov
2019-08-14 22:26 ` Stefan Monnier
2019-08-15 18:24 ` Juri Linkov
2019-08-17 12:31 ` Stefan Monnier
2019-08-17 22:51 ` Juri Linkov
2019-08-16 5:11 ` Karl Fogel
[not found] <<87tvakfnv4.fsf@red-bean.com>
[not found] ` <<835zmzsuau.fsf@gnu.org>
2019-08-14 15:24 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sgq1r9rb.fsf@red-bean.com \
--to=kfogel@red-bean.com \
--cc=emacs-devel@gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.