From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: The netsec thread Date: Wed, 04 Sep 2019 15:12:14 +0200 Message-ID: <87sgpcdx3l.fsf@gnus.org> References: <87pnlg7r83.fsf@mouse.gnus.org> <87o90gd1us.fsf@mouse.gnus.org> <9308f549-adf8-e5c1-1bcd-beea2ddb0e0f@cs.ucla.edu> <87r25cb6vy.fsf@gnus.org> <791d5bcb-3684-c791-48f5-c1af765a5c9d@cs.ucla.edu> <87mufxajwq.fsf@gnus.org> <8f52a86a-bc74-47d8-f792-83ce870666fa@cs.ucla.edu> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="11318"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 04 15:29:13 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i5VLV-0002ot-NH for ged-emacs-devel@m.gmane.org; Wed, 04 Sep 2019 15:29:13 +0200 Original-Received: from localhost ([::1]:57944 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i5VLU-0003cK-0y for ged-emacs-devel@m.gmane.org; Wed, 04 Sep 2019 09:29:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57601) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i5V5H-000481-9p for emacs-devel@gnu.org; Wed, 04 Sep 2019 09:12:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i5V5C-0006jl-LU for emacs-devel@gnu.org; Wed, 04 Sep 2019 09:12:25 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:36416) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i5V5B-0006g1-By for emacs-devel@gnu.org; Wed, 04 Sep 2019 09:12:21 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i5V55-0002uR-0J; Wed, 04 Sep 2019 15:12:17 +0200 In-Reply-To: (Robert Pluim's message of "Tue, 03 Sep 2019 22:02:06 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.91.231.51 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239830 Archived-At: Robert Pluim writes: > - (let ((unsafe-renegotiation (not (plist-get status :safe-renegotiation)))) > - (and unsafe-renegotiation > - (format-message > - "safe renegotiation is not supported, connection not protected from impersonators")))) > + (when (string-version-lessp (plist-get status :protocol) "TLS1.3") > + (let ((unsafe-renegotiation (not (plist-get status :safe-renegotiation)))) > + (and unsafe-renegotiation > + (format-message > + "safe renegotiation is not supported, connection not protected from impersonators"))))) After Paul's patch, I think it would make sense to just check for whether :safe-renegotiation is present at all, and not check for protocol version here. I.e., use `plist-member' first. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no