From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#37217: [PATCH] vc-default-ignore implementation is incorrect Date: Sun, 15 Sep 2019 15:06:04 +0200 Message-ID: <87sgoxwvyb.fsf@gnus.org> References: <4b41d328-04ef-8fc3-9b89-6362e83c37a6@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="17166"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 37217@debbugs.gnu.org To: Wolfgang Scherer Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 15 15:07:20 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i9UFM-0004JB-13 for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 Sep 2019 15:07:20 +0200 Original-Received: from localhost ([::1]:54512 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i9UFK-0003Wf-An for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 Sep 2019 09:07:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54864) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i9UF7-0003WQ-E5 for bug-gnu-emacs@gnu.org; Sun, 15 Sep 2019 09:07:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i9UF5-0005LR-Cu for bug-gnu-emacs@gnu.org; Sun, 15 Sep 2019 09:07:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38674) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i9UF3-0005IZ-WA for bug-gnu-emacs@gnu.org; Sun, 15 Sep 2019 09:07:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i9UF3-0004bJ-OS for bug-gnu-emacs@gnu.org; Sun, 15 Sep 2019 09:07:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 15 Sep 2019 13:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37217 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37217-submit@debbugs.gnu.org id=B37217.156855277117603 (code B ref 37217); Sun, 15 Sep 2019 13:07:01 +0000 Original-Received: (at 37217) by debbugs.gnu.org; 15 Sep 2019 13:06:11 +0000 Original-Received: from localhost ([127.0.0.1]:47492 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i9UEF-0004Zr-2E for submit@debbugs.gnu.org; Sun, 15 Sep 2019 09:06:11 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:33198) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i9UEC-0004Zh-0I for 37217@debbugs.gnu.org; Sun, 15 Sep 2019 09:06:08 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i9UE8-0000K5-My; Sun, 15 Sep 2019 15:06:07 +0200 In-Reply-To: <4b41d328-04ef-8fc3-9b89-6362e83c37a6@gmx.de> (Wolfgang Scherer's message of "Thu, 29 Aug 2019 02:53:20 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:166493 Archived-At: Wolfgang Scherer writes: > Only the basename of FILE is written to the ignore file. This is > wrong for all filenames relative to project root with one ore > more parent directories. > > The remove option is also implemented incorrectly. [...] > A unit test showed, that the removal regexp was faulty. New version of > patch attached. Thanks; I've only lightly tested this, but if I read the code correctly, I think it makes sense, so I've now applied it to Emacs 27. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no