From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Sven Joachim Newsgroups: gmane.emacs.devel Subject: Re: master f198a5c: Revert "emacsclient: ignore --eval parameters when starting alternate editor" Date: Sun, 15 Sep 2019 18:17:31 +0200 Message-ID: <87sgoxlejo.fsf@turtle.gmx.de> References: <20190915121331.17901.64590@vcs0.savannah.gnu.org> <20190915121332.E09E720BC2@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="258674"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: Lars Ingebrigtsen , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Sep 15 18:20:01 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i9XFo-00151B-Hx for ged-emacs-devel@m.gmane.org; Sun, 15 Sep 2019 18:20:00 +0200 Original-Received: from localhost ([::1]:56002 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i9XFn-0006Lm-5t for ged-emacs-devel@m.gmane.org; Sun, 15 Sep 2019 12:19:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52060) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i9XDX-0006Lg-Ou for emacs-devel@gnu.org; Sun, 15 Sep 2019 12:17:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i9XDW-0008IL-GX for emacs-devel@gnu.org; Sun, 15 Sep 2019 12:17:39 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:55835) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i9XDW-0008GV-4t for emacs-devel@gnu.org; Sun, 15 Sep 2019 12:17:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1568564255; bh=Xw12gYyY5bMkf5Wu8g1KgsIuXEEEmEQKPSH7W8GMios=; h=X-UI-Sender-Class:From:To:Subject:References:Date:In-Reply-To; b=HN0/ZoBHkaCoIru5r7eke9EFcgbIaAjyf8xBarQtOjUxs0wJ7V7HKM0XPta8MYXF/ 0dfhQxK9eFSvufFP6tpnyHk6jDYwijrOqauN83iGZaWZs2bnvU3WBIe7zN8r/oOzV/ fRFWYQcRO5Zebqneehg1g+GkITqvW57lxSfMVXQY= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from localhost.localdomain ([79.223.36.122]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MfpSb-1icZZG1ToH-00gGlU; Sun, 15 Sep 2019 18:17:35 +0200 Original-Received: by localhost.localdomain (Postfix, from userid 1000) id E6A23800B9; Sun, 15 Sep 2019 18:17:31 +0200 (CEST) In-Reply-To: <20190915121332.E09E720BC2@vcs0.savannah.gnu.org> (Lars Ingebrigtsen's message of "Sun, 15 Sep 2019 08:13:32 -0400 (EDT)") X-Provags-ID: V03:K1:43YsUTxaB5MM50TQeCSbOE8mstrdYA/+3iNZ/Iln5QPhZ68wxvL /H3NETRjLzUBsRTOlcPsf6mwIOHTkZDecXOx+CJZjUiT7sKZQ2eJPDUvqF8lUplnHWxu2dj 1YceN4cATeKy5lNUWEgMw4O8KV293ejCxjSR+YxQtIuIDtUaQdOenZYENTQrBl1Upnmj4P/ t9LebuRg8Kp5Hjn5dBNHQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:pXXWfRv8/mY=:tfW4wgK3X30ErO5BH9unJ5 XMdtu2/RYfb0y8ohtdW26uI6DGqoK2O/xNzwZBzmKV2NpWNKP34b2z6gde9M1b6KdyTgpxzFH 8LNN+EUxAZ7WaxA2O1fgm6gRKLcfONWV1IRpsi7PU0P0kDECTzMR5qwcmdoTWv5+IEBRdUC1O m4rW2KRKAm/kaVIck2qDpE1k3EFxuG/yGvfiyoEb+++SHiUkrm2lUy4gFx8k+3MzWJ4r8DF6R i/nsEmH2KnB36OLTnwshgJP51nMP70QcvhULM6+oKfL1hQaKiWknt5sJATaMnex8OIYxtIDG7 s3XxZu9QDGyec5Q/3wPXdrlD3z3iPjfn3BRrCvkNC8MwAR311JR3PHpKsqYMderS7VOWuNx8u E9SuzRuBiypRrNzB2D4tSJOWx5flgu2ocSplKqhiHsq4MJMeMxVhEjbUBZ1b9OFTdi/9tgFvA lhLRJH//phkKFoLpCZwhEpP+3fvwjSsxij0YOYrYyI8BVODttjlFWt77G7iW0IoIKk0u6O85S nyDet+67JxXUuKYFkbSIuxO4iV68ckBfNabwIPRMkG9hEXtgJ3vkiESzOpiE81jFS5mXSeSu2 t4UDj3QVs1qJyNPc5e9w4oys5ymIP8RCJSSICxRA3aNdv+w98LdYyqOIXR31Q4V9xkGQsKtWO uE/1kQ9hEL/6aPBWWTfxEquqQq01FTPyJdGNdIY4yOb5tZWY0jM515SBewjhdRXqd9DFEgte4 M8Ao1oYz0Q5D1n8I5x1JiTMZBlB+r9/1BCirjmCVjKWNk0wylySyAW8mDUwarCCc3Rv/hSIA X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.17.21 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240049 Archived-At: On 2019-09-15 08:13 -0400, Lars Ingebrigtsen wrote: > branch: master > commit f198a5c5144fdded1400df6e8454e4b1b912c7de > Author: Lars Ingebrigtsen > Commit: Lars Ingebrigtsen > > Revert "emacsclient: ignore --eval parameters when starting alternat= e editor" > > This reverts commit 6fe661342a24edcaea255c3ba9a37613031554da. > > The alternate editor may be Emacs, which is useful when you want to = eval something in an existing Emacs (if it exists), or in a new Emacs if t= here's no server running. But if there is no server running, the new Emacs instance does not actually eval the expression. This is mentioned in the NEWS file: ,---- | *** emacsclient no longer passes '--eval' arguments to an alternate edit= or. | Previously, '--eval' arguments were passed as file names to any | alternate editor started by '--alternate-editor'. `---- For that reason, --eval is useless if emacsclient cannot find the server in Emacs. Cheers, Sven > --- > lib-src/emacsclient.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/lib-src/emacsclient.c b/lib-src/emacsclient.c > index e9469f7..65effc6 100644 > --- a/lib-src/emacsclient.c > +++ b/lib-src/emacsclient.c > @@ -700,11 +700,7 @@ fail (void) > { > if (alternate_editor) > { > - /* If the user has said --eval, then those aren't file name > - parameters, so don't put them on the alternate_editor command > - line. */ > - size_t extra_args_size =3D > - (eval? 0: (main_argc - optind + 1) * sizeof (char *)); > + size_t extra_args_size =3D (main_argc - optind + 1) * sizeof (cha= r *); > size_t new_argv_size =3D extra_args_size; > char **new_argv =3D xmalloc (new_argv_size); > char *s =3D xstrdup (alternate_editor); > > _______________________________________________ > Emacs-diffs mailing list > Emacs-diffs@gnu.org > https://lists.gnu.org/mailman/listinfo/emacs-diffs