From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.devel Subject: Re: A project-files implementation for Git projects Date: Mon, 16 Sep 2019 15:32:45 +0200 Message-ID: <87sgows6wy.fsf@gnu.org> References: <8736h9rdc4.fsf@gnu.org> <87mufcfz1u.fsf@gnu.org> <87tv9kz2x6.fsf@gnu.org> <87a7bbjdwe.fsf@gnu.org> <87a7ba8uvx.fsf@gnu.org> <87pnk2zvvy.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="58319"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Sep 16 15:33:49 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i9r8X-000F0O-IA for ged-emacs-devel@m.gmane.org; Mon, 16 Sep 2019 15:33:49 +0200 Original-Received: from localhost ([::1]:34176 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i9r8W-0001kg-5L for ged-emacs-devel@m.gmane.org; Mon, 16 Sep 2019 09:33:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42276) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i9r7c-0001iQ-DL for emacs-devel@gnu.org; Mon, 16 Sep 2019 09:32:53 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:50875) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1i9r7c-0004sb-5y; Mon, 16 Sep 2019 09:32:52 -0400 Original-Received: from auth1-smtp.messagingengine.com ([66.111.4.227]:38299) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1i9r7Y-0002XQ-7U; Mon, 16 Sep 2019 09:32:50 -0400 Original-Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailauth.nyi.internal (Postfix) with ESMTP id D9707202D1; Mon, 16 Sep 2019 09:32:47 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Mon, 16 Sep 2019 09:32:47 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudefgdeiiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufhffjgfkfgggtgesthdtredttdertdenucfhrhhomhepvfgrshhsihhl ohcujfhorhhnuceothhsughhsehgnhhurdhorhhgqeenucffohhmrghinhepvghlrdhhoh ifnecukfhppedufeegrdduudelrddvgedrudelheenucfrrghrrghmpehmrghilhhfrhho mhepthhhohhrnhdomhgvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqkeeijeefke ejkeegqdeifeehvdelkedqthhsughhpeepghhnuhdrohhrghesfhgrshhtmhgrihhlrdhf mhenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Original-Received: from jiffyarch (j289989.servers.jiffybox.net [134.119.24.195]) by mail.messagingengine.com (Postfix) with ESMTPA id F21F48005A; Mon, 16 Sep 2019 09:32:46 -0400 (EDT) In-Reply-To: (Dmitry Gutov's message of "Sun, 15 Sep 2019 21:56:11 +0300") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240074 Archived-At: Dmitry Gutov writes: Hi Dmitry, >> "hg files" doesn't seem to have a way to list untracked files. Same >> for subversion. > > I've only looked into Mercurial so far, and 'hg status -u' seems to do > the trick. Depending on performance, you could call 'hg status -c -u', > or augment the output of 'hg files' with a call to 'hg status -u'. Ah, "hg status --all" lists all files including their state (untracked, ignored, you-name-it), so that's the one we should use. Performance seems to be the same as for "hg files". > Overall, I'm not 100% sure that we should use VC backend action here > because it seems like we'll be fighting an impedance mismatch between > what Git thinks its files are and what we want to see in the list of > project files. We probably want to use Git because it's fast and > flexible, but other VCSes are going to be less helpful. So if I were > writing this myself I'd create a "fast path" for Git repos, and > delegate to 'find' otherwise. I think we can come up with a VC list-files operation which optionally includes untracked and ignored files (where the latter implies the former, doesn't it?) but I'd leave the filtering according to project-vc-ignores to project.el. How would project.el call such a VC list-files operation? I guess you would include untracked and also ignored files, right? In my use-case, the inclusion of ignored files would probably increase the size of the list of files by a factor of at least 2 because for every *.java file in our project, there's at least one ignored *.class file (but probably more like 2-20 *.class files). So a new defcustom or include ignored files only if project-vc-ignores has a non-nil value? Bye, Tassilo