From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#37496: 27.0.50; C-s failing to search Date: Mon, 07 Oct 2019 21:17:41 +0300 Organization: LINKOV.NET Message-ID: <87sgo46a4q.fsf@mail.linkov.net> References: <20190926075054.GI4022@protected.rcdrun.com> <831rw3mqh2.fsf@gnu.org> <20190926085433.GN4022@protected.rcdrun.com> <83zhirl73d.fsf@gnu.org> <20191003183212.GJ6957@protected.rcdrun.com> <835zl57j4h.fsf@gnu.org> <20191003191433.GA14781@protected.rcdrun.com> <8336g97gt5.fsf@gnu.org> <20191003195105.GE14781@protected.rcdrun.com> <831rvt6kuj.fsf@gnu.org> <20191004143316.GI4341@protected.rcdrun.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="146050"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 37496@debbugs.gnu.org To: Jean Louis Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 07 21:02:39 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iHYHH-000boe-97 for geb-bug-gnu-emacs@m.gmane.org; Mon, 07 Oct 2019 21:02:39 +0200 Original-Received: from localhost ([::1]:49042 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHYHE-0007zw-Qu for geb-bug-gnu-emacs@m.gmane.org; Mon, 07 Oct 2019 15:02:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54961) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHYGj-0007td-2l for bug-gnu-emacs@gnu.org; Mon, 07 Oct 2019 15:02:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iHYGg-0006Fx-Nj for bug-gnu-emacs@gnu.org; Mon, 07 Oct 2019 15:02:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40335) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iHYGg-0006Fk-KO for bug-gnu-emacs@gnu.org; Mon, 07 Oct 2019 15:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iHYGg-00024Y-GG for bug-gnu-emacs@gnu.org; Mon, 07 Oct 2019 15:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 Oct 2019 19:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37496 X-GNU-PR-Package: emacs Original-Received: via spool by 37496-submit@debbugs.gnu.org id=B37496.15704748876228 (code B ref 37496); Mon, 07 Oct 2019 19:02:02 +0000 Original-Received: (at 37496) by debbugs.gnu.org; 7 Oct 2019 19:01:27 +0000 Original-Received: from localhost ([127.0.0.1]:49150 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iHYG6-0001c0-Ou for submit@debbugs.gnu.org; Mon, 07 Oct 2019 15:01:27 -0400 Original-Received: from chocolate.birch.relay.mailchannels.net ([23.83.209.35]:57636) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iHYG5-0001ZX-26 for 37496@debbugs.gnu.org; Mon, 07 Oct 2019 15:01:25 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id C9E0B502041; Mon, 7 Oct 2019 19:01:23 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a42.g.dreamhost.com (100-96-15-102.trex.outbound.svc.cluster.local [100.96.15.102]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 0236D501F78; Mon, 7 Oct 2019 19:01:22 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a42.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.3); Mon, 07 Oct 2019 19:01:23 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Zesty-Continue: 0b5f843b2368933b_1570474883295_698082912 X-MC-Loop-Signature: 1570474883295:3284303111 X-MC-Ingress-Time: 1570474883295 Original-Received: from pdx1-sub0-mail-a42.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a42.g.dreamhost.com (Postfix) with ESMTP id BB11981C65; Mon, 7 Oct 2019 12:01:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=UU4drn35LgGUIegDWcSacRLWmvs=; b= UCTRw/CTf7pL/ixqP3eiZt9LKDsF9TYfAqETGLHeNvVBEMy8yz+x6iU81d8HE0dA TN4tOzVkRD/cDkzx7FmpYpcEI7aSEVs4H42KRjX2M0vf3ZDYHFXGqfC1ceAKKnyA QdHU5ODDFPvuBYpfbC7hdsIjwV973dY1wSY7Sno12Yk= Original-Received: from mail.jurta.org (m91-129-99-99.cust.tele2.ee [91.129.99.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a42.g.dreamhost.com (Postfix) with ESMTPSA id 8816281C67; Mon, 7 Oct 2019 12:01:13 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a42 In-Reply-To: <20191004143316.GI4341@protected.rcdrun.com> (Jean Louis's message of "Fri, 4 Oct 2019 16:33:16 +0200") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedrheejgdduvddtucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrdelledrleelnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledrleelrdelledprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegsuhhgshesghhnuhdrshhuphhpohhrthenucevlhhushhtvghrufhiiigvpedu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:168579 Archived-At: > I was just editing file names, then quitting with C-c C-c and often > pressing ^^ to go to upper directory. I have normally two windows, > from one I move the files to the other one > > Sometimes I forget to press C-c C-c, then I notice it and press it, > but could not observe how the bug is invoked. Next time you encounter this problem please try running this diagnostics with just 'M-x isearch-diagnostics RET' in the buffer where isearch fails: (defun isearch-diagnostics () (interactive) (let* ((variables '(major-mode buffer-read-only isearch-mode isearch-success isearch-error isearch-wrapped isearch-adjusted isearch-suspended isearch-regexp isearch-case-fold-search isearch-invisible isearch-hidden isearch-allow-scroll isearch-search-fun-function isearch-wrap-function isearch-push-state-function isearch-mode-hook isearch-update-post-hook isearch-mode-end-hook isearch-filter-predicate dired-isearch-filenames dired-isearch-filenames-mode)) (diagnostics (concat (mapconcat (lambda (v) (format "%s: %s %s" v (cl-prin1-to-string (and (boundp v) (buffer-local-value v (current-buffer)))) (cl-prin1-to-string (and (boundp v) (default-value v))))) variables "\n") (format "\nany read-only: %S\n" (text-property-any (point-min) (point-max) 'read-only t))))) (display-buffer (with-current-buffer (get-buffer-create "*isearch-diagnostics*") (erase-buffer) (insert diagnostics) (current-buffer))))) >From what I see wdired doesn't restore a previous value of isearch-filter-predicate. This is fine as long as there are no read-only properties kept in the Dired buffer, but it seems in your case read-only properties might be still present after finishing Wdired-mode. If you can reproduce the bug please also try the following patch that could fix it: diff --git a/lisp/wdired.el b/lisp/wdired.el index 44f083bb7f..35f1b5ebbd 100644 --- a/lisp/wdired.el +++ b/lisp/wdired.el @@ -357,6 +357,8 @@ wdired-change-to-dired-mode (remove-text-properties (point-min) (point-max) '(front-sticky nil rear-nonsticky nil read-only nil keymap nil))) + (remove-function (local 'isearch-filter-predicate) + #'wdired-isearch-filter-read-only) (use-local-map dired-mode-map) (force-mode-line-update) (setq buffer-read-only t)