all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: Deus Max <deusmax@gmx.com>
Cc: "Jose A. Ortega Ruiz" <mail@jao.io>, 39515@debbugs.gnu.org
Subject: bug#39515: 28.0.50;
Date: Thu, 13 Feb 2020 11:14:59 -0800	[thread overview]
Message-ID: <87sgjez4cs.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <87pneil5u5.fsf_-_@aia00054aia.gr> (Deus Max's message of "Thu, 13 Feb 2020 20:06:42 +0200")

[-- Attachment #1: Type: text/plain, Size: 794 bytes --]


On 02/13/20 20:06 PM, Deus Max wrote:
> On Mon, 10 Feb 2020, "Jose A. Ortega Ruiz" wrote:
>
>> At any rate, if this is the expected behaviour, one should probably
>> update the manual, which doesn't mention this.  That contributes to the
>> surprise, at least in my case.
>
> The gnus-group-make-nnir-group (GG) function documentation clearly
> states the expected behavior:
>
>     ... if called from the *Group* buffer search any marked groups, or
>     the group on the current line, or all the groups under the current
>                                      ^^^^^^^^^^^^^^^
>     topic.

Good enough for me! This patch should allow us to search all groups,
visible or not, and recursive groups under sub-topics. A quick test
shows it works for me -- anyone else want to try it out first?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: gnus-search-topic-groups.diff --]
[-- Type: text/x-patch, Size: 534 bytes --]

diff --git a/lisp/gnus/nnir.el b/lisp/gnus/nnir.el
index 0f364d66e1..0277524a8c 100644
--- a/lisp/gnus/nnir.el
+++ b/lisp/gnus/nnir.el
@@ -617,7 +617,8 @@ gnus-group-make-nnir-group
 		       (list (gnus-group-group-name))
 		     (mapcar (lambda (entry)
 			       (gnus-info-group (cadr entry)))
-			     (gnus-topic-find-groups (gnus-group-topic-name)))))
+			     (gnus-topic-find-groups (gnus-group-topic-name)
+						     nil t nil t))))
 	       gnus-group-server))))
 	 (query-spec
 	  (or (cdr (assq 'nnir-query-spec specs))

  reply	other threads:[~2020-02-13 19:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87wo8ql70m.fsf@aia00054aia.gr>
     [not found] ` <handler.s.R.158161568811442.transcript@debbugs.gnu.org>
2020-02-13 18:06   ` bug#39515: 28.0.50; Deus Max
2020-02-13 19:14     ` Eric Abrahamsen [this message]
2020-02-14 15:00       ` Jose A. Ortega Ruiz
2020-02-14 19:59         ` Eric Abrahamsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sgjez4cs.fsf@ericabrahamsen.net \
    --to=eric@ericabrahamsen.net \
    --cc=39515@debbugs.gnu.org \
    --cc=deusmax@gmx.com \
    --cc=mail@jao.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.