From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#41099: 28.0.50; TRAMP process-file ignores exit status of remote process Date: Wed, 06 May 2020 10:38:39 +0200 Message-ID: <87sggdmp9s.fsf@gmx.de> References: <871rnyyyio.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="63797"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 41099@debbugs.gnu.org To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 06 10:39:33 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jWFaX-000GVl-JL for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 May 2020 10:39:33 +0200 Original-Received: from localhost ([::1]:43444 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jWFaW-00011n-Ak for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 May 2020 04:39:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40966) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWFa2-00011N-Fn for bug-gnu-emacs@gnu.org; Wed, 06 May 2020 04:39:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55150) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jWFa2-0005LI-6s for bug-gnu-emacs@gnu.org; Wed, 06 May 2020 04:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jWFa2-0003jy-3x for bug-gnu-emacs@gnu.org; Wed, 06 May 2020 04:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 May 2020 08:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41099 X-GNU-PR-Package: emacs Original-Received: via spool by 41099-submit@debbugs.gnu.org id=B41099.158875433014358 (code B ref 41099); Wed, 06 May 2020 08:39:02 +0000 Original-Received: (at 41099) by debbugs.gnu.org; 6 May 2020 08:38:50 +0000 Original-Received: from localhost ([127.0.0.1]:38463 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jWFZq-0003jW-0b for submit@debbugs.gnu.org; Wed, 06 May 2020 04:38:50 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:35655) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jWFZn-0003jI-R7 for 41099@debbugs.gnu.org; Wed, 06 May 2020 04:38:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1588754321; bh=Swlq+FVyXA4iW2bfqpiT7BvMVU7Jap+wz82MNH6s9WU=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=AtlBgPcw8RBxhnTWzFyEdqWIJ3j6HZVOKFDjBzLVEvT6jXakVChOlYlORu04sRTUi zb+WNOG2QdFi0j4cXZ0E9PMfI0zH6AZV1mnqq+MQQtlBmZJBNI3Hf0nXlZ46p010HP M711TtQNm1FxU3e3oYj8axYpZqu6W0iSGlA+bphU= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([212.86.42.197]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mj8qj-1iu8rl4BZF-00fEMZ; Wed, 06 May 2020 10:38:41 +0200 In-Reply-To: <871rnyyyio.fsf@gmx.de> (Michael Albinus's message of "Tue, 05 May 2020 21:25:51 +0200") X-Provags-ID: V03:K1:4r60VoC66pyVICmkD4rJ/pLYz2LYfepI/RiZnmeMpQ5gpIzwI7P NCOP5dloyGSOG9GFrCc8TmBb5lSLslzdR2y6lllREzau6VSHL2vwajiYDddTp4ZORjDnOqc wHqJJc6o83n5NjFJeD1wmz5O9AluUW2uASLGeXFK4QS4ZB0EuZGuT/43/dzo1O7QlvvVMZg XY9nRPSVjJRNvS6ouplLw== X-UI-Out-Filterresults: notjunk:1;V03:K0:TX7ae8kvY9o=:TF4lRoIxK8a8BytmmbwIKt f6qtpeRjw4Cd2OnCG2NRcxq8MqDQymZW9s7P9J+YMp+QojPAcpPsW1/yxif7BkBLvo799kDbH YSl44/OKWeb9+yMykUMhDbgOTuY+oPM2nXEJ0KBY+P+UU3Gfc25ZaCHQt03WlD2N99OXla2Cv YnmBsb70wRA/r+YCVCMKRBkzcdzyL88jC1vbMIK5cNE8jDVbBlhNPO7eLq4AGesd8ZVJIdIya hbOHvlxYS18KqymQ26olLsEw3yf0yK1sfxR10IdHNxMyR26/Arxay0sw7cqaqxT5K+Wh1INI/ 5RlkU9dE/+0QwZYy75RW5xxaFMMLYDrGJdu8kpGst4v2cU3eT1FouBD68HW42IlYoOrlVeXn3 TUDxz/z/TV3cicexxu1TEBYNzbYSjjtpxOs6wFLmap+wEgPbnJZYc9IvuqrwxbIfmlkMxPfOE 935mULwSYwK2SNs0U/WPZKO05zZEA843229AazcAfl1qD6uk7S3u42bl1zlhrF/IKY7tLnnFs qeo30rPrA9UO4AUClG+t8ISA5LEccJ3WQ5nHRSyz58LOrHQ+Sd21wJuX087oAg2fmiOP12xPN 4nK7ytJ80EqbYZvkYvhXgbVXFDQIuzm0/c2izpo/7Ms7hLP5xiJDJKg0cSO8yPbM1nzhLYkrH 2KnUVUZvqKVD0+zrqKke5sDqs6Ofr1h1Dajk3oRVHaGaxb33ZwErzfppzg2VzUJ9225wnbvnD 9qdO8PoXTu/KmPlLW+t+nEjkUCDxhBsr7FTkZYtUn/eDoJhUm2mCbSlJHHoKACb1wKmjUimD X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:179789 Archived-At: Michael Albinus writes: Hi Philipp, >> It looks like `tramp-send-command-and-check' should not just search >> for the exit code, but also return it. > > No, most use cases a simple nil or t is appropriate. Otherwise, you would > need to check always (zerop (tramp-send-command-and-check ...)). But in > tramp-sh-handle-process-file, it shall return the exit code (indicated > by an optional argument). > > Same for tramp-adb-send-command-and-check, called in tramp-adb-handle-process-file. I've fixed this in master, could you pls check? Best regards, Michael.