From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#41133: 28.0.50; Respect browse-url user options in shr/eww Date: Sat, 09 May 2020 14:32:29 +0100 Message-ID: <87sgg9tes2.fsf@tcd.ie> References: <87wo5njkbq.fsf@tcd.ie> <87h7wqlwrw.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="599"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: lars ingebrigtsen , 41133@debbugs.gnu.org To: Tassilo Horn Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 09 15:33:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jXPbK-000Y3D-Pj for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 09 May 2020 15:33:10 +0200 Original-Received: from localhost ([::1]:46770 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jXPbJ-0007Yd-C6 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 09 May 2020 09:33:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48860) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jXPbC-0007YL-Kf for bug-gnu-emacs@gnu.org; Sat, 09 May 2020 09:33:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35416) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jXPbC-0005s7-Bk for bug-gnu-emacs@gnu.org; Sat, 09 May 2020 09:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jXPbC-0007kF-80 for bug-gnu-emacs@gnu.org; Sat, 09 May 2020 09:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 May 2020 13:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41133 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41133-submit@debbugs.gnu.org id=B41133.158903115929738 (code B ref 41133); Sat, 09 May 2020 13:33:02 +0000 Original-Received: (at 41133) by debbugs.gnu.org; 9 May 2020 13:32:39 +0000 Original-Received: from localhost ([127.0.0.1]:46962 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jXPao-0007jZ-Q3 for submit@debbugs.gnu.org; Sat, 09 May 2020 09:32:39 -0400 Original-Received: from mail-wr1-f41.google.com ([209.85.221.41]:42363) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jXPan-0007jH-AA for 41133@debbugs.gnu.org; Sat, 09 May 2020 09:32:37 -0400 Original-Received: by mail-wr1-f41.google.com with SMTP id s8so5168648wrt.9 for <41133@debbugs.gnu.org>; Sat, 09 May 2020 06:32:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=bibYVyGj6j4c2xfyVWQc+LdLmZ9VWibZIlcC7+tqArk=; b=hWjMQmFsX8TDcyndsKvEz7C9lJBi6u/NagCfH0H+JuHN9/q5s2LHHR4XEJe354BSok EXU9Ht7T/W4iC23v0oLzaIiRLkkWWGvd5aNmU+eDD4kt0QNRywnlzu8L6Btxy5H1alRk eBMr/973NvwsS6iUUUWn8TLWv0DWvRRwmWz0SEpDfwG0jovAPfGstwnJY5p96XdqhPcq b7FHyci0vJHc9h0zWL0b5VypbdkrA4vF/SVGwmtMAE+w+tbYm3xkRttbJpzxeUI9o6jX HmxSvesyPNyhqv/Hm2TVuhfOr7YixCDDfgvScwIDTPt0gFyeqMrARfkqarJn4I8XZ3eF MhDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=bibYVyGj6j4c2xfyVWQc+LdLmZ9VWibZIlcC7+tqArk=; b=BPZsnSPYAckH2jdPDV4A3PJqqSQTJbA6JUEyNbwnO+kNBWPy8PDmsD6JQECRC15Mgc TWB3DR/aGCI3KVuGoh9z+T+9NWLzlDqJvj5TqQ21m3Xh+D5wAF3lglVMzxTwIewGC//H ZE+D0yJKyAiz+d0vUbZ1CiZz00ddUMSxkkY1r6wb4LdgmHaazM/VC5YIiTn37MlNt8hY sXfj+H+QNq0GIPUa/YNiOIwZzdnJRYQzos3lSd+U9cmMuHC/OHZiRno1vPcvmIx70SCF gZ659CEyCIPMJYJ5VnUxeAYcYWGfEu3phughVMaxoWplr5iLkyc0xU8mVKpml9MRpTmt /v7A== X-Gm-Message-State: AGi0PuYpZUpM/FOPBZKiLKOebUfO8n+AC5Q9b7bF0/WSMwpq+OhLAXb0 aFQJX05UAiPIJWoJWXmSK80MSA== X-Google-Smtp-Source: APiQypJN9CR+QKivSWib6VrDffY7HYiZ7q2HH9Fv8kUryG/exEApSGSUQiddh0quoOj24EKVaHUlCw== X-Received: by 2002:a5d:54c4:: with SMTP id x4mr9075793wrv.73.1589031151438; Sat, 09 May 2020 06:32:31 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:1f68:7ff5:120d:64e]) by smtp.gmail.com with ESMTPSA id b22sm25893949wmj.1.2020.05.09.06.32.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 May 2020 06:32:30 -0700 (PDT) In-Reply-To: <87h7wqlwrw.fsf@gnu.org> (Tassilo Horn's message of "Fri, 08 May 2020 09:18:43 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:179967 Archived-At: Tassilo Horn writes: > "Basil L. Contovounesios" writes: > >> X-Debbugs-Cc: Lars Ingebrigtsen , Tassilo Horn >> Severity: wishlist >> Tags: patch >> >> The commands shr-browse-url and eww-follow-link currently pass mailto >> URLs directly to browse-url-mail, which doesn't respect the user options >> browse-url-handlers and browse-url-mailto-function. >> >> Can't/shouldn't the commands call browse-url instead? >> WDYT of the attached patch that does this? > > Looks good to me (I just looked at the parts calling browse-url), and I > think it won't change any behavior unless the user customizes > browse-url-handlers to catch mailto links with his own function instead > of the default one in browse-url-default-handlers (which in turn just > calls browse-url-mailto-function). Thanks. > BTW: I didn't know about function-put. Should that be preferred to put? > I've tested that put/get also work with #'function, so where's the > difference? function-put is currently identical to put, but this may change in the future. Quoth (info "(elisp) Symbol Plists"): -- Function: function-put function property value This function sets PROPERTY of FUNCTION to VALUE. FUNCTION should be a symbol. This function is preferred to calling =E2=80=98put=E2=80= =99 for setting properties of a function, because it will allow us some day to implement remapping of old properties to new ones. See also the commentary in its definition: (defalias 'function-put ;; We don't want people to just use `put' because we can't conveniently ;; hook into `put' to remap old properties to new ones. But for now, t= here's ;; no such remapping, so we just call `put'. #'(lambda (function prop value) "Set FUNCTION's property PROP to VALUE. The namespace for PROP is shared with symbols. So far, FUNCTION can only be a symbol, not a lambda expression." (put function prop value))) --=20 Basil