From: Kyle Meyer <kyle@kyleam.com>
To: Mario Frasca <mario@anche.no>, emacs-orgmode@gnu.org
Subject: Re: [PATCH] implementing `with' as a list, and respecting `deps' order.
Date: Wed, 03 Jun 2020 03:38:34 +0000 [thread overview]
Message-ID: <87sgfcx1hh.fsf@kyleam.com> (raw)
In-Reply-To: <43f4eda9-627d-4b36-7226-37b5458193e8@anche.no>
Mario Frasca writes:
> From 436bfd0b9fd656f52ea9d7e6a6a665a32564ae93 Mon Sep 17 00:00:00 2001
> From: Mario Frasca <mario@anche.no>
> Date: Tue, 2 Jun 2020 15:46:20 +0000
> Subject: [PATCH] implementing `with' as a list, and respecting `deps' order.
Thank you for sending an updated patch. Unfortunately it looks like it
got mangled by your email client and can't be understood by `git am'.
This list is okay with patches being sent as attachments, and going that
route gets around needing to re-configure your email client or use
git-send-email.
Before sending the updated patch, please revise the commit message to
more closely match the conventions described at
<https://orgmode.org/worg/org-contribute.html>. Looking over some
recent commits in the repo should give you a good sense for the expected
changelog-like entries as well other style aspects (e.g., it is common
to start the subject with "<file|area>: " like "org-plot: ..."), which
gives log readers a sense for the general topic affected by the commit.
Please send the next patch as a follow-up to the original thread to keep
the discussion in one place.
Thanks again.
next prev parent reply other threads:[~2020-06-03 3:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 15:57 [PATCH] implementing `with' as a list, and respecting `deps' order Mario Frasca
2020-06-03 3:38 ` Kyle Meyer [this message]
2020-06-03 14:46 ` Mario Frasca
2020-06-03 15:03 ` Bastien
2020-06-03 23:50 ` Kyle Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sgfcx1hh.fsf@kyleam.com \
--to=kyle@kyleam.com \
--cc=emacs-orgmode@gnu.org \
--cc=mario@anche.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.