From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Christophe Troestler Newsgroups: gmane.emacs.bugs Subject: bug#41723: 26.3; Enable replying to an ical event even when not an attendee Date: Fri, 05 Jun 2020 20:23:19 +0200 Message-ID: <87sgf9jrs8.fsf@poincare.umons.ac.be> References: <87k10lld4p.fsf@poincare.umons.ac.be> <87v9k5cs2v.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="61931"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.5.1; emacs 26.3 Cc: 41723@debbugs.gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 05 20:24:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jhH0o-000G4o-MU for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Jun 2020 20:24:14 +0200 Original-Received: from localhost ([::1]:46584 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jhH0n-0001X8-Ch for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Jun 2020 14:24:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54032) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jhH0c-0001Ui-8C for bug-gnu-emacs@gnu.org; Fri, 05 Jun 2020 14:24:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38359) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jhH0b-0006A8-VM for bug-gnu-emacs@gnu.org; Fri, 05 Jun 2020 14:24:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jhH0b-00072y-Or; Fri, 05 Jun 2020 14:24:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Christophe Troestler Original-Sender: "Debbugs-submit" Resent-CC: bugs@gnus.org, bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Jun 2020 18:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41723 X-GNU-PR-Package: gnus,emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41723-submit@debbugs.gnu.org id=B41723.159138141227043 (code B ref 41723); Fri, 05 Jun 2020 18:24:01 +0000 Original-Received: (at 41723) by debbugs.gnu.org; 5 Jun 2020 18:23:32 +0000 Original-Received: from localhost ([127.0.0.1]:49904 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhH07-000727-PN for submit@debbugs.gnu.org; Fri, 05 Jun 2020 14:23:32 -0400 Original-Received: from mail-eopbgr20081.outbound.protection.outlook.com ([40.107.2.81]:56386 helo=EUR02-VE1-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhH05-00071o-PT for 41723@debbugs.gnu.org; Fri, 05 Jun 2020 14:23:30 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YvecHL1na3+EXd2P6so5e7MQK6NXp/5une1OhnvOjpUIkZzDkDb0fTD6nO1Sw3bYQjwV15jNEtOFzrxx77wNYZNh6CwZ1/g93LfWPqqeIaB2HQqmHcJUtybAQWwuZGZJeEuBpPwftcfSrFtMcdZTbMyd2rqNkSUZ3BGxm1kno/reneWwzh+Ahl3DUajsu9jy3uKY+3cfKFM+zZhbeq20yVmNPu8mHPm1CAH88n7h+yLPOU+5HTh7mu1jL6H8NwPxHqdDRVM+3m4GfDwxJ1R0mI8GWGoanxILMaMdIEyz5tv6tqe4ktAyngoCXxc3Ahst2r5Ao3CF6wCiraoYEYdZWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TCWdwC/AS66+S2qYoTa0vkB7J+/Rcp5fbyVkPqan3Y0=; b=lMUcB56ZF/jMFO9dEVuKuwis2vQiiiNatWuYi5Ct/Fx9qCdY3IcoitkYZvfFPK5ovSqCmNQa/us1XY9NjDNFog3vWAayJQrrc5gACqYC86KwWrrJPIACyafOCsfT4X6zVaa9zEvCw4UmpmT+6PESVdXoQom0jh6RiK8yT95iGlY0fXOY2mgxDOe4h8jGRvzrI+cu4qqVTrO0cPDfoXSN9TcRN8jEPo2imkTsV5+RpmHOMdAA14iG0tlNHdphHRJFmsYJtTKKxfMFWkPXgsbwGWiXGlM1HLxYl6DvSCnjIZy8Jn23sOwDGKGlhN5ydTXuAsPxyqXq5hDS/xoasTeOPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=umons.ac.be; dmarc=pass action=none header.from=umons.ac.be; dkim=pass header.d=umons.ac.be; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alumniumonsac.onmicrosoft.com; s=selector1-alumniumonsac-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TCWdwC/AS66+S2qYoTa0vkB7J+/Rcp5fbyVkPqan3Y0=; b=uLHd15J7Jg+u02mH+5bRx5DxOfzE+PovsXw2Aow9/gNwesSj/KHgLvHDs8z4OmSzZIi0REBrrFm3t+x0QQxroMkap2ycSKGh7KH9JxF+Z1y6qp87GkRYA/xFUBtTqtyzS5b/IupdqfrFZOOVj4YI7pN1BXdRBNc2NmU11vdMU/k= Authentication-Results: umons.ac.be; dkim=none (message not signed) header.d=none;umons.ac.be; dmarc=none action=none header.from=umons.ac.be; Original-Received: from DB7PR01MB5259.eurprd01.prod.exchangelabs.com (2603:10a6:10:84::12) by DB7PR01MB4697.eurprd01.prod.exchangelabs.com (2603:10a6:10:6a::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3066.18; Fri, 5 Jun 2020 18:23:21 +0000 Original-Received: from DB7PR01MB5259.eurprd01.prod.exchangelabs.com ([fe80::94d3:d168:1c3e:76c9]) by DB7PR01MB5259.eurprd01.prod.exchangelabs.com ([fe80::94d3:d168:1c3e:76c9%3]) with mapi id 15.20.3066.022; Fri, 5 Jun 2020 18:23:21 +0000 In-reply-to: <87v9k5cs2v.fsf@tcd.ie> X-ClientProxiedBy: AM4PR0902CA0004.eurprd09.prod.outlook.com (2603:10a6:200:9b::14) To DB7PR01MB5259.eurprd01.prod.exchangelabs.com (2603:10a6:10:84::12) X-MS-Exchange-MessageSentRepresentingType: 1 Original-Received: from poincare (2a02:a03f:c394:e400:a5b3:c7f5:da59:8dec) by AM4PR0902CA0004.eurprd09.prod.outlook.com (2603:10a6:200:9b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3066.18 via Frontend Transport; Fri, 5 Jun 2020 18:23:20 +0000 Original-Received: from [::1] (helo=poincare) by poincare with esmtp (Exim 4.93) (envelope-from ) id 1jhGzv-007bki-Jy; Fri, 05 Jun 2020 20:23:19 +0200 X-Originating-IP: [2a02:a03f:c394:e400:a5b3:c7f5:da59:8dec] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5e0020a5-4974-408d-4bf2-08d8097d86ba X-MS-TrafficTypeDiagnostic: DB7PR01MB4697: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-Forefront-PRVS: 0425A67DEF X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: x4Bev1/nzgfLhGRVuzqaHlxppjupPgJFYmNB1Z4q/a/3epuIdvfWIufMYDf1n1d7SEK5IAG1zXND0AWOb+fyaI3/GhDVBht4pJVOiS/IuDnlaOatqLUjWJRp5h02Wn2Fai3U6k65cdlO11HtJ/N+z4Khmvon1H8+ODFNozWcHHb9e9msBCYn3gTNGY+TkoEG/FqckZkyABCUX2b2JZIUHh5f5ioFlIY6vE2FPmb4kHtqc1zejvpLVAsiOqKmeYssw5ooKpJz0VHvQL2eCUS94udMSYwJrdN8Pw4Wv1MfWD0BpFakRHsOTpSqaqqZQvtoMqdsFd1qUo7yyCPpdYyVtLRMQDJKt0B8bg+RYhFVGDU0MBCMUX1k1hg+g7tPNlxr X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB7PR01MB5259.eurprd01.prod.exchangelabs.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(366004)(396003)(346002)(136003)(39860400002)(2906002)(5660300002)(186003)(6916009)(44832011)(33964004)(426003)(53546011)(4326008)(52116002)(478600001)(66476007)(8936002)(8676002)(86362001)(66556008)(66946007)(83380400001)(786003)(66616009)(9786002)(316002)(130980200001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: 84DRosYCjxaBobV+iDyU5VXmwWn+hxQ8Z2re2TUEYVRI/jmdHNbCbRwy1WtcujCATA0t/kZjWenuWSYjxlJgNh515tSj/rLtz0uIXOIkdfc7/cbGdFUv0THLGvw9MRWoJw8AO5TbpDW4/ZDDrIFnhXgVhb+heSoGDlL50ZZJnBQxKpExnzfMiAD5pdfFWHbaNed+K+flET8fveZgO1DKr/DfAVhlltRDiLGrNNv912bs+srL7ZkwILK2Z2b43ERGSL0qRwTU+1H5ZaVuFJuLVJKMegU5GKjLxe0E4CNnprfKa84jso303h//94gB/bfMGQggtgw8ZaXs6GBuKD9FAFxtvP90q3jKALDe53Vs/zmBDSPgy0u1lhNgHY6zk6Aspmowyk7i0aBG7FSUA8UwwbFEKIgYaku7yiRudW1djP3O6TJn81liyMbFUXZxxau8khrterqgomqA+7mfabuSj2rWzbXbe3pmCq1XWIiycbYnhyn1boCpH+fedxoxPPhyjwpAz88swidwFWrNxna1+QFYB0Q7Il+oQQ4m356jrT1TOtr1NvdqzdrMVhNg0Gfy X-OriginatorOrg: umons.ac.be X-MS-Exchange-CrossTenant-Network-Message-Id: 5e0020a5-4974-408d-4bf2-08d8097d86ba X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2020 18:23:21.0352 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 488bed9d-d6a7-48d5-ba1f-ebec3823b357 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qe0/vl3rROQLY6GBJGpSn/PZGoQiIE2twUN5Oa8l0uFOgsoUNrGyprnNr2RuBjbvzOOZ1/V1XEVxy8k2uFnBJg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR01MB4697 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181580 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, Thanks for your comments. On 5 June 2020 at 19:58 CEST, Basil L. Contovounesios wr= ote: > > The commit message conventions followed by Emacs are described in the > file CONTRIBUTE and also under (info "(emacs) Format of ChangeLog"). > It's fine to include the free-standing prose, but the commit message > should also mention the file and definition being changed, e.g.: > > * lisp/gnus/gnus-icalendar.el > (gnus-icalendar-event--build-reply-event-body): Display a warning > instead of barfing when user is missing from attendee list. Thanks, I have updated it. >> + (lwarn 'gnus :warning > ^^^^^ > Why not 'gnus-icalendar instead? I used =E2=80=9C'gnus=E2=80=9D as the umbrella but =E2=80=9C'gnus-icalendar= =E2=80=9D is fine too. Updated patch attached. Best, C. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Enable-replying-to-an-ical-event-even-when-not-an-at.patch Content-Description: Enable replying to an ical event even when not an attendee >From 46b02723e714aa0d0e740c61cc6fd7d05e426978 Mon Sep 17 00:00:00 2001 From: Christophe Troestler Date: Fri, 5 Jun 2020 17:35:48 +0200 Subject: [PATCH] Enable replying to an ical event even when not an attendee Content-Type: text/plain; charset="utf-8" * lisp/gnus/gnus-icalendar.el (gnus-icalendar-event--build-reply-event-body): Display a warning instead of barfing when user is missing from attendee list. When the user identity is not present in the attendee list, an error is triggered making replying to such an event impossible (the reply message not being even composed). This replaces it with a warning. This is necessary because one may receive events that the organizer did not set up well and it is up to the user to decide whether or not to reply to them. --- lisp/gnus/gnus-icalendar.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/gnus/gnus-icalendar.el b/lisp/gnus/gnus-icalendar.el index 305e17fd8f..29d3e30780 100644 --- a/lisp/gnus/gnus-icalendar.el +++ b/lisp/gnus/gnus-icalendar.el @@ -312,7 +312,8 @@ gnus-icalendar-event--build-reply-event-body (unless (gnus-icalendar-find-if (lambda (x) (string-match "^ATTENDEE" x)) reply-event-lines) - (error "Could not find an event attendee matching given identity")) + (lwarn 'gnus-icalendar :warning + "Could not find an event attendee matching given identity")) (mapconcat #'identity `("BEGIN:VEVENT" ,@(nreverse reply-event-lines) -- 2.26.2 --=-=-=--