Re: [PATCHv3] erc: fix erc-reuse-buffers behavior

["Mingde (Matthew) Zeng" <matthewzmd@gmail.com>]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> "Mingde (Matthew) Zeng" <matthewzmd@gmail.com> writes:
>
>> I had a look at Lars' change, that particular commit simply changes
>> target to (not target), it is not enough to fix the problem entirely
>> (as outlined in my commit message). Also, changing to (not target)
>> technically does avoid this specific problem, but imo it logically
>> doesn't make sense. When invoking `erc-generate-new-buffer-name`,
>> target is not an optional parameter and should never be nil, that line
>> is unnecessary amd therefore removed from my commit.
>
> The only usage of that function is (indirectly) from here:
>
> (defun erc-open (&optional server port nick full-name
>                            connect passwd tgt-list channel process)
>
> [...]
>
>         (buffer (erc-get-buffer-create server port channel))
>
> So I assumed that target could indeed be nil -- especially since that
> function has always checked whether target is nil or not, only that the
> previous check was reverse of what it should have been.

Okay that sounds right, I'll rebase my patch.

>
>> I have another question, since I've never contributed to Emacs
>> directly before, can you tell me is there any way to quickly find out
>> whether a bug is tracked by GNU bug reports or not?
>
> The bug tracker has a search field, if that's what you're asking?

I see, found it.

Also, is there a way to respond to a bug (i.e  https://debbugs.gnu.org/cgi/bugreport.cgi?bug=40121) without subscribing to bug-gnu-emacs? I cannot find a "Comment" button similar to a bug-tracking site like bugzilla (which is what i'm more familiar with). Really like to avoid multiple people working on the same bug in the future.

--
Mingde (Matthew) Zeng