From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#43003: 28.0.50; comint-password-prompt-regexp too restrictive Date: Thu, 27 Aug 2020 17:09:03 +0200 Message-ID: <87sgc83z3k.fsf@gmx.net> References: <87pn7hawal.fsf@gmx.net> <878se4dy9u.fsf@gnus.org> <87lfi1emz4.fsf@gmx.net> <873648xmvf.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20795"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 43003@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 27 17:11:02 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kBJYM-0005H4-4H for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 27 Aug 2020 17:11:02 +0200 Original-Received: from localhost ([::1]:54202 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kBJYK-0006GQ-Va for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 27 Aug 2020 11:11:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47054) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBJXO-0006GF-NC for bug-gnu-emacs@gnu.org; Thu, 27 Aug 2020 11:10:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60313) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kBJXO-0002nd-D3 for bug-gnu-emacs@gnu.org; Thu, 27 Aug 2020 11:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kBJXO-0007RR-6u for bug-gnu-emacs@gnu.org; Thu, 27 Aug 2020 11:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Aug 2020 15:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43003 X-GNU-PR-Package: emacs Original-Received: via spool by 43003-submit@debbugs.gnu.org id=B43003.159854095328539 (code B ref 43003); Thu, 27 Aug 2020 15:10:02 +0000 Original-Received: (at 43003) by debbugs.gnu.org; 27 Aug 2020 15:09:13 +0000 Original-Received: from localhost ([127.0.0.1]:43626 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBJWb-0007QF-G2 for submit@debbugs.gnu.org; Thu, 27 Aug 2020 11:09:13 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:56355) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBJWZ-0007Q1-1K for 43003@debbugs.gnu.org; Thu, 27 Aug 2020 11:09:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1598540945; bh=I+IOfjN2LbsAlw8wbrtg0CBiyVmrskTlPgOK594F+Bs=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=ZQDdNj6HjkplJFBwVHIRTzyqMViupZuOsRHMs/IfcxRIw1BoiOHb+EQCb2dFuMAX9 RUM7Yn8bn6aBX90nCX9f1VTSrGqLGG+dfONRt0xwBEw63lMNE2NIqNmQEF5J/Y7Jsz Sw65zmXTVol73UjleEWn8A6nXGv4XHgjYMOlHK+4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from strobe-jhalfs ([178.1.125.104]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MRmjq-1k47kQ3iqw-00TE49; Thu, 27 Aug 2020 17:09:05 +0200 In-Reply-To: <873648xmvf.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 27 Aug 2020 15:02:44 +0200") X-Provags-ID: V03:K1:TWmyOYdS5kMjLIBsgPfeD4guuttbUHsu7h2UIe/atn2CMLsZSQS cPfalZ5N6s8QO4fm568PRravIVftHUo2cuT0QCPgy7ScpFm8J8akWxXYyJstxGOurwCzG0R 5jI6y6wg1QExzBvjcoQf9jA7GVyViyBFQlp9V5Vy8Il1pIf7TdaN//6Bi0x1TxZkZQhlsZW KWMOIBVjIZVQG3Ows1rpQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:4H4Weg5urks=:iaO3MsdgTKlSAMcN4CtM1/ YlgWvGqwSFWHrBmUk+C8WLMR7XY+jBwS302f9qV46SPtFUxirqoXKssXlWgVSa4n8GSVc+blK ytx6Zkwbyaeaj3Zy0i64asG0HB1XcG/bR27X7gPSXtKxe+OgxnhY7HpZXGTR6u0/6tUprAoRn /hZSP+RtfmkfpRyombm9lArw4XPzTZ3WgeJOR4qJCaMW4liyhOABuBfgaSQCbM9N9PzIxNOKC eQBy1MjfP5oZbjqoQUPMMSD9wrpoDefdsfRDlx6c1d6Ew2zOQlMfqG0u3AEB1geTPjVoNgvvL G8FWMKZidUWW0/aXKcyt78QoGwE4NBwVnrSTreVmXJLANxF1WCOQyyOGuSKJH4JNCZgth87Hq RiOvL2y9Ehql3rHvce1gpdplNVBRXiQH8x+7i441v1Uat3TOybnjLMmpz+OqrWiHlb/VObIYM p0QOmA6BOB4dDCAz7CAraaC099U5SM1USj3bFwHcbwsKMkl2Vd60zD6hExZbfCeHnf1Ldbo2l QHF9OTHrFU++un/Vm4tVM89F39quxXjV1U/JnF11H2FV5HQR6Pd8YuGpNew6BhcH7TGNRIT1y Nwl4RiUHpwehtGdsifxWRgCielI5I3G3o/DSddwkv500v7B1Tg2E8n64AtiAK77UObwWqbCU0 IlsCeREGO8wh2J1mUvx3BXwDGYPOYr3+1Rj/X2KnmqJ06VpphgLj7ic9QSDD+AgPy+0ef3xBm Ymk6IobesTvdqvcxG8HY3T42BK0RVvbFoki2+LNyAUz1Fvy4Dts3Z7jQTyUCrfWXI7jY4iUw X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:186543 Archived-At: On Thu, 27 Aug 2020 15:02:44 +0200 Lars Ingebrigtsen wrot= e: > Stephen Berman writes: > >> The minimal change to fix my use case is to add the carriage return >> character as an alternative to comint-password-prompt-regexp, as in the >> attached patch. If even that is too risky, I'll just stick with a loca= l >> fix. >> >> Steve >> >> diff --git a/lisp/comint.el b/lisp/comint.el >> index 092902d865..b6098f449d 100644 >> --- a/lisp/comint.el >> +++ b/lisp/comint.el >> @@ -365,7 +365,7 @@ comint-process-echoes >> ;; See ert test `comint-test-password-regexp'. >> (defcustom comint-password-prompt-regexp >> (concat >> - "\\(^ *\\|" >> + "\\(^ *\\|" >> (regexp-opt >> '("Enter" "enter" "Enter same" "enter same" "Enter the" "enter the= " >> "Enter Auth" "enter auth" "Old" "old" "New" "new" "'s" "login" > > I don't quite understand how this patch helps -- doesn't this just > require a ^M character before Enter/Old/etc? Did you mean > >> + "\\(^ *\\|\\|" (It looks like Gnus removed the ^M characters.) Yes, I just tested again and the password is indeed hidden only when `\\|' follows `^M' in the regexp. Apparently I omitted that when I made the diff for the patch after testing yesterday... Steve Berman