bug#44021: delete-non-matching-lines optional arg REND not really optional

bug#44021: delete-non-matching-lines optional arg REND not really optional

[Boruch Baum]

Unlike other functions with optional BEG and END args, where END is
presumed to be (point-max) if not supplied, function
delete-non-matching-lines returns an error when only RBEG is supplied.

Error: (wrong-type-argument number-or-marker-p nil)

--
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0

bug#44021: delete-non-matching-lines optional arg REND not really optional

[Lars Ingebrigtsen]

Boruch Baum <boruch_baum@gmx.com> writes:

> Unlike other functions with optional BEG and END args, where END is
> presumed to be (point-max) if not supplied, function
> delete-non-matching-lines returns an error when only RBEG is supplied.
>
> Error: (wrong-type-argument number-or-marker-p nil)

I've now mentioned this in the doc string.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#44021: delete-non-matching-lines optional arg REND not really optional

[Boruch Baum]

On 2020-10-16 07:36, Lars Ingebrigtsen wrote:
> I've now mentioned this in the doc string.

Not the solution I was expecting. I was expecting the ARG to really
become optional, to be consistent with similar END arguments in other
emacs functions. Something like:

  (setq rend (or rend (point-max)))

Also, as a quibble, for consistency the args should be renamed START and
END, instead of RSTART and REND. See, for instance,

  (delete-trailing-whitespace &optional START END)
  (narrow-to-region START END)

This is true even in the same elisp file replace.el:

  (replace-regexp regexp to-string &optional delimited start end backward)
  (replace-string from-string to-string &optional delimited start end backward)

and many other functions in the same file, so it seems to have been an
oversight in integrating the function. The standard seems to be that the
args are named START and END and really are optional.

--
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0