From: Lars Ingebrigtsen <larsi@gnus.org>
To: Paul Pogonyshev <pogonyshev@gmail.com>
Cc: 41065@debbugs.gnu.org
Subject: bug#41065: (no subject)
Date: Tue, 27 Oct 2020 09:47:07 +0100 [thread overview]
Message-ID: <87sga0qcms.fsf@gnus.org> (raw)
In-Reply-To: <CAG7BpapBS=ryOLX11eCsBcwhU-SAVfv5S1n=e2OyhEDTPGrk-Q@mail.gmail.com> (Paul Pogonyshev's message of "Tue, 27 Oct 2020 01:10:58 +0100")
Paul Pogonyshev <pogonyshev@gmail.com> writes:
> Subject: [PATCH] Don't leak result of nested byte-compilation to outer level
> (bug#41065)
[...]
> + byte-compile-dest-file byte-compiler-error-flag)
> (setq target-file (byte-compile-dest-file filename))
> (setq byte-compile-dest-file target-file)
> (with-current-buffer
> @@ -2000,7 +2000,6 @@ byte-compile-file
> 'no-byte-compile)
> (when byte-compile-verbose
> (message "Compiling %s..." filename))
> - (setq byte-compiler-error-flag nil)
Thanks; applied to Emacs 28. I tried to follow the code paths where
this variable is used, and as far as I can tell, this should be safe.
The old code was rather odd, because there's just a
(defvar byte-compiler-error-flag)
in the file -- it's not actually defined, but after compiling something,
that `setq' would define it globally. So your patch fixes that problem,
too.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2020-10-27 8:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-03 22:21 bug#41065: Result of byte-compilation can be nil even if the compiled file contains no errors Paul Pogonyshev
2020-10-27 0:10 ` bug#41065: PATCH Paul Pogonyshev
2020-10-27 8:47 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sga0qcms.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=41065@debbugs.gnu.org \
--cc=pogonyshev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.