From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#44341: 27.1; define-minor-mode generates inaccurate docstring Date: Sun, 01 Nov 2020 15:00:50 +0100 Message-ID: <87sg9tb2i5.fsf@gnus.org> References: <87361u64oo.fsf@thb.lt> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14467"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 44341@debbugs.gnu.org To: Thibault Polge Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 01 15:02:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kZDvv-0003fJ-Jp for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 01 Nov 2020 15:02:11 +0100 Original-Received: from localhost ([::1]:54594 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZDvu-0001MB-EH for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 01 Nov 2020 09:02:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40922) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZDvm-0001LU-4a for bug-gnu-emacs@gnu.org; Sun, 01 Nov 2020 09:02:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52720) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kZDvl-0005XC-PN for bug-gnu-emacs@gnu.org; Sun, 01 Nov 2020 09:02:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kZDvl-0003Gn-Lt for bug-gnu-emacs@gnu.org; Sun, 01 Nov 2020 09:02:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Nov 2020 14:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44341 X-GNU-PR-Package: emacs Original-Received: via spool by 44341-submit@debbugs.gnu.org id=B44341.160423927112496 (code B ref 44341); Sun, 01 Nov 2020 14:02:01 +0000 Original-Received: (at 44341) by debbugs.gnu.org; 1 Nov 2020 14:01:11 +0000 Original-Received: from localhost ([127.0.0.1]:36028 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZDuw-0003FU-LP for submit@debbugs.gnu.org; Sun, 01 Nov 2020 09:01:10 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:34572) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZDuu-0003FG-7P for 44341@debbugs.gnu.org; Sun, 01 Nov 2020 09:01:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ef58ZGMwke7OoOLg9J2OjPVtdlp5B1GOGaaILyD02+w=; b=dBIvN1Y1SCbE5BwDsOEaPvNv3e o2Vj2oupBzKLAK9WU/rHPTzCrtkf3tjuSkMegRjKWnUnXvX2lq7A+5eEEqTgLVgA3X1Y86sUWivsl SCbRwG0lu1p1PGn9Age0Ou8dvToWrM+f/74MPR1hbt/XVkgog36433bXL/gM170xDlJ0=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kZDud-0000lR-NT; Sun, 01 Nov 2020 15:01:01 +0100 X-Now-Playing: Blaine Reiniger's _Songs From The Rain Palace_: "Song For J.J. " In-Reply-To: <87361u64oo.fsf@thb.lt> (Thibault Polge's message of "Sat, 31 Oct 2020 12:00:23 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192375 Archived-At: Thibault Polge writes: >> If called from Lisp, also enable the mode if ARG is omitted or nil, >> and toggle it if ARG is =E2=80=98toggle=E2=80=99; disable the mode other= wise. > > This case (non-interactively, enable the mode if ARG is non-nil, unless > it's toggle) doesn't seem to have been implemented. Here's a test that > demonstrates that: > > (mapcar > (lambda (x) (test-mode x) (cons x test-mode)) > '(t ; Should disable. > nil ; Should disable > -33 ; Should NOT disable (but will) > 33 ; Should enable > 0 ; Should disable > toggle ;=E2=80=AFShould toggle, and will. > toggle ;=E2=80=AFRepeated for confirmation > disable ; Should disable (as a random symbol) > disable ; Again > "What?" ; Same. > )) I think there's bugs here both in the doc string and in the implementation: A negative number should switch the mode off, so the code works correctly there (but not according to documentation). Is this a typo? > nil ; Should disable because nil should enable (as documented), and does. The other values that enables (but should disable) you note are correct. I mean, it's correct that the current implementation is incorrect, and I've now pushed a fixed for this to the trunk. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no