From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 44338@debbugs.gnu.org, Nicholas Harrison <nicholasharrison222@gmail.com>
Subject: bug#44338: 27.1; EWW can't download and view pdf
Date: Thu, 05 Nov 2020 21:25:15 +0000 [thread overview]
Message-ID: <87sg9nzebo.fsf@tcd.ie> (raw)
In-Reply-To: <87361nsfjm.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 05 Nov 2020 21:40:45 +0100")
[-- Attachment #1: Type: text/plain, Size: 681 bytes --]
tags 44338 fixed
close 44338 28.1
quit
Lars Ingebrigtsen <larsi@gnus.org> writes:
> "Basil L. Contovounesios" <contovob@tcd.ie> writes:
>
>> In other words, can we remove the binding altogether from
>> eww-display-pdf and make the *eww pdf* buffer unibyte, as Stefan
>> suggested?
>
> Yes, this is the correct fix.
Thanks, done.
Fix coding system in eww-display-pdf
4610241a9b 2020-11-05 21:06:39 +0000
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=4610241a9b3fbddd1f0973bf49f7008ed09ab955
I'm therefore marking this bug as fixed in 28.1.
Nicholas, here's the cumulative change to the function eww-display-pdf,
in case you want to patch/advise yours on Emacs 27.1:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: eww.diff --]
[-- Type: text/x-diff, Size: 1157 bytes --]
diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index d6f850ca3b..43405fbd9c 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -667,14 +811,19 @@ eww-display-image
(declare-function mailcap-view-mime "mailcap" (type))
(defun eww-display-pdf ()
- (let ((data (buffer-substring (point) (point-max))))
- (pop-to-buffer-same-window (get-buffer-create "*eww pdf*"))
- (let ((coding-system-for-write 'raw-text)
- (inhibit-read-only t))
- (erase-buffer)
- (insert data)
- (mailcap-view-mime "application/pdf")))
- (goto-char (point-min)))
+ (let ((buf (current-buffer))
+ (pos (point)))
+ (with-current-buffer (get-buffer-create "*eww pdf*")
+ (let ((inhibit-read-only t))
+ (erase-buffer)
+ (set-buffer-multibyte nil)
+ (insert-buffer-substring buf pos)
+ (mailcap-view-mime "application/pdf"))
+ (if (zerop (buffer-size))
+ ;; Buffer contents passed to shell command via temporary file.
+ (kill-buffer)
+ (goto-char (point-min))
+ (pop-to-buffer-same-window (current-buffer))))))
(defun eww-setup-buffer ()
(when (or (plist-get eww-data :url)
[-- Attachment #3: Type: text/plain, Size: 11 bytes --]
--
Basil
next prev parent reply other threads:[~2020-11-05 21:25 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 22:20 bug#44338: 27.1; EWW can't download and view pdf Nicholas Harrison
2020-10-31 13:43 ` Basil L. Contovounesios
2020-10-31 16:35 ` Jean Louis
2020-10-31 17:14 ` Nicholas Harrison
2020-10-31 23:16 ` Nicholas Harrison
2020-11-01 14:56 ` Basil L. Contovounesios
2020-11-03 23:24 ` Basil L. Contovounesios
2020-11-05 15:13 ` Lars Ingebrigtsen
2020-11-05 17:37 ` Basil L. Contovounesios
2020-11-01 14:20 ` Lars Ingebrigtsen
2020-11-01 14:59 ` Basil L. Contovounesios
2020-11-02 14:59 ` Lars Ingebrigtsen
2020-11-02 16:50 ` Basil L. Contovounesios
2020-11-03 14:49 ` Lars Ingebrigtsen
2020-11-03 21:28 ` Basil L. Contovounesios
2020-11-05 15:12 ` Lars Ingebrigtsen
2020-11-05 17:36 ` Basil L. Contovounesios
2020-11-05 20:40 ` Basil L. Contovounesios
2020-11-03 23:52 ` Nicholas Harrison
2020-11-04 0:23 ` Basil L. Contovounesios
2020-11-04 1:01 ` Nicholas Harrison
2020-11-04 15:10 ` Eli Zaretskii
2020-11-04 0:25 ` Basil L. Contovounesios
2020-11-04 15:07 ` Eli Zaretskii
2020-11-04 20:01 ` Basil L. Contovounesios
2020-11-04 23:43 ` Nicholas Harrison
2020-11-05 13:42 ` Eli Zaretskii
2020-11-05 13:42 ` Eli Zaretskii
2020-11-05 15:18 ` Nicholas Harrison
2020-11-05 15:49 ` Eli Zaretskii
2020-11-05 17:52 ` Nicholas Harrison
2020-11-05 17:55 ` Eli Zaretskii
2020-11-05 19:04 ` Basil L. Contovounesios
2020-11-05 19:20 ` Eli Zaretskii
2020-11-05 21:17 ` Basil L. Contovounesios
2020-11-06 5:29 ` Eli Zaretskii
2020-11-05 20:40 ` Lars Ingebrigtsen
2020-11-05 21:25 ` Basil L. Contovounesios [this message]
2020-11-06 2:12 ` Nicholas Harrison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sg9nzebo.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=44338@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=nicholasharrison222@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.