From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#29193: 26.0.90; Using (thing-at-point 'sexp) in flymake-diag-region might be suboptimal Date: Sat, 12 Dec 2020 12:39:16 +0100 Message-ID: <87sg8b5k4b.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16986"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 29193@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 12 19:56:38 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1koA4M-0004KJ-04 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 12 Dec 2020 19:56:38 +0100 Original-Received: from localhost ([::1]:48550 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1koA4K-0001Np-Tn for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 12 Dec 2020 13:56:37 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38372) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ko9ky-0006KD-SC for bug-gnu-emacs@gnu.org; Sat, 12 Dec 2020 13:36:36 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34911) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ko9ky-0008Iy-Cp for bug-gnu-emacs@gnu.org; Sat, 12 Dec 2020 13:36:36 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ko3Fp-0003FS-Tk for bug-gnu-emacs@gnu.org; Sat, 12 Dec 2020 06:40:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 Dec 2020 11:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29193 X-GNU-PR-Package: emacs Original-Received: via spool by 29193-submit@debbugs.gnu.org id=B29193.160777316912438 (code B ref 29193); Sat, 12 Dec 2020 11:40:01 +0000 Original-Received: (at 29193) by debbugs.gnu.org; 12 Dec 2020 11:39:29 +0000 Original-Received: from localhost ([127.0.0.1]:44072 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ko3FI-0003EY-P7 for submit@debbugs.gnu.org; Sat, 12 Dec 2020 06:39:29 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:46040) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ko3FG-0003EK-14 for 29193@debbugs.gnu.org; Sat, 12 Dec 2020 06:39:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=IzX19bzlZHAHAW8Cv7E7lFu3vTRN8pcvNAuGzQzbY0o=; b=PgO3mgsb9TpmbAzIqg/rKdQ9ck ZSfWMzOrVa8QaaU+mruP6SElkhVUsTsu1trjwYPA4o6pYImS91v77RP5JT8KBnH5qtcVcCOZKYdE2 Rasg3pddXxQwdiNBCGrETO1+u1S09ZzmO2PXJzz9si7cnfe9MSyoum3lSqddplcjBViY=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ko3F7-0005A8-HD; Sat, 12 Dec 2020 12:39:20 +0100 X-Now-Playing: Sacred Paws's _Run Around The Sun_: "Shame On Me" In-Reply-To: (Dmitry Gutov's message of "Tue, 7 Nov 2017 17:28:06 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:195854 Archived-At: Dmitry Gutov writes: > Rubocop can report warning when 'end' is at wrong column. It just > reports the beginning column, of course. > > In ruby-mode, (thing-at-point 'sexp) signals an error at this position. > I'm not sure exactly whether it's a problem in ruby-mode. > > But Flycheck uses (thing-at-poing 'symbol) for the same purpose, and the > whole 'end' token gets highlighted (which is probably what we expect). > > In contrast, Flymake only highlights its first character ('e'). I had a look at the current `flymake-diag-region', and it does not use (thing-at-point 'sexp) at present. It does use (end-of-thing 'sexp), though. So is this problem still present? There was no recipe for reproduction, so it's not immediately clear. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no