From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#45650: 28.0.50; nnmaildir discards line count Date: Mon, 04 Jan 2021 10:44:31 +0100 Message-ID: <87sg7h594w.fsf@gnus.org> References: <87ft3hhzb3.fsf@uibk.ac.at> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27437"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 45650@debbugs.gnu.org To: Justus-dev@Piater.name Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 04 10:56:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kwMaz-00070A-AY for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 04 Jan 2021 10:56:13 +0100 Original-Received: from localhost ([::1]:35038 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kwMay-00060i-9Q for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 04 Jan 2021 04:56:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43436) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kwMap-0005yp-3Z for bug-gnu-emacs@gnu.org; Mon, 04 Jan 2021 04:56:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43468) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kwMao-0003Ce-RW for bug-gnu-emacs@gnu.org; Mon, 04 Jan 2021 04:56:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kwMao-0002ys-MD; Mon, 04 Jan 2021 04:56:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Mon, 04 Jan 2021 09:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45650 X-GNU-PR-Package: emacs,gnus Original-Received: via spool by 45650-submit@debbugs.gnu.org id=B45650.160975415711432 (code B ref 45650); Mon, 04 Jan 2021 09:56:02 +0000 Original-Received: (at 45650) by debbugs.gnu.org; 4 Jan 2021 09:55:57 +0000 Original-Received: from localhost ([127.0.0.1]:55003 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwMaa-0002xd-6y for submit@debbugs.gnu.org; Mon, 04 Jan 2021 04:55:56 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:57844) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwMPq-0002GJ-9B for 45650@debbugs.gnu.org; Mon, 04 Jan 2021 04:45:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vKONy1gFMYbFfZ6bDFAzDY0aChf5iYbwfFwfouTm1zs=; b=ToFePsL3IJTBkdekwbv6me5tsb woxt1/e0xz9JoGYzW8OOkj4xeCP9jpRFTpmsbIlcYrmGavE1bqaPuQmQVbLIMQKQ7bGoIEB8fGqqN VkCs7XR+HwLUwTuUaQwaKzirm2gm+3EDe6BkIs6vrP0KMC2gF9YpbpD02GCCcz5HdKqU=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kwMPh-0001om-CX; Mon, 04 Jan 2021 10:44:35 +0100 X-Now-Playing: Can Can's _En lek i forhold_: "Oppenheimer" In-Reply-To: <87ft3hhzb3.fsf@uibk.ac.at> (Justus-dev@piater.name's message of "Mon, 04 Jan 2021 09:38:24 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:197295 Archived-At: Justus-dev@Piater.name writes: > This code assumes that if no Lines: header is found, mail-header-lines > returns 0. However, mail-header-lines returns -1 in this case, causing > the correctly-counted number of lines in nov-mid to be overwritten with > -1. > > Replacing (zerop field) by (<= field 0) fixes it. > > While I think this is indeed a correct immediate fix, That's a very confusing function, but this does indeed seem to be the correct fix here, and I've now done as you suggested in Emacs 28. > this function should be refactored: > > - Why count the number of lines in the message only to discard the > result if a Lines: header is found afterwards? (Well, fixing this > won't have much impact: Of the 161594 messages in my nnmaildir > folders, only 2982 contain a Lines: header.) > > - [unrelated] Above the quoted code section, the function checks if the > NOV data have to be (re)created by parsing the message; if not, it > raises an exception to return early. This construct should be > replaced by a conditional, perhaps splitting out the second half into > its own function for readability. Both things seem reasonable, so if somebody wants to do that (or rewrite that function to be less confusing in general), I'm all for it. But as your change fixes this bug, I'm closing this bug report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no