From: Robert Pluim <rpluim@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Phillip Lord <phillip.lord@russet.org.uk>, 45771@debbugs.gnu.org
Subject: bug#45771: 28.0.50; GMP not showing in system-configuration-feature
Date: Mon, 11 Jan 2021 13:28:31 +0100 [thread overview]
Message-ID: <87sg77d5e8.fsf@gmail.com> (raw)
In-Reply-To: <83v9c4fye6.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 10 Jan 2021 20:19:13 +0200")
tags 45771 fixed
close 45771 28.1
quit
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Phillip Lord <phillip.lord@russet.org.uk>
>> Date: Sun, 10 Jan 2021 18:08:43 +0000
>>
>> The string "GMP" is not showing in system-configuration-feature on Emacs
>> master branch, even when libgmp has been configured and is reported to
>> be in use by configure. Confirmed on builds on both Ubuntu and
>> Windows.
>
> I think this is because:
>
> for opt in XAW3D XPM JPEG TIFF GIF PNG RSVG CAIRO IMAGEMAGICK SOUND GPM DBUS \
> GCONF GSETTINGS GLIB NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT \
> LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS X_TOOLKIT OLDXMENU X11 XDBE XIM \
> NS MODULES THREADS XWIDGETS LIBSYSTEMD JSON PDUMPER UNEXEC LCMS2 GMP; do
>
> case $opt in
> PDUMPER) val=${with_pdumper} ;;
> UNEXEC) val=${with_unexec} ;;
> GLIB) val=${emacs_cv_links_glib} ;;
> NOTIFY|ACL) eval val=\${${opt}_SUMMARY} ;;
> TOOLKIT_SCROLL_BARS|X_TOOLKIT) eval val=\${USE_$opt} ;;
> THREADS) val=${threads_enabled} ;;
> *) eval val=\${HAVE_$opt} ;;
> esac
>
> but we set HAVE_GMP only afterwards:
>
> if test -z "$GMP_H"; then
> HAVE_GMP=yes
> else
> HAVE_GMP=no
> fi
>
> We need to move the latter before the former.
>
Done in 62e3750af3
Closing.
Robert
next prev parent reply other threads:[~2021-01-11 12:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-10 18:08 bug#45771: 28.0.50; GMP not showing in system-configuration-feature Phillip Lord
2021-01-10 18:19 ` Eli Zaretskii
2021-01-11 12:28 ` Robert Pluim [this message]
2021-01-11 15:31 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sg77d5e8.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=45771@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=phillip.lord@russet.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.