From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: jakanakaevangeli Newsgroups: gmane.emacs.devel Subject: Re: Stop frames stealing eachothers' minibuffers! Date: Mon, 08 Feb 2021 13:53:43 +0100 Message-ID: <87sg6690vc.fsf@miha-pc> References: <87wnvkixrv.fsf@miha-pc> <874kinakv2.fsf@miha-pc> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19108"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Feb 08 19:54:15 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l9Bfr-0004re-Fq for ged-emacs-devel@m.gmane-mx.org; Mon, 08 Feb 2021 19:54:15 +0100 Original-Received: from localhost ([::1]:47040 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9Bfo-0004SC-LW for ged-emacs-devel@m.gmane-mx.org; Mon, 08 Feb 2021 13:54:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35686) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l95zJ-0004xw-HQ for emacs-devel@gnu.org; Mon, 08 Feb 2021 07:49:57 -0500 Original-Received: from chiru.no ([142.4.209.132]:51602) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1l95zH-00020K-Fo for emacs-devel@gnu.org; Mon, 08 Feb 2021 07:49:57 -0500 Original-Received: from localhost (BSN-77-156-43.static.siol.net [193.77.156.43]) by chiru.no (Postfix) with ESMTPSA id 82A4E128001C; Mon, 8 Feb 2021 12:49:53 +0000 (UTC) In-Reply-To: Received-SPF: none client-ip=142.4.209.132; envelope-from=jakanakaevangeli@chiru.no; helo=chiru.no X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:264169 Archived-At: Alan Mackenzie writes: > Hello jakanakaevangeli. Hello > I spent some time boring into the doc string and the description in the > Elisp manual. The only conclusion I could come to was that C-] is meant > to abort EXACTLY ONE level. > > So I have tweaked the C sources once more and come up with the following > patch. It should apply to the Emacs state after yesterday's patch. > Please remove the patch from earlier today before you try to apply the > new patch. Thanks! During testing, I didn't encounter any problems related to your latest patch so you hard work paid off. Sadly, I did encounter 2 additional minibuffer issues which aren't related to your latest two patches, that is, they are present regardless if these patches are applied or not. I'm posting them here since they are still possibly related to the new minibuffer frame-following functionality. 1) With minibuffer-follows-selected-frame set to t (the default value): - press M-x on frame A - select frame B (the minibuffer will move to this frame) - C-x o, to select the minibuffer - C-g to quit it Miniwindow stays selected and its buffer is *Minibuf-1* instead of *Minibuf-0*. You can check this by evaluating (minibuffer-window). 2) With minibuffer-follows-selected-frame set to nil: - (setq set enable-recursive-minibuffers t) - (minibuffer-depth-indicate-mode 1) - select frame A and press M-x - select frame B and press M-x - select frame A and close it - select frame B and quit its minibuffer with C-g. This doesn't quit the outer minibuffer, as expected, but this minibuffer isn't shown anywhere and the only reasonable way to quit it is with C-], which, I believe, a lot of users don't know about (at least I personally didn't until quite recently). You can check this with (minibuffer-depth).