From: Michael Albinus <michael.albinus@gmx.de>
To: Jason Kim <jason.w.kim@icloud.com>
Cc: jason.kim@revtera.com, shivers@cs.cmu.edu, emacs-devel@gnu.org
Subject: Re: Small shell-mode patch to handle auto-cd (e.g. shells like zsh)
Date: Thu, 06 May 2021 10:10:06 +0200 [thread overview]
Message-ID: <87sg30471d.fsf@gmx.de> (raw)
In-Reply-To: <b83ee8b3-0889-0796-e5f0-f18fcb8701b4@icloud.com> (Jason Kim's message of "Wed, 5 May 2021 12:55:07 -0700")
Jason Kim <jason.w.kim@icloud.com> writes:
Hi Jason,
> Hi, Please find enclosed a small patch against emacs-lisp (packaged
> with emacs 26.3 on recent emacsen on recent ubuntu (20.4.0.2 ?)
Thanks for this proposal. I don't use shell-process-cd myself, at least
not explicitly, but I have some few comments:
+(defvar shell-has-auto-cd nil
+ "if set to true, shell-mode assumes that a command that resolves to a directory
+is an implicit cd command. Useful for shells like zsh that has this feature.")
- The docstring must be a complete sentence in the first line, starting
with a capital letter, and finishing with a period. The separator
between two sentences are newline or two (!) spaces. See the emacs
documentation standards (info "(elisp) Documentation Tips")
- I suppose you want to let people change this. So it should be rather a
defcustom but a defvar.
- The initial value could be more intelligent. Instead of using nil, you
might check the used shell file name whether it matches, for example,
"zsh$".
- Several different shells could be used in an Emacs session, depending
where you run the shell, locally or on a remote host. So it might be
problematic to have just one fixed global value.
> Thank you
> -Jason
Best regards, Michael.
next prev parent reply other threads:[~2021-05-06 8:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 19:55 Small shell-mode patch to handle auto-cd (e.g. shells like zsh) Jason Kim
2021-05-06 8:10 ` Michael Albinus [this message]
2021-05-06 8:23 ` Eli Zaretskii
2021-05-07 16:35 ` Jason Kim
2021-05-07 16:51 ` Jason Kim
2021-05-15 8:20 ` Eli Zaretskii
2021-05-24 17:15 ` Jason Kim
2021-05-24 17:20 ` Jason Kim
2021-05-25 7:38 ` Michael Albinus
2021-05-27 17:09 ` Jason Kim
2021-06-09 11:03 ` Michael Albinus
2021-05-07 17:39 ` Michael Albinus
2021-05-08 6:36 ` Eli Zaretskii
2021-05-08 16:39 ` Jason Kim
2021-05-08 16:48 ` Eli Zaretskii
2021-05-08 17:19 ` Jason Kim
2021-05-08 17:58 ` Jason Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sg30471d.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=emacs-devel@gnu.org \
--cc=jason.kim@revtera.com \
--cc=jason.w.kim@icloud.com \
--cc=shivers@cs.cmu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.