From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#46055: [PATCH] Add rust lang to etags Date: Mon, 17 May 2021 17:23:44 +0200 Message-ID: <87sg2lidtr.fsf@gnus.org> References: <20210125143344.21837-1-contact@parouby.fr> <87im4fvfye.fsf@tucano.isti.cnr.it> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40306"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Stefan Kangas , Pierre-Antoine Rouby , 46055@debbugs.gnu.org To: Francesco =?UTF-8?Q?Potort=C3=AC?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 17 17:24:24 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lif6S-000A8U-VI for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 17 May 2021 17:24:20 +0200 Original-Received: from localhost ([::1]:54388 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lif6S-0002XS-1Y for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 17 May 2021 11:24:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44036) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lif6B-0002Uq-Lx for bug-gnu-emacs@gnu.org; Mon, 17 May 2021 11:24:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41998) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lif6A-0001Bv-1j for bug-gnu-emacs@gnu.org; Mon, 17 May 2021 11:24:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lif69-0002ms-R0 for bug-gnu-emacs@gnu.org; Mon, 17 May 2021 11:24:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 17 May 2021 15:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46055 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 46055-submit@debbugs.gnu.org id=B46055.162126504110703 (code B ref 46055); Mon, 17 May 2021 15:24:01 +0000 Original-Received: (at 46055) by debbugs.gnu.org; 17 May 2021 15:24:01 +0000 Original-Received: from localhost ([127.0.0.1]:53541 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lif65-0002mO-Jr for submit@debbugs.gnu.org; Mon, 17 May 2021 11:24:01 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:58786) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lif60-0002m5-Rh for 46055@debbugs.gnu.org; Mon, 17 May 2021 11:23:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=f2VhUz+t6XTtspNLZKf7VdbC71HMculFR0gI2zc3uGA=; b=qvPq1cblAknRjSNp9bjHiD1BFD dax4Q+ja/cZCQI9NdvK0RMSGU2pdQNUjKcLR7g/3cKSpydxWH5iGyqmHnHblMyW4OThK1bJW29nPR 2IX3golI08rNLvEMsqulss+OUHCnwtVOdtSwbwe3/hz30Mg9Xnv/SiMeRYsL+Nf2NozQ=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lif5s-0000rn-It; Mon, 17 May 2021 17:23:46 +0200 X-Now-Playing: d'Eon's _LP_: "Transparency Pt. IV" In-Reply-To: <87im4fvfye.fsf@tucano.isti.cnr.it> ("Francesco =?UTF-8?Q?Potort=C3=AC?="'s message of "Wed, 21 Apr 2021 17:02:17 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:206721 Archived-At: Francesco Potort=C3=AC writes: >>I have one question, though. In "test/manual/etags", we have manual >>tests for etags including source code examples and which tags they >>should generate. Should we add a manual test also for Rust? > > I'd say definitely yes. Ideally, the regression tests should be updated > every time a new feature is added or a bug is corrected. I looked into adding a Rust test there... but it's unclear how, or what it's checking. A "make check" in that directory fails. I looked in admin/* for an explanation of what's supposed to be done in test/manual/etags, but found nothing. Perhaps a README should be added to that directory to explain how to use it? --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no