From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.bugs Subject: bug#22763: 25.1.50; Feature Request -- A faster method to obtain line number at position. Date: Thu, 20 May 2021 09:27:34 +0200 Message-ID: <87sg2hyie1.fsf@igel.home> References: <83cztlq4wq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7854"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) Cc: Ben Levy , 22763@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 20 09:28:16 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ljd6O-0001rL-5H for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 May 2021 09:28:16 +0200 Original-Received: from localhost ([::1]:55270 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ljd6M-00028I-HX for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 May 2021 03:28:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36110) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljd6A-000286-Kf for bug-gnu-emacs@gnu.org; Thu, 20 May 2021 03:28:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49706) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ljd6A-000549-As for bug-gnu-emacs@gnu.org; Thu, 20 May 2021 03:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ljd6A-0002Aq-66 for bug-gnu-emacs@gnu.org; Thu, 20 May 2021 03:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 May 2021 07:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22763 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 22763-submit@debbugs.gnu.org id=B22763.16214956758341 (code B ref 22763); Thu, 20 May 2021 07:28:02 +0000 Original-Received: (at 22763) by debbugs.gnu.org; 20 May 2021 07:27:55 +0000 Original-Received: from localhost ([127.0.0.1]:33019 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ljd62-0002AS-Pe for submit@debbugs.gnu.org; Thu, 20 May 2021 03:27:55 -0400 Original-Received: from mail-out.m-online.net ([212.18.0.10]:33488) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ljd5l-00029w-V0 for 22763@debbugs.gnu.org; Thu, 20 May 2021 03:27:53 -0400 Original-Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4Fm1Xm3QhBz1s6R3; Thu, 20 May 2021 09:27:36 +0200 (CEST) Original-Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4Fm1Xm0lhTz1qsZB; Thu, 20 May 2021 09:27:36 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Original-Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id KaE9BtmW1stF; Thu, 20 May 2021 09:27:35 +0200 (CEST) X-Auth-Info: 7+oOtlFYjpZrEkQ7hbMmvcZtjcZaS5mQr+LksWMXRQ5VAup9qb1VRVtChqPUG+E7 Original-Received: from igel.home (ppp-46-244-177-18.dynamic.mnet-online.de [46.244.177.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Thu, 20 May 2021 09:27:35 +0200 (CEST) Original-Received: by igel.home (Postfix, from userid 1000) id 90B6A2C35F1; Thu, 20 May 2021 09:27:34 +0200 (CEST) X-Yow: YOW!! I am having FUN!! In-Reply-To: <83cztlq4wq.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 20 May 2021 09:45:57 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:206926 Archived-At: On Mai 20 2021, Eli Zaretskii wrote: >> Date: Wed, 19 May 2021 23:55:27 +0000 >> From: Ben Levy via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> For this section in the line-number-at-pos code: >> >> /* Check that POSITION is n the visible range of the buffer. */ >> if (pos < BEGV || pos > ZV) >> args_out_of_range (make_int (start), make_int (ZV)); >> >> Shouldn't the lower bound condition be pos < start instead of pos < BEGV? > > No, because 'start' is the _byte_ position, But it should not be passed to args_out_of_range then. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."