From: Gustavo Barros <gusbrs.2016@gmail.com>
To: Bhavin Gandhi <bhavin7392@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug: Double trailing slash for default candidate in org-refile-get-target [9.4 (9.4-7-g3eccc5-elpaplus @ /home/gustavo/.emacs.d/elpa/org-plus-contrib-20200921/)]
Date: Sun, 23 May 2021 15:58:47 -0300 [thread overview]
Message-ID: <87sg2ds2e0.fsf@gmail.com> (raw)
In-Reply-To: <CAOn=hbe4q7Ym2ApNH5zKd1E3MBNHHY8yr-33mi0xqQEWdnJ+_A@mail.gmail.com>
Hi Bhavin,
On Sun, 23 May 2021 at 15:05, Bhavin Gandhi <bhavin7392@gmail.com>
wrote:
> Finally after spending a couple of hours, I was able to understand the
> code
> of org-refile-get-location \o/. The detailed bug report helped me to
> understand the issue. I'm attaching a patch here which should fix the
> problem, it has other details as well. I have tested a few basic
> scenarios
> as mentioned in the report.
Thank you very much for working on this patch. I couldn't offer it
myself (out of my legal bounds) and had gone as far as I was allowed to
here, so I'm happy you took it from there.
The patch looks good to me, and corresponds to my analysis of the
problem and suggested fix. I have only one minor nitpick: you could go
with a simple `let' there, instead of a `let*', since we only have one
let-bound variable there anyway.
About:
> [...] it has other details as well.
As far as I could see, we are very much aligned on the problem and fix.
But perhaps I'm missing something, could you elaborate on that?
Thanks again.
Best,
Gustavo.
next prev parent reply other threads:[~2021-05-23 18:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 18:04 Bug: Double trailing slash for default candidate in org-refile-get-target [9.4 (9.4-7-g3eccc5-elpaplus @ /home/gustavo/.emacs.d/elpa/org-plus-contrib-20200921/)] Bhavin Gandhi
2021-05-23 18:05 ` Bhavin Gandhi
2021-05-23 18:23 ` Timothy
2021-05-23 18:58 ` Gustavo Barros [this message]
2021-05-24 16:34 ` Bhavin Gandhi
2021-05-24 16:58 ` Gustavo Barros
2021-05-25 17:52 ` [PATCH] org-refile: Fix double slashes in the refile targets Bhavin Gandhi
-- strict thread matches above, loose matches on Subject: below --
2020-09-21 18:34 Bug: Double trailing slash for default candidate in org-refile-get-target [9.4 (9.4-7-g3eccc5-elpaplus @ /home/gustavo/.emacs.d/elpa/org-plus-contrib-20200921/)] Gustavo Barros
2020-09-23 14:17 ` stardiviner
2020-09-23 14:49 ` Gustavo Barros
2021-02-14 12:55 ` Gustavo Barros
2021-05-04 6:27 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sg2ds2e0.fsf@gmail.com \
--to=gusbrs.2016@gmail.com \
--cc=bhavin7392@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.