From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Trey Peacock Newsgroups: gmane.emacs.bugs Subject: bug#49341: 28.0.50; bookmark--unfontify with nil filename throws wrong-type error Date: Sun, 04 Jul 2021 16:31:13 +0000 Message-ID: <87sg0uvy63.fsf@treypeacock.com> References: <87lf6omnkh.fsf@treypeacock.com> <83y2aohqth.fsf@gnu.org> <877di77ted.fsf@treypeacock.com> <87zgv22ndi.fsf@gnus.org> Reply-To: Trey Peacock Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23023"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Boruch Baum , 49341@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 04 18:32:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m052O-0005oR-Cj for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Jul 2021 18:32:08 +0200 Original-Received: from localhost ([::1]:51190 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m052N-0006AV-EZ for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Jul 2021 12:32:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52904) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m052I-0006AM-9Y for bug-gnu-emacs@gnu.org; Sun, 04 Jul 2021 12:32:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59744) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m052I-0000gN-2P for bug-gnu-emacs@gnu.org; Sun, 04 Jul 2021 12:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m052H-0003In-Vr for bug-gnu-emacs@gnu.org; Sun, 04 Jul 2021 12:32:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Trey Peacock Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Jul 2021 16:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49341 X-GNU-PR-Package: emacs Original-Received: via spool by 49341-submit@debbugs.gnu.org id=B49341.162541629012654 (code B ref 49341); Sun, 04 Jul 2021 16:32:01 +0000 Original-Received: (at 49341) by debbugs.gnu.org; 4 Jul 2021 16:31:30 +0000 Original-Received: from localhost ([127.0.0.1]:43057 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m051l-0003I2-OH for submit@debbugs.gnu.org; Sun, 04 Jul 2021 12:31:29 -0400 Original-Received: from mail-4317.protonmail.ch ([185.70.43.17]:43337) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m051h-0003Hl-CZ for 49341@debbugs.gnu.org; Sun, 04 Jul 2021 12:31:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=treypeacock.com; s=protonmail3; t=1625416278; bh=md2rxTtVUUSVSCVbyQFHm12l/i2Q8kPooqx9/mG0xU8=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=Ea2T+Pe5O8/PKDeVAPv/JouQV7B5qr0ax61XG/heIYgB7k6W0sUgruf3L1mtZL23Z cem/ogQ+uRBIHUZ75XxBhG2SkCUUt3yH5ShjisDKMoJi6gGm8XxdiktEqIF0okPBrc vffJtJNIfzHd6ChgRJOLUtU1SFQFiVdumLBTXhQiYHWLceJjCUhndxT/Cs4eL3F0Rr VWeKZUlXVo3XFFQ3z/iP9iYAXx4RYf6was8aoHtXgXomo1WxbztBDrnuROx/VV2+vu gxJGvHAv6GJtSjHg1C/Yr4mK0mCMM52mrWISiV8bCYkr7inI+0KLAbD+1QzA8H3AnM FZU0thoduGEOg== In-Reply-To: <87zgv22ndi.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:209414 Archived-At: "Lars Ingebrigtsen" writes: > Can you post the backtrace you get, too? (With `debug-on-error' set.) ``` Debugger entered--Lisp error: (wrong-type-argument integer-or-marker-p nil) bookmark--unfontify(("temp-book" (url . "emacs+burly+windows:?%28%28%28min-height%20.%204%2...") (handler . burly-bookmark-handler))) bookmark-delete("temp-book") load-with-code-conversion("/home/morpheus/.config/emacs/test-init.el" "/h= ome/morpheus/.config/emacs/test-init.el" nil t) command-line-1(("-l" "/home/morpheus/.config/emacs/test-init.el")) command-line() normal-top-level() ``` ``` (defun bookmark--unfontify (bm) "Remove a bookmark's colorized overlay. BM is a bookmark as returned from function `bookmark-get-bookmark'. See user option `bookmark-fontify'." (let ((filename (assq 'filename bm)) (pos (assq 'position bm)) overlays found temp) (when filename (setq filename (expand-file-name (cdr filename)))) (when pos (setq pos (cdr pos))) (dolist (buf (buffer-list)) (with-current-buffer buf (when (equal filename buffer-file-name) (setq overlays (overlays-at pos)) (while (and (not found) (setq temp (pop overlays))) (when (eq 'bookmark (overlay-get temp 'category)) (delete-overlay (setq found temp))))))))) ``` The bookmark has no 'filename' in its alist, so the value is nil. When compared to any non file-backed buffer in the buffer-list that will cause `(setq overlays (overlay-at pos))`. This results in the error with `(overlays-at nil)`.